From: Poornima Nayak <mpnayak@linux.vnet.ibm.com>
To: ltp-list@lists.sourceforge.net, svaidy@linux.vnet.ibm.com,
ego@in.ibm.com, arun@linux.vnet.ibm.com
Subject: [LTP] [Patch 1/6] Fix issues in cpu consolidation verification functions
Date: Tue, 13 Oct 2009 13:13:37 +0530 [thread overview]
Message-ID: <20091013074337.22414.20968.sendpatchset@localhost.localdomain> (raw)
Arguments passed for cpu consolidation was not used appropriatly. Provided
TINFO messages to indicate dependency test failures.
Signed-off-by: poornima nayak <mpnayak@linux.vnet.ibm.com>
diff -uprN ltp-full-20090930/testcases/kernel/power_management/pm_include.sh ltp-full-20090930_patched/testcases/kernel/power_management/pm_include.sh
--- ltp-full-20090930/testcases/kernel/power_management/pm_include.sh 2009-10-05 02:10:56.000000000 -0400
+++ ltp-full-20090930_patched/testcases/kernel/power_management/pm_include.sh 2009-10-12 22:46:12.000000000 -0400
@@ -71,7 +71,7 @@ get_supporting_govr() {
is_hyper_threaded() {
siblings=`cat /proc/cpuinfo | grep siblings | uniq | cut -f2 -d':'`
cpu_cores=`cat /proc/cpuinfo | grep "cpu cores" | uniq | cut -f2 -d':'`
- [ $siblings > $cpu_cores ]; return $?
+ [ $siblings -gt $cpu_cores ]; return $?
}
check_input() {
@@ -148,8 +148,8 @@ get_valid_input() {
analyze_result_hyperthreaded() {
sched_mc=$1
- pass_count=$3
- sched_smt=$4
+ pass_count=$2
+ sched_smt=$3
case "$sched_mc" in
0)
@@ -165,7 +165,7 @@ $sched_mc & sched_smt=$sched_smt"
fi
;;
*)
- if [ $pass_count -lt 5 ]; then
+ if [ $pass_count -lt 5 ]; then
tst_resm TFAIL "cpu consolidation for sched_mc=\
$sched_mc & sched_smt=$sched_smt"
else
@@ -190,10 +190,16 @@ $sched_mc & sched_smt=$sched_smt"
analyze_package_consolidation_result() {
sched_mc=$1
- pass_count=$3
- sched_smt=$4
+ pass_count=$2
+
+ if [ $# -gt 2 ]
+ then
+ sched_smt=$3
+ else
+ sched_smt=-1
+ fi
- if [ $hyper_threaded -eq $YES -a $sched_smt ]; then
+ if [ $hyper_threaded -eq $YES -a $sched_smt -gt -1 ]; then
analyze_result_hyperthreaded $sched_mc $pass_count $sched_smt
else
case "$sched_mc" in
@@ -209,10 +215,10 @@ $sched_mc"
*)
if [ $pass_count -lt 5 ]; then
tst_resm TFAIL "Consolidation at package level failed for \
-sched_mc=$sched_mc & sched_smt=$sched_smt"
+sched_mc=$sched_mc"
else
tst_resm TPASS "Consolidation at package level passed for \
-sched_mc=$sched_mc & sched_smt=$sched_smt"
+sched_mc=$sched_mc"
fi
;;
esac
@@ -221,7 +227,7 @@ sched_mc=$sched_mc & sched_smt=$sched_sm
analyze_core_consolidation_result() {
sched_smt=$1
- pass_count=$3
+ pass_count=$2
case "$sched_smt" in
0)
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2009-10-13 7:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 7:43 Poornima Nayak [this message]
2009-10-13 7:43 ` [LTP] [Patch 2/6] Developed new functions and fixed issues causing ilb test failure Poornima Nayak
2009-10-13 10:12 ` Subrata Modak
2009-10-14 2:17 ` Garrett Cooper
2009-10-14 9:25 ` Gautham R Shenoy
2009-11-27 10:09 ` poornima nayak
2009-10-13 7:43 ` [LTP] [Patch 3/6] Modified ilb test to run with ebizzy as default workload Poornima Nayak
2009-10-13 10:12 ` Subrata Modak
2009-10-13 7:44 ` [LTP] [Patch 4/6] Enhanced & Modified cpu_consolidation testcase Poornima Nayak
2009-10-13 10:12 ` Subrata Modak
2009-10-13 7:44 ` [LTP] [Patch 5/6] Modified master script to pass appropriate arguments Poornima Nayak
2009-10-13 10:12 ` Subrata Modak
2009-10-14 1:38 ` Garrett Cooper
2009-10-13 7:44 ` [LTP] [Patch 6/6] Patch to fix workload installation issue Poornima Nayak
2009-10-13 10:12 ` Subrata Modak
2009-10-14 1:39 ` Garrett Cooper
2009-10-13 10:12 ` [LTP] [Patch 1/6] Fix issues in cpu consolidation verification functions Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013074337.22414.20968.sendpatchset@localhost.localdomain \
--to=mpnayak@linux.vnet.ibm.com \
--cc=arun@linux.vnet.ibm.com \
--cc=ego@in.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox