From: Chandru <chandru@in.ibm.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: vapier@gentoo.org, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH V2] ppoll01: add signal() syscall to register the signal handler
Date: Thu, 15 Oct 2009 14:14:12 +0530 [thread overview]
Message-ID: <200910151414.13027.chandru@in.ibm.com> (raw)
In-Reply-To: <364299f40910141825k6d8a8e15w5843dd9d2574d262@mail.gmail.com>
On Thursday 15 October 2009 06:55:29 Garrett Cooper wrote:
> Just curious -- was the issue seen at the following point in the code
> previously?
>
> 361 TEST(sys_ret = syscall(__NR_ppoll, p_fds, nfds, p_ts,
> p_sigmask, sigsetsize)); /* <-- Blocks here indefinitely */
> 362 sys_errno = errno;
> 363 if (sys_ret <= 0 || tc->ret < 0)
> 364 goto TEST_END;
> 365
> 366 cmp_ok = fds[0].revents == tc->expect_revents;
>
> I've seen this issue 1 out of the 8 or 9 times I've run this test.
Nope, without the patch we only see case00 completing and the test exits while in the middle of case01
# ./ppoll01
ppoll01 0 TINFO : (case00) START
EXPECT: return value(ret)=(N >= 0) errno=0 (Success)
RESULT: return value(ret)= 1 errno=0 (Success)
ppoll01 0 TINFO : (case00) END => OK
ppoll01 0 TINFO : (case01) START
#
With the patch we see the output as follows...
# ./ppoll01
ppoll01 0 TINFO : (case00) START
EXPECT: return value(ret)=(N >= 0) errno=0 (Success)
RESULT: return value(ret)= 1 errno=0 (Success)
ppoll01 0 TINFO : (case00) END => OK
ppoll01 0 TINFO : (case01) START
EXPECT: return value(ret)=(N >= 0) errno=0 (Success)
RESULT: return value(ret)= 0 errno=0 (Success)
ppoll01 0 TINFO : (case01) END => OK
ppoll01 0 TINFO : (case02) START
EXPECT: return value(ret)=(N >= 0) errno=0 (Success)
RESULT: return value(ret)= 0 errno=0 (Success)
ppoll01 0 TINFO : (case02) END => OK
ppoll01 0 TINFO : (case03) START
EXPECT: return value(ret)=(N >= 0) errno=0 (Success)
RESULT: return value(ret)= 1 errno=0 (Success)
ppoll01 0 TINFO : (case03) END => OK
ppoll01 0 TINFO : (case04) START
EXPECT: return value(ret)=-1 errno=4 (Interrupted system call)
RESULT: return value(ret)=-1 errno=4 (Interrupted system call)
ppoll01 0 TINFO : (case04) END => OK
ppoll01 0 TINFO : (case05) START
EXPECT: return value(ret)=-1 errno=4 (Interrupted system call)
RESULT: return value(ret)=-1 errno=4 (Interrupted system call)
ppoll01 0 TINFO : (case05) END => OK
ppoll01 0 TINFO : (case06) START
EXPECT: return value(ret)=-1 errno=22 (Invalid argument)
RESULT: return value(ret)=-1 errno=22 (Invalid argument)
ppoll01 0 TINFO : (case06) END => OK
ppoll01 0 TINFO : (case07) START
EXPECT: return value(ret)=-1 errno=14 (Bad address)
RESULT: return value(ret)=-1 errno=14 (Bad address)
ppoll01 0 TINFO : (case07) END => OK
ppoll01 1 TPASS : ppoll01 call succeeded
#
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2009-10-15 8:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 8:10 [LTP] [PATCH V2] ppoll01: add signal() syscall to register the signal handler Chandru
2009-10-13 12:13 ` Subrata Modak
2009-10-14 6:41 ` Chandru
2009-10-14 20:28 ` Subrata Modak
2009-10-15 1:25 ` Garrett Cooper
2009-10-15 8:44 ` Chandru [this message]
2009-10-15 12:43 ` Garrett Cooper
2009-10-15 12:45 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910151414.13027.chandru@in.ibm.com \
--to=chandru@in.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox