Re: [LTP] [PATCH] Re: compile fails for libcpuset.c on SLES-11 s390x with ltp-full-20090930

[Cyril Hrubis <chrubis@suse.cz>]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Hi!
>     This logic is covered in include/mk/testcases.mk as follows:
> 
> include $(top_srcdir)/include/mk/env_pre.mk
> 
> # For linux_syscall_numbers.h
> CPPFLAGS                += -I$(abs_top_builddir)/testcases/kernel/include
> 
> INSTALL_DIR             := testcases/bin
> 
> LDLIBS                  += -lltp
> 
>     There's no reason why we have to go back to the hackish Makefile's
> -- we can just include testcases.mk if it's not included already (I
> admit, a smallhandful of testcases/... Makefile's didn't do this, but
> I did this on need-to-have basis).

I still would rather have one place to store all commonly used headers eg.
$(topdir)/include. And stroring makefile "libraries" in $(topdir)/include/mk/
is IMHO not cleanest solution, may be it sould have it's onw directory in
$(topdir).

Anyway fixed patch attached.

Signed-off-by: chrubis@suse.cz

-- 
Cyril Hrubis
chrubis@suse.cz

[-- Attachment #2: get_set_memopolicy_syscall_missing.patch --]
[-- Type: text/x-patch, Size: 2181 bytes --]

Index: delme/testcases/kernel/include/powerpc.in
===================================================================
--- delme.orig/testcases/kernel/include/powerpc.in
+++ delme/testcases/kernel/include/powerpc.in
@@ -3,6 +3,8 @@ timer_settime 241
 timer_delete 244
 clock_settime 245
 clock_gettime 246
+get_mempolicy 260
+set_mempolicy 261
 splice 283
 tee 284
 vmsplice 285
Index: delme/testcases/kernel/include/powerpc64.in
===================================================================
--- delme.orig/testcases/kernel/include/powerpc64.in
+++ delme/testcases/kernel/include/powerpc64.in
@@ -3,6 +3,8 @@ timer_settime 241
 timer_delete 244
 clock_settime 245
 clock_gettime 246
+get_mempolicy 260
+set_mempolicy 261
 splice 283
 tee 284
 vmsplice 285
Index: delme/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c
===================================================================
--- delme.orig/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c
+++ delme/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c
@@ -48,6 +48,9 @@
 #include "cpuset.h"
 #include "common.h"
 
+#include "test.h"
+#include "linux_syscall_numbers.h"
+
 /* Bump version, and update Change History, when libcpuset API changes */
 #define CPUSET_VERSION 3
 
Index: delme/testcases/kernel/include/s390x.in
===================================================================
--- delme.orig/testcases/kernel/include/s390x.in
+++ delme/testcases/kernel/include/s390x.in
@@ -1,3 +1,5 @@
+get_mempolicy 269
+set_mempolicy 270
 openat 288
 mkdirat (__NR_openat + 1)
 mknodat (__NR_openat + 2)
Index: delme/testcases/kernel/controllers/cpuset/cpuset_lib/Makefile
===================================================================
--- delme.orig/testcases/kernel/controllers/cpuset/cpuset_lib/Makefile
+++ delme/testcases/kernel/controllers/cpuset/cpuset_lib/Makefile
@@ -18,11 +18,12 @@
 #    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #
 # Garrett Cooper, July 2009
+# Cyril Hrubis, October 2009
 #
 
 top_srcdir 		?= ../../../../..
 
-include $(top_srcdir)/include/mk/env_pre.mk
+include $(top_srcdir)/include/mk/testcases.mk
 
 LDLIBS			+= -lm -lcontrollers
 

[-- Attachment #3: Type: text/plain, Size: 399 bytes --]

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list