From: Cyril Hrubis <chrubis@suse.cz>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: LTP Mailing List <ltp-list@lists.sourceforge.net>,
Mark Ver <markver@us.ibm.com>, Sachin P Sant <sachinp@in.ibm.com>
Subject: Re: [LTP] [PATCH] Re: compile fails for libcpuset.c on SLES-11 s390x with ltp-full-20090930
Date: Thu, 15 Oct 2009 21:46:30 +0200 [thread overview]
Message-ID: <20091015194630.GC2875@schrodinger.suse.cz> (raw)
In-Reply-To: <364299f40910151228n23d96e98g3850bfa9e78bd987@mail.gmail.com>
Hi!
> >> Hmm, may be we should really move testcases/kernel/include into
> >> $(topdir)/include or better move them them to subdir in $(topdir)/include and
> >> put the generated header into $(topdir)/include, it would save us some more
> >> complexity when creating makefiles.
> >
> > Cyril,
> > Files generated at build time should _never_ live in the source
> > directory. Otherwise tidiness becomes a serious issue, esp with source
> > control.
> > This can be corrected by adding this logic to a common Makefile if
> > you like, so that way it does get picked up from one common source.
> > This makes more sense from a design perspective.
>
> Ugh, I'm tired... yes, what you proposed above was correct, but
> not complete from a submake perspective, but then again making
> Makefiles aren't correct. I will implement the complete part this
> weekend.
Okay ;)
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2009-10-15 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 11:56 [LTP] [PATCH] Re: compile fails for libcpuset.c on SLES-11 s390x with ltp-full-20090930 Subrata Modak
2009-10-15 16:23 ` Cyril Hrubis
2009-10-15 17:30 ` Cyril Hrubis
[not found] ` <364299f40910151155x646bcf38naa53e5af4aad75b3@mail.gmail.com>
2009-10-15 19:14 ` Cyril Hrubis
[not found] ` <364299f40910151209s4a75e999he76b9c1d9b58a88a@mail.gmail.com>
[not found] ` <364299f40910151211r48d7510fnfc3c69a685923ca5@mail.gmail.com>
2009-10-15 19:20 ` Cyril Hrubis
[not found] ` <364299f40910151225lea3392fj9e36f4afe43fe67d@mail.gmail.com>
2009-10-15 19:39 ` Cyril Hrubis
[not found] ` <364299f40910151228n23d96e98g3850bfa9e78bd987@mail.gmail.com>
2009-10-15 19:46 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015194630.GC2875@schrodinger.suse.cz \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=markver@us.ibm.com \
--cc=sachinp@in.ibm.com \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox