public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net, Nate Straz <nate@refried.org>,
	Mitani <mitani@ryobi.co.jp>
Subject: Re: [LTP] mbind01 test failed with after ltp-2009-11-12.tar.gz
Date: Wed, 25 Nov 2009 00:33:22 -0500	[thread overview]
Message-ID: <200911250033.23404.vapier@gentoo.org> (raw)
In-Reply-To: <364299f40911242117g6baf6281r1e7191a201d4203c@mail.gmail.com>


[-- Attachment #1.1: Type: Text/Plain, Size: 1185 bytes --]

On Wednesday 25 November 2009 00:17:16 Garrett Cooper wrote:
> --- regen.sh	19 Nov 2009 19:35:15 -0000	1.12
> +++ regen.sh	25 Nov 2009 05:12:13 -0000
> @@ -32,8 +32,13 @@ static void cleanup(void);
>  		tst_brkm(TCONF, cleanup, "syscall " #NR " not supported on your arch");
>  \\ errno = ENOSYS; \\
>  		__ret = -1; \\
> -	} else \\
> +	} else { \\
>  		__ret = syscall(NR, ##__VA_ARGS__); \\
> +		if (__ret == -1 && errno == ENOSYS) { \\
> +			tst_brkm(TCONF, cleanup, "syscall " #NR " not supported on your arch");
>  \\ +			errno = ENOSYS; \\
> +		} \\
> +	} \\
>  	__ret; \\
>  })
>  EOF

i'd prefer this change
--- testcases/kernel/include/regen.sh	9 Oct 2009 17:55:48 -0000	1.11
+++ testcases/kernel/include/regen.sh	25 Nov 2009 05:28:27 -0000
@@ -30,11 +30,12 @@ static void cleanup(void);
 #define syscall(NR, ...) ({ \\
 	int __ret; \\
 	if (NR == 0) { \\
-		tst_brkm(TCONF, cleanup, "syscall " #NR " not supported on your arch"); \\
 		errno = ENOSYS; \\
 		__ret = -1; \\
 	} else \\
 		__ret = syscall(NR, ##__VA_ARGS__); \\
+	if (__ret == -1 && errno == ENOSYS) \\
+		tst_brkm(TCONF, cleanup, "syscall " #NR " not supported on your arch"); \\
 	__ret; \\
 })
 EOF

-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 354 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2009-11-25  5:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25  3:07 [LTP] mbind01 test failed with after ltp-2009-11-12.tar.gz Mitani
2009-11-25  5:17 ` Garrett Cooper
2009-11-25  5:33   ` Mike Frysinger [this message]
2009-11-25  6:26     ` Garrett Cooper
2009-11-25  7:36       ` Mike Frysinger
2009-11-25  7:42         ` Garrett Cooper
2009-11-26  3:02       ` Mitani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911250033.23404.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=mitani@ryobi.co.jp \
    --cc=nate@refried.org \
    --cc=yanegomi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox