Re: [LTP] mbind01 test failed with after ltp-2009-11-12.tar.gz

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 2067 bytes --]

On Wednesday 25 November 2009 01:26:20 Garrett Cooper wrote:
> On Tue, Nov 24, 2009 at 9:33 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Wednesday 25 November 2009 00:17:16 Garrett Cooper wrote:
> >> --- regen.sh  19 Nov 2009 19:35:15 -0000      1.12
> >> +++ regen.sh  25 Nov 2009 05:12:13 -0000
> >> @@ -32,8 +32,13 @@ static void cleanup(void);
> >>               tst_brkm(TCONF, cleanup, "syscall " #NR " not supported on
> >> your arch"); \\ errno = ENOSYS; \\
> >>               __ret = -1; \\
> >> -     } else \\
> >> +     } else { \\
> >>               __ret = syscall(NR, ##__VA_ARGS__); \\
> >> +             if (__ret == -1 && errno == ENOSYS) { \\
> >> +                     tst_brkm(TCONF, cleanup, "syscall " #NR " not
> >> supported on your arch"); \\ +                 errno = ENOSYS; \\
> >> +             } \\
> >> +     } \\
> >>       __ret; \\
> >>  })
> >>  EOF
> >
> > i'd prefer this change
> > --- testcases/kernel/include/regen.sh   9 Oct 2009 17:55:48 -0000      
> > 1.11 +++ testcases/kernel/include/regen.sh   25 Nov 2009 05:28:27 -0000
> > @@ -30,11 +30,12 @@ static void cleanup(void);
> >  #define syscall(NR, ...) ({ \\
> >        int __ret; \\
> >        if (NR == 0) { \\
> > -               tst_brkm(TCONF, cleanup, "syscall " #NR " not supported
> > on your arch"); \\ errno = ENOSYS; \\
> >                __ret = -1; \\
> >        } else \\
> >                __ret = syscall(NR, ##__VA_ARGS__); \\
> > +       if (__ret == -1 && errno == ENOSYS) \\
> > +               tst_brkm(TCONF, cleanup, "syscall " #NR " not supported
> > on your arch"); \\ __ret; \\
> >  })
> >  EOF
> 
>     Ok -- that makes more sense.. besides, I think gcc was optimizing
> out the first branch with -O2 if it always evaluated to false. Here's
> the new patch (I'm keeping the errno = ENOSYS part because I want to
> make sure that tst_brkm doesn't mess up the errno value if a write(2)
> fails or something).

i thought tst_brkm exited when called with a cleanup func like we do here
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 354 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list