From: Mike Frysinger <vapier@gentoo.org>
To: ltp-list@lists.sourceforge.net
Cc: Jiri Palecek <jpalecek@web.de>
Subject: Re: [LTP] [PATCH] Don't install datafiles with executable mode
Date: Fri, 4 Dec 2009 14:06:40 -0500 [thread overview]
Message-ID: <200912041406.40770.vapier@gentoo.org> (raw)
In-Reply-To: <4b1940f3.8413f30a.2877.6a27SMTPIN_ADDED@mx.google.com>
[-- Attachment #1.1: Type: Text/Plain, Size: 598 bytes --]
On Friday 04 December 2009 11:58:13 Jiri Palecek wrote:
> the makefiles install all files with executable mode by default. This patch
> changes it for some of the Makefiles, that install data files, which
> should IMHO not be executable. The change makes INSTALL_MODE decide the
> actual mode when it is expanded inside the install rule (depending on $@,
> which is the install target name).
that's pretty fugly way to go about it. let's go the more natural route and
have the common code default to $(INSTALL_MODE_$@) and if that's unset, use
the default $(INSTALL_MODE).
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 300 bytes --]
------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next parent reply other threads:[~2009-12-04 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4b1940f3.8413f30a.2877.6a27SMTPIN_ADDED@mx.google.com>
2009-12-04 19:06 ` Mike Frysinger [this message]
2009-12-05 1:19 ` [LTP] [PATCH] Don't install datafiles with executable mode Jiří Paleček
2009-12-05 4:58 ` Mike Frysinger
2009-12-19 2:05 ` Jiří Paleček
2009-12-19 4:48 ` Garrett Cooper
2009-12-05 6:39 ` Garrett Cooper
2009-12-19 2:05 ` Jiří Paleček
2009-12-04 16:58 Jiri Palecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912041406.40770.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=jpalecek@web.de \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox