* [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
[not found] <733784191.211351260530878824.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
@ 2009-12-11 11:30 ` Caspar Zhang
2009-12-11 20:04 ` Mike Frysinger
0 siblings, 1 reply; 11+ messages in thread
From: Caspar Zhang @ 2009-12-11 11:30 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
Hi all,
Here are two patches to fix compiling error in ia64,
I tested only in version ltp-full-20091130, please check
your own version. They are for work well on my system.
See the attachment.
Thanks,
Caspar
[-- Attachment #2: ia64-fpreg_redef-compile-err.patch --]
[-- Type: application/octet-stream, Size: 1485 bytes --]
On ia64 machines, the compilation can't pass. The error messages:
In file included from /usr/include/asm/ptrace.h:58,
from ../../syscalls/ptrace/ptrace.h:17,
from vfork.c:44:
/usr/include/asm/fpu.h:57: error: redefinition of ‘struct ia64_fpreg’
In file included from ../../syscalls/ptrace/ptrace.h:17,
from vfork.c:44:
/usr/include/asm/ptrace.h:208: error: redefinition of ‘struct pt_all_user_regs’
make[5]: *** [vfork] Error 1
After investigating, I found in ia64 platform, the file asm/ptrace.h conflicts
with sys/ptrace.h and linux/ptrace.h, so I did some tricks on ptrace.h in
testcase/kernel/syscall/ptrace: if it is in a ia64 machine, don't include
<asm/ptrace.h>. I think it's an ugly fix because it may not meet the dev's
need, but it works on my system.
Signed-off-by: Caspar Zhang <czhang@redhat.com>
diff -Naur a/testcases/kernel/syscalls/ptrace/ptrace.h b/testcases/kernel/syscalls/ptrace/ptrace.h
--- a/testcases/kernel/syscalls/ptrace/ptrace.h 2009-11-28 07:04:45.000000000 +0800
+++ b/testcases/kernel/syscalls/ptrace/ptrace.h 2009-12-11 18:36:44.519077249 +0800
@@ -13,9 +13,13 @@
#ifdef HAVE_SYS_REG_H
# include <sys/reg.h>
#endif
+/* fix compile error on ia64,
+ * FIXME: it's an ugly fix may not meet the developer's needs */
+#if ! defined(__ia64__)
#if defined(HAVE_ASM_PTRACE_H)
# include <asm/ptrace.h>
#endif
+#endif
/* ia64's a real pain.. */
#if defined(__ia64__)
#undef FU_ia64_fpreg
[-- Attachment #3: ptrace04-no_cleanup-compile-err.patch --]
[-- Type: application/octet-stream, Size: 977 bytes --]
on some system without HAVE_STRUCT_PT_REGS and HAVE_STRUCT_USER_REGS_STRUCT
defined, ptrace04.c will not pass the compiling due to the missing of
cleanup() function.
Signed-off-by: Caspar Zhang <czhang@redhat.com>
diff -Naur a/testcases/kernel/syscalls/ptrace/ptrace04.c b/testcases/kernel/syscalls/ptrace/ptrace04.c
--- a/testcases/kernel/syscalls/ptrace/ptrace04.c 2009-11-28 07:04:45.000000000 +0800
+++ b/testcases/kernel/syscalls/ptrace/ptrace04.c 2009-12-11 18:28:34.903140324 +0800
@@ -46,6 +46,23 @@
int TST_TOTAL = 2;
+/*
+ *cleanup() - performs all ONE TIME cleanup for this test at
+ * completion or premature exit.
+ */
+void cleanup()
+{
+
+ /*
+ * print timing stats if that option was specified.
+ * print errno log if that option was specified.
+ */
+ TEST_CLEANUP;
+
+ /* exit with return code appropriate for results */
+ tst_exit();
+} /* End cleanup() */
+
void compare_registers(unsigned char poison)
{
#ifdef HAVE_STRUCT_PTRACE_REGS
[-- Attachment #4: Type: text/plain, Size: 191 bytes --]
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
[-- Attachment #5: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
2009-12-11 11:30 ` Caspar Zhang
@ 2009-12-11 20:04 ` Mike Frysinger
0 siblings, 0 replies; 11+ messages in thread
From: Mike Frysinger @ 2009-12-11 20:04 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1.1: Type: Text/Plain, Size: 472 bytes --]
On Friday 11 December 2009 06:30:01 Caspar Zhang wrote:
> Here are two patches to fix compiling error in ia64,
> I tested only in version ltp-full-20091130, please check
> your own version. They are for work well on my system.
> See the attachment.
the ia64 change is incorrect. there's ia64 ifdef hacks in there already which
are to be used.
the ppc64 issue is not ppc64 or ptrace specific. garrett has a different fix
in the pipeline for that.
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 191 bytes --]
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
[not found] <1117953467.268911260765366627.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
@ 2009-12-14 4:36 ` Caspar Zhang
2009-12-18 18:27 ` Mike Frysinger
0 siblings, 1 reply; 11+ messages in thread
From: Caspar Zhang @ 2009-12-14 4:36 UTC (permalink / raw)
To: Mike Frysinger; +Cc: ltp-list
[-- Attachment #1: Type: text/plain, Size: 2580 bytes --]
----- "Mike Frysinger" <vapier@gentoo.org> wrote:
> On Friday 11 December 2009 06:30:01 Caspar Zhang wrote:
> > Here are two patches to fix compiling error in ia64,
> > I tested only in version ltp-full-20091130, please check
> > your own version. They are for work well on my system.
> > See the attachment.
>
> the ia64 change is incorrect. there's ia64 ifdef hacks in there
> already which
> are to be used.
the ia64 ifdef hacks in 20091130 are the following lines(in file
ptrace.h):
17 /* ia64's a real pain.. */
18 #if defined(__ia64__)
19 #undef FU_ia64_fpreg
20 #undef FU_pt_all_user_regs
21 #if ! defined(ia64_fpreg)
22 # define ia64_fpreg FU_ia64_fpreg
23 #endif
24 #if ! defined(pt_all_user_regs)
25 # define pt_all_user_regs FU_pt_all_user_regs
26 #endif
27 #endif
I don't think these codes could sovle the compiling problem. Nor the
following codes in latest cvs :
23 #if defined(__ia64__)
24 #if !defined(ia64_fpreg)
25 # define ia64_fpreg FU_ia64_fpreg
26 #endif
27 #if !defined(pt_all_user_regs)
28 # define pt_all_user_regs FU_pt_all_user_regs
29 #endif
30 #undef FU_ia64_fpreg
31 #undef FU_pt_all_user_regs
32 #endif /* defined(__ia64__) */
I tried to compile in RHEL5u4(kernel 2.6.18) but failed. I have given
the error mesage in the patch:
In file included from /usr/include/asm/ptrace.h:58,
from ../../syscalls/ptrace/ptrace.h:17,
from vfork.c:44:
/usr/include/asm/fpu.h:57: error: redefinition of ‘struct ia64_fpreg’
In file included from ../../syscalls/ptrace/ptrace.h:17,
from vfork.c:44:
/usr/include/asm/ptrace.h:208: error: redefinition of ‘struct pt_all_user_regs’
make[5]: *** [vfork] Error 1
System told me there was a definition conflict, but I could only find one
definition in my system. I have searched the whole system and found the
definition was in <asm/fpu.h>, which was included by <asm/ptrace.h>.
I just deleted #include <asm/ptrace.h> from testcases/kernel/syscalls/ptrace/ptrace.h
and the compilation continued till the cleanup-not-found error occured(My
second patch should fix this problem). I don't know why stop including <asm/ptrace.h>
can pass the compilation. I attach the <sys/ptrace.h> <asm/ptrace.h> <linux/ptrace.h>
from ia64 system(kernel 2.6.18) to the mail, may this help.
>
> the ppc64 issue is not ppc64 or ptrace specific. garrett has a
> different fix
> in the pipeline for that.
> -mike
[-- Attachment #2: ptrace.h.tar.gz --]
[-- Type: application/x-gzip, Size: 4981 bytes --]
[-- Attachment #3: Type: text/plain, Size: 191 bytes --]
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
@ 2009-12-15 6:14 Mitani
2009-12-15 19:39 ` Garrett Cooper
0 siblings, 1 reply; 11+ messages in thread
From: Mitani @ 2009-12-15 6:14 UTC (permalink / raw)
To: ltp-list
Hi,
I applied following Casper's patch to "ltp-2009-12-10" cvs,
then "make" succeeded in RHEL5.4 ia64 system:
http://www.mail-archive.com/ltp-list@lists.sourceforge.net/msg08991.html
On the other hand, I used Repository's following sources,
but "make" failed.
- "ptrace.h" (Revision 1.9)
- "ptrace04.c" (Revision 1.13)
But, at least, I think that the Repository's revision about "ptrace04.c"
is right. And "ptrace04.c" of "ltp-2009-12-15" cvs is same one.
Today, I arranged Casper's "ptrace.h" patch for "ltp-2009-12-15" cvs
and applied it to this cvs, and "make" succeeded.
I tried following other systems as using this patch, and succeeded:
- RHEL5.4(kernel : 2.6.18-164.el5) and x86 architecture
- RHEL5.4(kernel : 2.6.18-164.el5) and x86_64 architecture
- RHEL4.8(kernel : 2.6.9-89.ELsmp) and x86 architecture
The make failure can be evaded by only adding the condition of
"system isn't ia64" to the condition of "# include <asm/ptrace.h>" ...
Thank you--
-Tomonori Mitani
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
2009-12-15 6:14 [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130) Mitani
@ 2009-12-15 19:39 ` Garrett Cooper
2009-12-18 18:21 ` Mike Frysinger
2009-12-18 18:31 ` Mike Frysinger
0 siblings, 2 replies; 11+ messages in thread
From: Garrett Cooper @ 2009-12-15 19:39 UTC (permalink / raw)
To: Mitani; +Cc: ltp-list
On Mon, Dec 14, 2009 at 10:14 PM, Mitani <mitani@ryobi.co.jp> wrote:
> Hi,
>
> I applied following Casper's patch to "ltp-2009-12-10" cvs,
> then "make" succeeded in RHEL5.4 ia64 system:
> http://www.mail-archive.com/ltp-list@lists.sourceforge.net/msg08991.html
>
> On the other hand, I used Repository's following sources,
> but "make" failed.
> - "ptrace.h" (Revision 1.9)
> - "ptrace04.c" (Revision 1.13)
>
> But, at least, I think that the Repository's revision about "ptrace04.c"
> is right. And "ptrace04.c" of "ltp-2009-12-15" cvs is same one.
>
>
> Today, I arranged Casper's "ptrace.h" patch for "ltp-2009-12-15" cvs
> and applied it to this cvs, and "make" succeeded.
>
>
> I tried following other systems as using this patch, and succeeded:
> - RHEL5.4(kernel : 2.6.18-164.el5) and x86 architecture
> - RHEL5.4(kernel : 2.6.18-164.el5) and x86_64 architecture
> - RHEL4.8(kernel : 2.6.9-89.ELsmp) and x86 architecture
Until this issue is resolved (I ran into problems trying to use
crossdev, so I'll have to manually inspect headers after I track down
which versions are used in the Redhat distros specified), please
remember that you _can_ always comment out the line which says:
/* Define to 1 if you have the <asm/ptrace.h> header file. */
#define HAVE_ASM_PTRACE_H 1
Actually, I think I'll just remove that header check if the build
passes unless Mike objects, because we really shouldn't be
#include'ing asm/* headers without having a good reason to do so
because it results in pain of this magnitude...
Thanks,
-Garrett
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
2009-12-15 19:39 ` Garrett Cooper
@ 2009-12-18 18:21 ` Mike Frysinger
2009-12-18 18:31 ` Mike Frysinger
1 sibling, 0 replies; 11+ messages in thread
From: Mike Frysinger @ 2009-12-18 18:21 UTC (permalink / raw)
To: ltp-list; +Cc: Mitani
[-- Attachment #1.1: Type: Text/Plain, Size: 1820 bytes --]
On Tuesday 15 December 2009 14:39:24 Garrett Cooper wrote:
> On Mon, Dec 14, 2009 at 10:14 PM, Mitani wrote:
> > I applied following Casper's patch to "ltp-2009-12-10" cvs,
> > then "make" succeeded in RHEL5.4 ia64 system:
> > http://www.mail-archive.com/ltp-list@lists.sourceforge.net/msg08991.html
> >
> > On the other hand, I used Repository's following sources,
> > but "make" failed.
> > - "ptrace.h" (Revision 1.9)
> > - "ptrace04.c" (Revision 1.13)
> >
> > But, at least, I think that the Repository's revision about "ptrace04.c"
> > is right. And "ptrace04.c" of "ltp-2009-12-15" cvs is same one.
> >
> >
> > Today, I arranged Casper's "ptrace.h" patch for "ltp-2009-12-15" cvs
> > and applied it to this cvs, and "make" succeeded.
> >
> >
> > I tried following other systems as using this patch, and succeeded:
> > - RHEL5.4(kernel : 2.6.18-164.el5) and x86 architecture
> > - RHEL5.4(kernel : 2.6.18-164.el5) and x86_64 architecture
> > - RHEL4.8(kernel : 2.6.9-89.ELsmp) and x86 architecture
>
> Until this issue is resolved (I ran into problems trying to use
> crossdev, so I'll have to manually inspect headers after I track down
> which versions are used in the Redhat distros specified), please
> remember that you _can_ always comment out the line which says:
>
> /* Define to 1 if you have the <asm/ptrace.h> header file. */
> #define HAVE_ASM_PTRACE_H 1
>
> Actually, I think I'll just remove that header check if the build
> passes unless Mike objects, because we really shouldn't be
> #include'ing asm/* headers without having a good reason to do so
> because it results in pain of this magnitude...
the linux/asm ptrace headers are the only place where register defines are
found. the C library ptrace only includes common ptrace requests.
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 390 bytes --]
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
2009-12-14 4:36 ` Caspar Zhang
@ 2009-12-18 18:27 ` Mike Frysinger
0 siblings, 0 replies; 11+ messages in thread
From: Mike Frysinger @ 2009-12-18 18:27 UTC (permalink / raw)
To: Caspar Zhang; +Cc: ltp-list
[-- Attachment #1.1: Type: Text/Plain, Size: 1065 bytes --]
On Sunday 13 December 2009 23:36:12 Caspar Zhang wrote:
> ----- "Mike Frysinger" <vapier@gentoo.org> wrote:
> > On Friday 11 December 2009 06:30:01 Caspar Zhang wrote:
> > > Here are two patches to fix compiling error in ia64,
> > > I tested only in version ltp-full-20091130, please check
> > > your own version. They are for work well on my system.
> > > See the attachment.
> >
> > the ia64 change is incorrect. there's ia64 ifdef hacks in there
> > already which
> > are to be used.
>
> the ia64 ifdef hacks in 20091130 are the following lines(in file
> ptrace.h):
>
> 17 /* ia64's a real pain.. */
> 18 #if defined(__ia64__)
> 19 #undef FU_ia64_fpreg
> 20 #undef FU_pt_all_user_regs
> 21 #if ! defined(ia64_fpreg)
> 22 # define ia64_fpreg FU_ia64_fpreg
> 23 #endif
> 24 #if ! defined(pt_all_user_regs)
> 25 # define pt_all_user_regs FU_pt_all_user_regs
> 26 #endif
> 27 #endif
>
> I don't think these codes could sovle the compiling problem.
they do if they're used right
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 390 bytes --]
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
2009-12-15 19:39 ` Garrett Cooper
2009-12-18 18:21 ` Mike Frysinger
@ 2009-12-18 18:31 ` Mike Frysinger
2009-12-19 5:10 ` Garrett Cooper
1 sibling, 1 reply; 11+ messages in thread
From: Mike Frysinger @ 2009-12-18 18:31 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1.1: Type: Text/Plain, Size: 995 bytes --]
On Tuesday 15 December 2009 14:39:24 Garrett Cooper wrote:
> Until this issue is resolved (I ran into problems trying to use
> crossdev, so I'll have to manually inspect headers after I track down
> which versions are used in the Redhat distros specified), please
> remember that you _can_ always comment out the line which says:
>
> /* Define to 1 if you have the <asm/ptrace.h> header file. */
> #define HAVE_ASM_PTRACE_H 1
>
> Actually, I think I'll just remove that header check if the build
> passes unless Mike objects, because we really shouldn't be
> #include'ing asm/* headers without having a good reason to do so
> because it results in pain of this magnitude...
i guess i dont know why you've made changes to the ptrace.h header at all.
the original one i committed still works for me on bfin/ia64/x86/x86_64. i
dont recall any questions being posted to the list about the logic, just
random shuffling to try and "fix" errors that i have yet to see.
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 390 bytes --]
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
2009-12-18 18:31 ` Mike Frysinger
@ 2009-12-19 5:10 ` Garrett Cooper
2009-12-19 12:55 ` Mike Frysinger
0 siblings, 1 reply; 11+ messages in thread
From: Garrett Cooper @ 2009-12-19 5:10 UTC (permalink / raw)
To: Mike Frysinger; +Cc: ltp-list
On Fri, Dec 18, 2009 at 10:31 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Tuesday 15 December 2009 14:39:24 Garrett Cooper wrote:
>> Until this issue is resolved (I ran into problems trying to use
>> crossdev, so I'll have to manually inspect headers after I track down
>> which versions are used in the Redhat distros specified), please
>> remember that you _can_ always comment out the line which says:
>>
>> /* Define to 1 if you have the <asm/ptrace.h> header file. */
>> #define HAVE_ASM_PTRACE_H 1
>>
>> Actually, I think I'll just remove that header check if the build
>> passes unless Mike objects, because we really shouldn't be
>> #include'ing asm/* headers without having a good reason to do so
>> because it results in pain of this magnitude...
>
> i guess i dont know why you've made changes to the ptrace.h header at all.
> the original one i committed still works for me on bfin/ia64/x86/x86_64. i
> dont recall any questions being posted to the list about the logic, just
> random shuffling to try and "fix" errors that i have yet to see.
You're right. I've reverted to your original copy and everything
just works on my Gentoo box. I need to determine if our headers are
f'ed up at work -- I wouldn't be surprised if that's the case.
If others need for this to be fixed on their toolchains /
platforms, we'll definitely need access to the tools and/or maybe the
hardware in order to verify that the changes are sane.
Thanks as always :\,
-Garrett
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
2009-12-19 5:10 ` Garrett Cooper
@ 2009-12-19 12:55 ` Mike Frysinger
2010-01-16 23:56 ` Garrett Cooper
0 siblings, 1 reply; 11+ messages in thread
From: Mike Frysinger @ 2009-12-19 12:55 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
[-- Attachment #1.1: Type: Text/Plain, Size: 1698 bytes --]
On Saturday 19 December 2009 00:10:58 Garrett Cooper wrote:
> On Fri, Dec 18, 2009 at 10:31 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Tuesday 15 December 2009 14:39:24 Garrett Cooper wrote:
> >> Until this issue is resolved (I ran into problems trying to use
> >> crossdev, so I'll have to manually inspect headers after I track down
> >> which versions are used in the Redhat distros specified), please
> >> remember that you _can_ always comment out the line which says:
> >>
> >> /* Define to 1 if you have the <asm/ptrace.h> header file. */
> >> #define HAVE_ASM_PTRACE_H 1
> >>
> >> Actually, I think I'll just remove that header check if the build
> >> passes unless Mike objects, because we really shouldn't be
> >> #include'ing asm/* headers without having a good reason to do so
> >> because it results in pain of this magnitude...
> >
> > i guess i dont know why you've made changes to the ptrace.h header at
> > all. the original one i committed still works for me on
> > bfin/ia64/x86/x86_64. i dont recall any questions being posted to the
> > list about the logic, just random shuffling to try and "fix" errors that
> > i have yet to see.
>
> You're right. I've reverted to your original copy and everything
> just works on my Gentoo box. I need to determine if our headers are
> f'ed up at work -- I wouldn't be surprised if that's the case.
> If others need for this to be fixed on their toolchains /
> platforms, we'll definitely need access to the tools and/or maybe the
> hardware in order to verify that the changes are sane.
feel free to post the error you're seeing at work with this version so we can
take a look.
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 390 bytes --]
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)
2009-12-19 12:55 ` Mike Frysinger
@ 2010-01-16 23:56 ` Garrett Cooper
0 siblings, 0 replies; 11+ messages in thread
From: Garrett Cooper @ 2010-01-16 23:56 UTC (permalink / raw)
To: Mike Frysinger; +Cc: ltp-list
On Sat, Dec 19, 2009 at 4:55 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Saturday 19 December 2009 00:10:58 Garrett Cooper wrote:
>> On Fri, Dec 18, 2009 at 10:31 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> > On Tuesday 15 December 2009 14:39:24 Garrett Cooper wrote:
>> >> Until this issue is resolved (I ran into problems trying to use
>> >> crossdev, so I'll have to manually inspect headers after I track down
>> >> which versions are used in the Redhat distros specified), please
>> >> remember that you _can_ always comment out the line which says:
>> >>
>> >> /* Define to 1 if you have the <asm/ptrace.h> header file. */
>> >> #define HAVE_ASM_PTRACE_H 1
>> >>
>> >> Actually, I think I'll just remove that header check if the build
>> >> passes unless Mike objects, because we really shouldn't be
>> >> #include'ing asm/* headers without having a good reason to do so
>> >> because it results in pain of this magnitude...
>> >
>> > i guess i dont know why you've made changes to the ptrace.h header at
>> > all. the original one i committed still works for me on
>> > bfin/ia64/x86/x86_64. i dont recall any questions being posted to the
>> > list about the logic, just random shuffling to try and "fix" errors that
>> > i have yet to see.
>>
>> You're right. I've reverted to your original copy and everything
>> just works on my Gentoo box. I need to determine if our headers are
>> f'ed up at work -- I wouldn't be surprised if that's the case.
>> If others need for this to be fixed on their toolchains /
>> platforms, we'll definitely need access to the tools and/or maybe the
>> hardware in order to verify that the changes are sane.
>
> feel free to post the error you're seeing at work with this version so we can
> take a look.
I'm not going to sweat it because it's most likely because the
build infrastructure and how they're cross-compiling junk and the
versioned packages used in my current group is fubar (paths are out of
whack and the sources are really feature incompatible). I'm leaving
the group in a week, so by the time they have to resolve this it may
or may not matter for them... thus, ultimately I don't care :}...
Thanks,
-Garrett
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2010-01-16 23:56 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 6:14 [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130) Mitani
2009-12-15 19:39 ` Garrett Cooper
2009-12-18 18:21 ` Mike Frysinger
2009-12-18 18:31 ` Mike Frysinger
2009-12-19 5:10 ` Garrett Cooper
2009-12-19 12:55 ` Mike Frysinger
2010-01-16 23:56 ` Garrett Cooper
[not found] <1117953467.268911260765366627.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
2009-12-14 4:36 ` Caspar Zhang
2009-12-18 18:27 ` Mike Frysinger
[not found] <733784191.211351260530878824.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
2009-12-11 11:30 ` Caspar Zhang
2009-12-11 20:04 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox