public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Michal Simek <michal.simek@petalogix.com>
Cc: ltp-list@lists.sourceforge.net, vapier@gentoo.org
Subject: Re: [LTP] clone tests fails
Date: Mon, 4 Jan 2010 10:49:54 -0600	[thread overview]
Message-ID: <20100104164954.GB26962@us.ibm.com> (raw)
In-Reply-To: <4B421480.1040400@petalogix.com>

Quoting Michal Simek (michal.simek@petalogix.com):
> Hi Mike,
> 
> I have one question about one your big patch
> 
> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=391dc18fe3271fbf2ca1864a5299f091c31e0018
> 
> My question is why you add -1 in lib/cloner.c:65
> 
> +       ret = clone(fn, (stack ? stack + stack_size - 1 : NULL),
> +                       clone_flags, arg);
> 
> In previous code in clone testcases was nothing like this.
> What reason have you had to add it?

Because the same thing was done in lots of places all over the
testsuite (and done wrong).  This consolidates them all.

> Of course the reason is that on Microblaze some tests failed.

How do they fail?  Does clone on Microblaze take the top of
stack?

-serge

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2010-01-04 16:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-04 16:17 [LTP] clone tests fails Michal Simek
2010-01-04 16:49 ` Serge E. Hallyn [this message]
2010-01-04 17:35   ` Michal Simek
2010-01-04 17:49     ` Serge E. Hallyn
2010-01-06  1:05       ` Jiri Palecek
2010-01-06  3:26         ` Serge E. Hallyn
2010-01-06  5:25           ` Mike Frysinger
2010-01-07  1:25             ` Jiri Palecek
2010-01-06 10:19           ` Michal Simek
2010-01-06  5:25         ` Mike Frysinger
2010-01-07  1:21           ` Jiri Palecek
2010-01-06 10:15         ` Michal Simek
2010-01-07  1:12           ` Jiri Palecek
2010-01-07 14:12             ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100104164954.GB26962@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=michal.simek@petalogix.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox