Re: [LTP] clone tests fails

Serge E. Hallyn
2010-01-04T16:50:09Z

Quoting Michal Simek (michal.simek@petalogix.com):
> Hi Mike,
>
> I have one question about one your big patch
>
> http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=391dc18fe3271fbf2ca1864a5299f091c31e0018
>
> My question is why you add -1 in lib/cloner.c:65
>
> + ret = clone(fn, (stack ? stack + stack_size - 1 : NULL),
> + clone_flags, arg);
>
> In previous code in clone testcases was nothing like this.
> What reason have you had to add it?

Because the same thing was done in lots of places all over the
testsuite (and done wrong). This consolidates them all.

> Of course the reason is that on Microblaze some tests failed.

How do they fail? Does clone on Microblaze take the top of
stack?

-serge