From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 1/1] say FAIL not PASS when we failed
Date: Tue, 5 Jan 2010 21:22:53 -0600 [thread overview]
Message-ID: <20100106032253.GA8157@us.ibm.com> (raw)
In-Reply-To: <364299f41001051853n3d95e1b8hd2cdabca77ad59ef@mail.gmail.com>
Quoting Garrett Cooper (yanegomi@gmail.com):
> Ok, so before I commit I just want to make sure that this makes sense with you:
>
> The differences are:
> 1. The id -?r?u use.
Either one can be fooled, neither should be...
> 2. The while [ ! ... -a ... ] vs until [ ... -o ... ] logic (is more
> clear in my mind because it better describes the desired end-state)
> 3. Removing the which calls (because which doesn't exist on busybox
> from what I've heard) and replacing them with non-absolute commands
> (because it's the same thing...).
All look fine to me.
thanks,
-serge
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2010-01-06 3:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 17:16 [LTP] [PATCH 1/1] say FAIL not PASS when we failed Serge E. Hallyn
2010-01-04 22:59 ` Garrett Cooper
2010-01-04 23:36 ` Serge E. Hallyn
2010-01-05 2:12 ` Garrett Cooper
2010-01-05 15:30 ` Serge E. Hallyn
2010-01-05 16:45 ` Garrett Cooper
2010-01-05 17:33 ` Serge E. Hallyn
2010-01-05 17:46 ` Garrett Cooper
2010-01-06 2:53 ` Garrett Cooper
2010-01-06 3:22 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106032253.GA8157@us.ibm.com \
--to=serue@us.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox