Re: [LTP] regression: selinux testsuite broken since October

["Serge E. Hallyn" <serue@us.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

Quoting Serge E. Hallyn (serue@us.ibm.com):
> Quoting Serge E. Hallyn (serue@us.ibm.com):
> > Quoting Stephen Smalley (sds@tycho.nsa.gov):
> > > On Mon, 2010-01-11 at 13:50 -0600, Serge E. Hallyn wrote:
> > > > > Fails with:
> > > > > cp: cannot stat
> > > > > `/home/sds/ltp/testcases/kernel/security/selinux-testsuite/refpolicy/policy_files/generic/test_policy.*': No such file or directory
> > > > 
> > > > You ran /home/sds/ltp/testscripts/test_selinux.sh, right?
> > > > 
> > > > I think we are supposed to actually be running
> > > > /opt/ltp/testscripts/test_selinux.sh.  So then the first question for
> > > > Garrett is how should we deduce /home/sds/ltp as $LTP_SRCDIR from a
> > > > testscript?  Or should the policy sources be copied into /opt?
> > > 
> > > Ok, but regardless:  the refpolicy Makefile is still broken.
> > 
> > Yup.
> 
> All right, baby-steps.
> 
> The attached test_selinux.diff is not to be applied, but something
> like it is needed.  Should we have the ltp 'make install' fill in
> TOP_SRCDIR in /opt/ltp/testscripts/test_selinux.sh?  BTW, Garrett,
> that is the issue I was saying is shared between test_selinux.sh
> and some others including test_robind.sh.  That's why I'm not just
> sending a patch to make it work, bc i think we need more general
> guidance.
> 
> The second match makes the 'make load' part of test_selinux.sh
> succeed on rhel5.4.  Stephen, how does it do on fedora?
> 
> After loading policy it fails to execute ltp-pan, but I figure let's
> get policy loading working first.
> 
> -serge

gah, attaching the actual patches this time.

-serge

[-- Attachment #2: Makefile.diff --]
[-- Type: text/x-diff, Size: 431 bytes --]

--- /root/ltp_cvs_orig/ltp/testcases/kernel/security/selinux-testsuite/refpolicy/Makefile	2010-01-08 04:39:20.000000000 -0500
+++ testcases/kernel/security/selinux-testsuite/refpolicy/Makefile	2010-01-11 15:52:13.000000000 -0500
@@ -34,6 +34,8 @@
 
 ifeq ($(strip $(DISTRO_VER)),)
 DISTRO_VER		:= generic
+else
+DISTRO_VER		:= $(shell echo $(DISTRO_VER) | cut -d . -f 1 - )
 endif
 
 CHECKPOLICY		?= $(DESTDIR)/usr/bin/checkpolicy

[-- Attachment #3: test_selinux.diff --]
[-- Type: text/x-diff, Size: 630 bytes --]

--- /root/ltp_cvs_orig/ltp/testscripts/test_selinux.sh	2009-05-19 05:39:11.000000000 -0400
+++ /opt/ltp/testscripts/test_selinux.sh	2010-01-11 15:11:34.000000000 -0500
@@ -77,10 +77,12 @@
 
 SEMODULE="/usr/sbin/semodule"
 
+TOP_SRCDIR=/root/ltp
+
 if [ -f $SEMODULE ]; then
-    POLICYDIR="$LTPROOT/testcases/kernel/security/selinux-testsuite/refpolicy"
+    POLICYDIR="$TOP_SRCDIR/testcases/kernel/security/selinux-testsuite/refpolicy"
 else
-    POLICYDIR="$LTPROOT/testcases/kernel/security/selinux-testsuite/policy"
+    POLICYDIR="$TOP_SRCDIR/testcases/kernel/security/selinux-testsuite/policy"
 fi
 
 config_set_expandcheck

[-- Attachment #4: Type: text/plain, Size: 390 bytes --]

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 

[-- Attachment #5: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list