[LTP] [patch] swapon03 cleanup v2

[LTP] [patch] swapon03 cleanup v2

[Murlin Wenzel]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

Added clean_swap() to cleanup routine.  This makes sure all leftover swap files are removed.

Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com


Murlin Ray Wenzel
Sr. Engineer
mwenzel@novell.com
Office: 801 861 5748
Cell: 801 380 4520

Novell
Making IT Work As One.
www.novell.com







[-- Attachment #2: swapon03-cleanup-v2.patch --]
[-- Type: text/plain, Size: 403 bytes --]

--- ltp-intermediate-20100228-orig/testcases/kernel/syscalls/swapon/swapon03.c	2010-02-24 09:00:53.000000000 -0700
+++ ltp-intermediate-20100228/testcases/kernel/syscalls/swapon/swapon03.c	2010-02-24 16:36:38.000000000 -0700
@@ -461,6 +461,9 @@
 	 */
 	TEST_CLEANUP;
 
+	/* remove any remaining swap files */
+	clean_swap();
+
 	/* Remove tmp dir and all files inside it */
 	tst_rmdir();
 

[-- Attachment #3: Murlin Wenzel.vcf --]
[-- Type: application/octet-stream, Size: 721 bytes --]

BEGIN:VCARD
VERSION:2.1
PRODID:-//Novell Inc//Groupwise 8.0.1 
X-GWTYPE:USER
FN:Murlin Wenzel
N:Wenzel;Murlin;;Sr. Engineer
EMAIL;INTERNET;PREF:MWENZEL@novell.com
ADR;WORK;PREF:;PRV-D-131;1800 South Novell Place;Provo;UT;84606;
LABEL;WORK;PREF;ENCODING=QUOTED-PRINTABLE:1800 South Novell Place=0D=0A=
Provo=0D=0A=
UT=0D=0A=
84606
UID:13D4B520-092F-0000-86DE-00805F8A09C5
TEL;VOICE;PREF:1-801-861-5748
TEL;VOICE;WORK:1-801-861-5748
TEL;FAX;PREF:801/861-5415
TITLE:Sr. Engineer
REV:20100222T110957Z
X-GWUDF:9(Mail Stop)PRV-D-131
X-GWUDF:11(Employee ID)02661
X-GWUDF:8(Mailstop)PRV-E-141
X-GWUDF:12(Workforce ID)02661
X-GWUDF:7(Country)USA
X-GWUDF:24(AOL Instant Messaging ID)mwenzelses
END:VCARD


[-- Attachment #4: Type: text/plain, Size: 345 bytes --]

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

[-- Attachment #5: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Garrett Cooper]

On Wed, Feb 24, 2010 at 3:49 PM, Murlin Wenzel <mwenzel@novell.com> wrote:
> Added clean_swap() to cleanup routine.  This makes sure all leftover swap files are removed.
>
> Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com

Committed -- thanks!
-Garrett

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Rishikesh K Rajak]

On Wed, Feb 24, 2010 at 05:08:56PM -0800, Garrett Cooper wrote:
> On Wed, Feb 24, 2010 at 3:49 PM, Murlin Wenzel <mwenzel@novell.com> wrote:
> > Added clean_swap() to cleanup routine.  This makes sure all leftover swap files are removed.
> >
> > Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com
> 
> Committed -- thanks!
> -Garrett

Thanks Garret & Murlin.

-Rishi
> 
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list

-- 
Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Rishikesh K Rajak]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

On Thu, Feb 25, 2010 at 11:56:15AM +0530, Rishikesh K Rajak wrote:
> On Wed, Feb 24, 2010 at 05:08:56PM -0800, Garrett Cooper wrote:
> > On Wed, Feb 24, 2010 at 3:49 PM, Murlin Wenzel <mwenzel@novell.com> wrote:
> > > Added clean_swap() to cleanup routine.  This makes sure all leftover swap files are removed.
> > >
> > > Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com
> > 
> > Committed -- thanks!
> > -Garrett
> 
> Thanks Garret & Murlin.


Hi Murlin,

can you please look into this failure as it still fails on my SLES11 & RHEl5.4
boxes.

[root@mx3455a bin]# ./swapon03 
swapon03    1  TFAIL  :  Failed swapon for file swapfile29: errno=EPERM(1):
Operation not permitted
swapon03    0  TWARN  :  tst_rmdir(): rmobj(/tmp/swasf2sLb) failed:
unlink(/tmp/swasf2sLb/swapfile22) failed; errno=1: Operation not permitted
swapon03    1  TFAIL  :  Failed to setup swaps

attached is the strace log.

-Rishi

-- 
Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net

[-- Attachment #2: strace-log-swapon03 --]
[-- Type: text/plain, Size: 6554 bytes --]

[root@mx3455a bin]# ./swapon03 
swapon03    1  TFAIL  :  Failed swapon for file swapfile29: errno=EPERM(1): Operation not permitted
swapon03    0  TWARN  :  tst_rmdir(): rmobj(/tmp/swasf2sLb) failed: unlink(/tmp/swasf2sLb/swapfile22) failed; errno=1: Operation not permitted
swapon03    1  TFAIL  :  Failed to setup swaps
[root@mx3455a bin]# strace ./swapon03
execve("./swapon03", ["./swapon03"], [/* 24 vars */]) = 0
brk(0)                                  = 0x110d000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f3295231000
access("/etc/ld.so.preload", R_OK)      = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY)      = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=54784, ...}) = 0
mmap(NULL, 54784, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f3295223000
close(3)                                = 0
open("/lib64/libc.so.6", O_RDONLY)      = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0`\354\1\0\0\0\0\0@"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=2435432, ...}) = 0
mmap(NULL, 3668136, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f3294c93000
mprotect(0x7f3294e0a000, 2093056, PROT_NONE) = 0
mmap(0x7f3295009000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x176000) = 0x7f3295009000
mmap(0x7f329500e000, 18600, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f329500e000
close(3)                                = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f3295222000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f3295221000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f3295220000
arch_prctl(ARCH_SET_FS, 0x7f3295221700) = 0
mprotect(0x7f3295009000, 16384, PROT_READ) = 0
mprotect(0x7f3295232000, 4096, PROT_READ) = 0
munmap(0x7f3295223000, 54784)           = 0
brk(0)                                  = 0x110d000
brk(0x112e000)                          = 0x112e000
uname({sys="Linux", node="mx3455a.in.ibm.com", ...}) = 0
rt_sigaction(SIGHUP, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGINT, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGQUIT, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGILL, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGTRAP, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGABRT, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGBUS, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGFPE, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGUSR1, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGSEGV, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGUSR2, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGPIPE, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGALRM, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGTERM, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGSTKFLT, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGTSTP, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGTTIN, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGTTOU, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGURG, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGXCPU, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGXFSZ, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGVTALRM, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGPROF, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGWINCH, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGIO, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGPWR, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGSYS, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
rt_sigaction(SIGRT_16, {0x404b10, [], SA_RESTORER|SA_RESTART, 0x7f3294cc65e0}, {SIG_DFL, [], 0}, 8) = 0
geteuid()                               = 0
gettimeofday({1268222682, 1696}, NULL)  = 0
getpid()                                = 7784
mkdir("/tmp/swaXQgZbx", 0700)           = 0
getgid()                                = 0
chown("/tmp/swaXQgZbx", 4294967295, 0)  = 0
chmod("/tmp/swaXQgZbx", 0777)           = 0
chdir("/tmp/swaXQgZbx")                 = 0
statfs(".", {f_type="EXT2_SUPER_MAGIC", f_bsize=4096, f_blocks=12598961, f_bfree=11482616, f_bavail=10842616, f_files=3203072, f_ffree=3044055, f_fsid={695368058, -1211746724}, f_namelen=255, f_frsize=4096}) = 0
statfs(".", {f_type="EXT2_SUPER_MAGIC", f_bsize=4096, f_blocks=12598961, f_bfree=11482616, f_bavail=10842616, f_files=3203072, f_ffree=3044055, f_fsid={695368058, -1211746724}, f_namelen=255, f_frsize=4096}) = 0
setresuid(-1, 0, -1)                    = 0
open("/proc/swaps", O_RDONLY)           = 3
read(3, "Filename\t\t\t\tType\t\tSize\tUsed\tPrior"..., 8192) = 1643
close(3)                                = 0
clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7f32952219d0) = 7785
wait4(7785, swapon03    1  TFAIL  :  Failed swapon for file swapfile02: errno=EPERM(1): Operation not permitted
[{WIFEXITED(s) && WEXITSTATUS(s) == 1}], 0, NULL) = 7785
--- SIGCHLD (Child exited) @ 0 (0) ---
fstat(1, {st_mode=S_IFCHR|0620, st_rdev=makedev(136, 1), ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f3295230000
write(1, "swapon03    1  TFAIL  :  Failed t"..., 47swapon03    1  TFAIL  :  Failed to setup swaps
) = 47
exit_group(1)                           = ?


[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Murlin Wenzel]

>>> On 3/10/2010 at 05:15 AM, in message
<20100310121544.GB11404@linux.vnet.ibm.com>, Rishikesh K Rajak
<risrajak@linux.vnet.ibm.com> wrote: 
> On Thu, Feb 25, 2010 at 11:56:15AM +0530, Rishikesh K Rajak wrote:
>> On Wed, Feb 24, 2010 at 05:08:56PM -0800, Garrett Cooper wrote:
>> > On Wed, Feb 24, 2010 at 3:49 PM, Murlin Wenzel <mwenzel@novell.com> wrote:
>> > > Added clean_swap() to cleanup routine.  This makes sure all leftover swap 
> files are removed.
>> > >
>> > > Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com
>> > 
>> > Committed -- thanks!
>> > -Garrett
>> 
>> Thanks Garret & Murlin.
> 
> 
> Hi Murlin,
> 
> can you please look into this failure as it still fails on my SLES11 & 
> RHEl5.4
> boxes.
> 
> [root@mx3455a bin]# ./swapon03 
> swapon03    1  TFAIL  :  Failed swapon for file swapfile29: errno=EPERM(1):
> Operation not permitted
> swapon03    0  TWARN  :  tst_rmdir(): rmobj(/tmp/swasf2sLb) failed:
> unlink(/tmp/swasf2sLb/swapfile22) failed; errno=1: Operation not permitted
> swapon03    1  TFAIL  :  Failed to setup swaps
> 
> attached is the strace log.
> 
> -Rishi


That's the other part of the problem that I'm not sure what to do with yet.  The original test was written entirely based on the assumption that there were always a max of 30 swap files available.  With newer kernels (SLE11 RHEL5.4) the kernel can be configured so that the max could be as low as 29 if not 28.  The kernel is doing the right thing returning EPERM, but the test needs to be re-worked to deal with new maximum limits/possibilites.

Murlin


------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Garrett Cooper]

On Thu, Mar 11, 2010 at 7:48 AM, Murlin Wenzel <mwenzel@novell.com> wrote:
>>>> On 3/10/2010 at 05:15 AM, in message
> <20100310121544.GB11404@linux.vnet.ibm.com>, Rishikesh K Rajak
> <risrajak@linux.vnet.ibm.com> wrote:
>> On Thu, Feb 25, 2010 at 11:56:15AM +0530, Rishikesh K Rajak wrote:
>>> On Wed, Feb 24, 2010 at 05:08:56PM -0800, Garrett Cooper wrote:
>>> > On Wed, Feb 24, 2010 at 3:49 PM, Murlin Wenzel <mwenzel@novell.com> wrote:
>>> > > Added clean_swap() to cleanup routine.  This makes sure all leftover swap
>> files are removed.
>>> > >
>>> > > Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com
>>> >
>>> > Committed -- thanks!
>>> > -Garrett
>>>
>>> Thanks Garret & Murlin.
>>
>>
>> Hi Murlin,
>>
>> can you please look into this failure as it still fails on my SLES11 &
>> RHEl5.4
>> boxes.
>>
>> [root@mx3455a bin]# ./swapon03
>> swapon03    1  TFAIL  :  Failed swapon for file swapfile29: errno=EPERM(1):
>> Operation not permitted
>> swapon03    0  TWARN  :  tst_rmdir(): rmobj(/tmp/swasf2sLb) failed:
>> unlink(/tmp/swasf2sLb/swapfile22) failed; errno=1: Operation not permitted
>> swapon03    1  TFAIL  :  Failed to setup swaps
>>
>> attached is the strace log.
>
> That's the other part of the problem that I'm not sure what to do with yet.  The original test was written entirely based on the assumption that there were always a max of 30 swap files available.  With newer kernels (SLE11 RHEL5.4) the kernel can be configured so that the max could be as low as 29 if not 28.  The kernel is doing the right thing returning EPERM, but the test needs to be re-worked to deal with new maximum limits/possibilites.

It should actually be KERNEL_MAX - (CONFIG_MIGRATION enabled ? 2 : 0)
- used_swap_devices ...

NOTES
       The partition or path must be prepared with mkswap(8).

       There is an upper limit on the number of swap files that may  be  used,
       defined  by  the  kernel constant MAX_SWAPFILES.  Before kernel 2.4.10,
       MAX_SWAPFILES has the value 8; since kernel 2.4.10, it  has  the  value
       32.  Since kernel 2.6.18, the limit is decreased by 2 (thus: 30) if the
       kernel is built with the CONFIG_MIGRATION option  (which  reserves  two
       swap  table  entries  for  the  page migration features of mbind(2) and
       migrate_pages(2)).

    The fun unknown is CONFIG_MIGRATION -- how do you know whether or
not this is set from userspace? There's too much handwaving in this
testcase that needs to be fixed.
Thanks,
-Garrett

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Murlin Wenzel]

[-- Attachment #1: Type: text/plain, Size: 3677 bytes --]

>>> On 3/13/2010 at 12:32 AM, in message
<364299f41003122332u3c4f93a7td3c1f9db1a360bec@mail.gmail.com>, Garrett Cooper
<yanegomi@gmail.com> wrote:
> On Thu, Mar 11, 2010 at 7:48 AM, Murlin Wenzel <mwenzel@novell.com> wrote:
>>>>> On 3/10/2010 at 05:15 AM, in message
>> <20100310121544.GB11404@linux.vnet.ibm.com>, Rishikesh K Rajak
>> <risrajak@linux.vnet.ibm.com> wrote:
>>> On Thu, Feb 25, 2010 at 11:56:15AM +0530, Rishikesh K Rajak wrote:
>>>> On Wed, Feb 24, 2010 at 05:08:56PM -0800, Garrett Cooper wrote:
>>>> > On Wed, Feb 24, 2010 at 3:49 PM, Murlin Wenzel <mwenzel@novell.com> wrote:
>>>> > > Added clean_swap() to cleanup routine.  This makes sure all leftover swap
>>> files are removed.
>>>> > >
>>>> > > Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com 
>>>> >
>>>> > Committed -- thanks!
>>>> > -Garrett
>>>>
>>>> Thanks Garret & Murlin.
>>>
>>>
>>> Hi Murlin,
>>>
>>> can you please look into this failure as it still fails on my SLES11 &
>>> RHEl5.4
>>> boxes.
>>>
>>> [root@mx3455a bin]# ./swapon03
>>> swapon03    1  TFAIL  :  Failed swapon for file swapfile29: errno=EPERM(1):
>>> Operation not permitted
>>> swapon03    0  TWARN  :  tst_rmdir(): rmobj(/tmp/swasf2sLb) failed:
>>> unlink(/tmp/swasf2sLb/swapfile22) failed; errno=1: Operation not permitted
>>> swapon03    1  TFAIL  :  Failed to setup swaps
>>>
>>> attached is the strace log.
>>
>> That's the other part of the problem that I'm not sure what to do with yet.  
> The original test was written entirely based on the assumption that there 
> were always a max of 30 swap files available.  With newer kernels (SLE11 
> RHEL5.4) the kernel can be configured so that the max could be as low as 29 
> if not 28.  The kernel is doing the right thing returning EPERM, but the test 
> needs to be re-worked to deal with new maximum limits/possibilites.
> 
> It should actually be KERNEL_MAX - (CONFIG_MIGRATION enabled ? 2 : 0)
> - used_swap_devices ...
> 
> NOTES
>        The partition or path must be prepared with mkswap(8).
> 
>        There is an upper limit on the number of swap files that may  be  
> used,
>        defined  by  the  kernel constant MAX_SWAPFILES.  Before kernel 
> 2.4.10,
>        MAX_SWAPFILES has the value 8; since kernel 2.4.10, it  has  the  
> value
>        32.  Since kernel 2.6.18, the limit is decreased by 2 (thus: 30) if 
> the
>        kernel is built with the CONFIG_MIGRATION option  (which  reserves  
> two
>        swap  table  entries  for  the  page migration features of mbind(2) 
> and
>        migrate_pages(2)).
> 
>     The fun unknown is CONFIG_MIGRATION -- how do you know whether or
> not this is set from userspace? There's too much handwaving in this
> testcase that needs to be fixed.

That's my point.  There are even more config options in newer kernels which affect the number of swap files.  AFAIK none of that info is available to userspace app.  The only known is MAX_SWAPFILES which is 32, or 8 on 2.4 kernels.  The current test makes an assumption that there would always be 32 or 30 swapfiles available based on a kernel config at some point in the past.  I'm thinking the test should just use MAX_SWAPFILES(32 in this case), try to create that many until EPERM error is returned, provide that TINFO to tester, clean up everything and if that succeeds call the test a pass.  It is too ugly trying to start guessing about is 29 ok, or 30 ok or 32 ok with no way of knowing how the kernel was configured.

-- 

Murlin Ray Wenzel
mwenzel@novell.com
Office: 801 861 5748
Cell: 801 380 4520

Novell,
Making IT work as one.
http://www.novell.com





[-- Attachment #2: Murlin Wenzel.vcf --]
[-- Type: application/octet-stream, Size: 706 bytes --]

BEGIN:VCARD
VERSION:2.1
PRODID:-//Novell Inc//Groupwise 8.0.1 
X-GWTYPE:USER
FN:Murlin Wenzel
N:Wenzel;Murlin;;Sr. Engineer
EMAIL;INTERNET;PREF:MWENZEL@novell.com
ADR;WORK;PREF:;PRV-D-131;1800 South Novell Place;Provo;UT;84606;
LABEL;WORK;PREF;ENCODING=QUOTED-PRINTABLE:1800 South Novell Place=0D=0A=
Provo, UT 84606
UID:13D4B520-092F-0000-86DE-00805F8A09C5
TEL;VOICE;PREF:1-801-861-5748
TEL;VOICE;WORK:1-801-861-5748
TEL;FAX;PREF:801/861-5415
TITLE:Sr. Engineer
REV:20100308T033142Z
X-GWUDF:9(Mail Stop)PRV-D-131
X-GWUDF:11(Employee ID)02661
X-GWUDF:8(Mailstop)PRV-E-141
X-GWUDF:12(Workforce ID)02661
X-GWUDF:7(Country)USA
X-GWUDF:24(AOL Instant Messaging ID)mwenzelses
END:VCARD


[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Garrett Cooper]

On Sat, Mar 13, 2010 at 9:26 AM, Murlin Wenzel <mwenzel@novell.com> wrote:
>>>> On 3/13/2010 at 12:32 AM, in message
> <364299f41003122332u3c4f93a7td3c1f9db1a360bec@mail.gmail.com>, Garrett Cooper
> <yanegomi@gmail.com> wrote:
>> On Thu, Mar 11, 2010 at 7:48 AM, Murlin Wenzel <mwenzel@novell.com> wrote:
>>>>>> On 3/10/2010 at 05:15 AM, in message
>>> <20100310121544.GB11404@linux.vnet.ibm.com>, Rishikesh K Rajak
>>> <risrajak@linux.vnet.ibm.com> wrote:
>>>> On Thu, Feb 25, 2010 at 11:56:15AM +0530, Rishikesh K Rajak wrote:
>>>>> On Wed, Feb 24, 2010 at 05:08:56PM -0800, Garrett Cooper wrote:
>>>>> > On Wed, Feb 24, 2010 at 3:49 PM, Murlin Wenzel <mwenzel@novell.com> wrote:
>>>>> > > Added clean_swap() to cleanup routine.  This makes sure all leftover swap
>>>> files are removed.
>>>>> > >
>>>>> > > Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com
>>>>> >
>>>>> > Committed -- thanks!
>>>>> > -Garrett
>>>>>
>>>>> Thanks Garret & Murlin.
>>>>
>>>>
>>>> Hi Murlin,
>>>>
>>>> can you please look into this failure as it still fails on my SLES11 &
>>>> RHEl5.4
>>>> boxes.
>>>>
>>>> [root@mx3455a bin]# ./swapon03
>>>> swapon03    1  TFAIL  :  Failed swapon for file swapfile29: errno=EPERM(1):
>>>> Operation not permitted
>>>> swapon03    0  TWARN  :  tst_rmdir(): rmobj(/tmp/swasf2sLb) failed:
>>>> unlink(/tmp/swasf2sLb/swapfile22) failed; errno=1: Operation not permitted
>>>> swapon03    1  TFAIL  :  Failed to setup swaps
>>>>
>>>> attached is the strace log.
>>>
>>> That's the other part of the problem that I'm not sure what to do with yet.
>> The original test was written entirely based on the assumption that there
>> were always a max of 30 swap files available.  With newer kernels (SLE11
>> RHEL5.4) the kernel can be configured so that the max could be as low as 29
>> if not 28.  The kernel is doing the right thing returning EPERM, but the test
>> needs to be re-worked to deal with new maximum limits/possibilites.
>>
>> It should actually be KERNEL_MAX - (CONFIG_MIGRATION enabled ? 2 : 0)
>> - used_swap_devices ...
>>
>> NOTES
>>        The partition or path must be prepared with mkswap(8).
>>
>>        There is an upper limit on the number of swap files that may  be
>> used,
>>        defined  by  the  kernel constant MAX_SWAPFILES.  Before kernel
>> 2.4.10,
>>        MAX_SWAPFILES has the value 8; since kernel 2.4.10, it  has  the
>> value
>>        32.  Since kernel 2.6.18, the limit is decreased by 2 (thus: 30) if
>> the
>>        kernel is built with the CONFIG_MIGRATION option  (which  reserves
>> two
>>        swap  table  entries  for  the  page migration features of mbind(2)
>> and
>>        migrate_pages(2)).
>>
>>     The fun unknown is CONFIG_MIGRATION -- how do you know whether or
>> not this is set from userspace? There's too much handwaving in this
>> testcase that needs to be fixed.
>
> That's my point.  There are even more config options in newer kernels which affect the number of swap files.  AFAIK none of that info is available to userspace app.  The only known is MAX_SWAPFILES which is 32, or 8 on 2.4 kernels.  The current test makes an assumption that there would always be 32 or 30 swapfiles available based on a kernel config at some point in the past.  I'm thinking the test should just use MAX_SWAPFILES(32 in this case), try to create that many until EPERM error is returned, provide that TINFO to tester, clean up everything and if that succeeds call the test a pass.  It is too ugly trying to start guessing about is 29 ok, or 30 ok or 32 ok with no way of knowing how the kernel was configured.

    Here's a good question: where is this information stored in the
kernel? If we can create an ltp test module to export some of this
data [and extend it to other reporting as necessary] via sysfs
STRICTLY for testing, it would help determinism a lot.
Thanks,
-Garrett

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Rishikesh K Rajak]

Hi Murlin,

Can you please look into this problem again ? It seems you had some discussion
with garret to reach to some conclusion about the reported failure.

-Rishi

On Sat, Mar 13, 2010 at 01:56:25PM -0800, Garrett Cooper wrote:
> On Sat, Mar 13, 2010 at 9:26 AM, Murlin Wenzel <mwenzel@novell.com> wrote:
> >>>> On 3/13/2010 at 12:32 AM, in message
> > <364299f41003122332u3c4f93a7td3c1f9db1a360bec@mail.gmail.com>, Garrett Cooper
> > <yanegomi@gmail.com> wrote:
> >> On Thu, Mar 11, 2010 at 7:48 AM, Murlin Wenzel <mwenzel@novell.com> wrote:
> >>>>>> On 3/10/2010 at 05:15 AM, in message
> >>> <20100310121544.GB11404@linux.vnet.ibm.com>, Rishikesh K Rajak
> >>> <risrajak@linux.vnet.ibm.com> wrote:
> >>>> On Thu, Feb 25, 2010 at 11:56:15AM +0530, Rishikesh K Rajak wrote:
> >>>>> On Wed, Feb 24, 2010 at 05:08:56PM -0800, Garrett Cooper wrote:
> >>>>> > On Wed, Feb 24, 2010 at 3:49 PM, Murlin Wenzel <mwenzel@novell.com> wrote:
> >>>>> > > Added clean_swap() to cleanup routine.  This makes sure all leftover swap
> >>>> files are removed.
> >>>>> > >
> >>>>> > > Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com
> >>>>> >
> >>>>> > Committed -- thanks!
> >>>>> > -Garrett
> >>>>>
> >>>>> Thanks Garret & Murlin.
> >>>>
> >>>>
> >>>> Hi Murlin,
> >>>>
> >>>> can you please look into this failure as it still fails on my SLES11 &
> >>>> RHEl5.4
> >>>> boxes.
> >>>>
> >>>> [root@mx3455a bin]# ./swapon03
> >>>> swapon03    1  TFAIL  :  Failed swapon for file swapfile29: errno=EPERM(1):
> >>>> Operation not permitted
> >>>> swapon03    0  TWARN  :  tst_rmdir(): rmobj(/tmp/swasf2sLb) failed:
> >>>> unlink(/tmp/swasf2sLb/swapfile22) failed; errno=1: Operation not permitted
> >>>> swapon03    1  TFAIL  :  Failed to setup swaps
> >>>>
> >>>> attached is the strace log.
> >>>
> >>> That's the other part of the problem that I'm not sure what to do with yet.
> >> The original test was written entirely based on the assumption that there
> >> were always a max of 30 swap files available.  With newer kernels (SLE11
> >> RHEL5.4) the kernel can be configured so that the max could be as low as 29
> >> if not 28.  The kernel is doing the right thing returning EPERM, but the test
> >> needs to be re-worked to deal with new maximum limits/possibilites.
> >>
> >> It should actually be KERNEL_MAX - (CONFIG_MIGRATION enabled ? 2 : 0)
> >> - used_swap_devices ...
> >>
> >> NOTES
> >>        The partition or path must be prepared with mkswap(8).
> >>
> >>        There is an upper limit on the number of swap files that may  be
> >> used,
> >>        defined  by  the  kernel constant MAX_SWAPFILES.  Before kernel
> >> 2.4.10,
> >>        MAX_SWAPFILES has the value 8; since kernel 2.4.10, it  has  the
> >> value
> >>        32.  Since kernel 2.6.18, the limit is decreased by 2 (thus: 30) if
> >> the
> >>        kernel is built with the CONFIG_MIGRATION option  (which  reserves
> >> two
> >>        swap  table  entries  for  the  page migration features of mbind(2)
> >> and
> >>        migrate_pages(2)).
> >>
> >>     The fun unknown is CONFIG_MIGRATION -- how do you know whether or
> >> not this is set from userspace? There's too much handwaving in this
> >> testcase that needs to be fixed.
> >
> > That's my point.  There are even more config options in newer kernels which affect the number of swap files.  AFAIK none of that info is available to userspace app.  The only known is MAX_SWAPFILES which is 32, or 8 on 2.4 kernels.  The current test makes an assumption that there would always be 32 or 30 swapfiles available based on a kernel config at some point in the past.  I'm thinking the test should just use MAX_SWAPFILES(32 in this case), try to create that many until EPERM error is returned, provide that TINFO to tester, clean up everything and if that succeeds call the test a pass.  It is too ugly trying to start guessing about is 29 ok, or 30 ok or 32 ok with no way of knowing how the kernel was configured.
> 
>     Here's a good question: where is this information stored in the
> kernel? If we can create an ltp test module to export some of this
> data [and extend it to other reporting as necessary] via sysfs
> STRICTLY for testing, it would help determinism a lot.
> Thanks,
> -Garrett

-- 
Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Murlin Wenzel]

>>> On 3/31/2010 at 03:22 AM, in message
<20100331092225.GB5048@linux.vnet.ibm.com>, Rishikesh K Rajak
<risrajak@linux.vnet.ibm.com> wrote: 
> Hi Murlin,
> 
> Can you please look into this problem again ? It seems you had some 
> discussion
> with garret to reach to some conclusion about the reported failure.
>

I'm trying to get back to it, but have been swamped with work right now.  The inherent problem is the fact that the test is based on a macro used during kernel build/compile time which was hard coded at one point in time.  The maximum number of swap files supported can vary based on kernel compile time switches.  I really don't think we want to try and build a kernel module or try to build the test assuming kernel headers and complete config are always available.
 
> -Rishi
> 
> On Sat, Mar 13, 2010 at 01:56:25PM -0800, Garrett Cooper wrote:
>> On Sat, Mar 13, 2010 at 9:26 AM, Murlin Wenzel <mwenzel@novell.com> wrote:
>> >>>> On 3/13/2010 at 12:32 AM, in message
>> > <364299f41003122332u3c4f93a7td3c1f9db1a360bec@mail.gmail.com>, Garrett Cooper
>> > <yanegomi@gmail.com> wrote:
>> >> On Thu, Mar 11, 2010 at 7:48 AM, Murlin Wenzel <mwenzel@novell.com> wrote:
>> >>>>>> On 3/10/2010 at 05:15 AM, in message
>> >>> <20100310121544.GB11404@linux.vnet.ibm.com>, Rishikesh K Rajak
>> >>> <risrajak@linux.vnet.ibm.com> wrote:
>> >>>> On Thu, Feb 25, 2010 at 11:56:15AM +0530, Rishikesh K Rajak wrote:
>> >>>>> On Wed, Feb 24, 2010 at 05:08:56PM -0800, Garrett Cooper wrote:
>> >>>>> > On Wed, Feb 24, 2010 at 3:49 PM, Murlin Wenzel <mwenzel@novell.com> wrote:
>> >>>>> > > Added clean_swap() to cleanup routine.  This makes sure all leftover swap
>> >>>> files are removed.
>> >>>>> > >
>> >>>>> > > Signed-off-By:  Murlin Ray Wenzel mwenzel@novell.com
>> >>>>> >
>> >>>>> > Committed -- thanks!
>> >>>>> > -Garrett
>> >>>>>
>> >>>>> Thanks Garret & Murlin.
>> >>>>
>> >>>>
>> >>>> Hi Murlin,
>> >>>>
>> >>>> can you please look into this failure as it still fails on my SLES11 &
>> >>>> RHEl5.4
>> >>>> boxes.
>> >>>>
>> >>>> [root@mx3455a bin]# ./swapon03
>> >>>> swapon03    1  TFAIL  :  Failed swapon for file swapfile29: errno=EPERM(1):
>> >>>> Operation not permitted
>> >>>> swapon03    0  TWARN  :  tst_rmdir(): rmobj(/tmp/swasf2sLb) failed:
>> >>>> unlink(/tmp/swasf2sLb/swapfile22) failed; errno=1: Operation not permitted
>> >>>> swapon03    1  TFAIL  :  Failed to setup swaps
>> >>>>
>> >>>> attached is the strace log.
>> >>>
>> >>> That's the other part of the problem that I'm not sure what to do with yet.
>> >> The original test was written entirely based on the assumption that there
>> >> were always a max of 30 swap files available.  With newer kernels (SLE11
>> >> RHEL5.4) the kernel can be configured so that the max could be as low as 29
>> >> if not 28.  The kernel is doing the right thing returning EPERM, but the 
> test
>> >> needs to be re-worked to deal with new maximum limits/possibilites.
>> >>
>> >> It should actually be KERNEL_MAX - (CONFIG_MIGRATION enabled ? 2 : 0)
>> >> - used_swap_devices ...
>> >>
>> >> NOTES
>> >>        The partition or path must be prepared with mkswap(8).
>> >>
>> >>        There is an upper limit on the number of swap files that may  be
>> >> used,
>> >>        defined  by  the  kernel constant MAX_SWAPFILES.  Before kernel
>> >> 2.4.10,
>> >>        MAX_SWAPFILES has the value 8; since kernel 2.4.10, it  has  the
>> >> value
>> >>        32.  Since kernel 2.6.18, the limit is decreased by 2 (thus: 30) if
>> >> the
>> >>        kernel is built with the CONFIG_MIGRATION option  (which  reserves
>> >> two
>> >>        swap  table  entries  for  the  page migration features of mbind(2)
>> >> and
>> >>        migrate_pages(2)).
>> >>
>> >>     The fun unknown is CONFIG_MIGRATION -- how do you know whether or
>> >> not this is set from userspace? There's too much handwaving in this
>> >> testcase that needs to be fixed.
>> >
>> > That's my point.  There are even more config options in newer kernels which 
> affect the number of swap files.  AFAIK none of that info is available to 
> userspace app.  The only known is MAX_SWAPFILES which is 32, or 8 on 2.4 
> kernels.  The current test makes an assumption that there would always be 32 
> or 30 swapfiles available based on a kernel config at some point in the past. 
>  I'm thinking the test should just use MAX_SWAPFILES(32 in this case), try to 
> create that many until EPERM error is returned, provide that TINFO to tester, 
> clean up everything and if that succeeds call the test a pass.  It is too 
> ugly trying to start guessing about is 29 ok, or 30 ok or 32 ok with no way 
> of knowing how the kernel was configured.
>> 
>>     Here's a good question: where is this information stored in the
>> kernel? If we can create an ltp test module to export some of this
>> data [and extend it to other reporting as necessary] via sysfs
>> STRICTLY for testing, it would help determinism a lot.
>> Thanks,
>> -Garrett




------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch] swapon03 cleanup v2

[Murlin Wenzel]

>>> On 3/31/2010 at 03:22 AM, in message
<20100331092225.GB5048@linux.vnet.ibm.com>, Rishikesh K Rajak
<risrajak@linux.vnet.ibm.com> wrote: 
> Hi Murlin,
> 
> Can you please look into this problem again ? It seems you had some 
> discussion
> with garret to reach to some conclusion about the reported failure.

I hope to grab a little time to look at this again.  The big problem is the fact that the MAX_SWAPFILES supported by a particular kernel is not an exported variable.  It's a compile time macro defined in a kernel header.  There is nothing to export.  That brings up a question about what constraints LTP should run under.  1.  Can I require kernel headers and the current .config file be present on the build or install system that is going to run LTP?  2.  Is there a common place to find the correct kernel headers and config file?  3.  How hard would it be to use something like autoconf or some other tool to setup the correct define during LTP build?

The only other option I see at this point is similar to what the current code does.  Start at a given number of swapfiles expected, then start trying to create more one at a time until an error is returned.  That's ugly since the starting point is always subject to change.

Murlin


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list