Re: [LTP] [BUG?] container_test.sh: should to delete check_for_unshare's source in cvs/git ?

Rishikesh K Rajak
2010-03-08T17:17:43Z

On Mon, Mar 08, 2010 at 07:53:08AM -0800, Garrett Cooper wrote:
> On Sun, Mar 7, 2010 at 6:56 PM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
> > Tested the latest cvs version (about Mar 1) on my x86_64 (2.6.33).
> > The following message occured:
> > --------------------------------
> > <<<test_start>>>
> > tag=Containers stime=1267527554
> > cmdline="container_test.sh"
> > contacts=""
> > analysis=exit
> > <<<test_output>>>
> > /opt/ltp/testcases/bin/container_test.sh: line 13: check_for_unshare: command not found
> > Running utsns tests.
> > unshare tests
> > test 1 (unshare)
> > test 2 (unshare)
> > ......
> > --------------------------------
> >
> > I noticed that check_for_unshare had been deleted in LTP-20091031.
> > In ./ChangeLog (from latest cvs version)
> >   ...
> >   2905 LTP-20091031
> >   ...
> >   3141 Removed Files:
> >   3142 ltp/README.ltp-devel
> >   3143 ltp/config.mk.in
> >   3144 ltp/ltp-devel.spec
> >   3145 ltp/testcases/kernel/containers/check_for_unshare.c
> >   ...
> >   3997 LTP-20090930
> >
> > Also, i noticed check_for_unshare commentted in container_test.sh in
> > release version of FEBRUARY 2010. pls check the diff between cvs version
> > and release version of Feb in attached file.
> >
> > Now, my question: should to delete check_for_unshare's source in cvs/git ?
>
> There was some discussion and the check was reenabled post the February release.

I looked at a glance in sleep mode and found there is something need to
be fixed here as i am still not able to find check_for_unshare.c . Well
i will look and fix tomorrow.

Thanks
Rishi

> Thanks,
> -Garrett

--
Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net