Re: [LTP] [PATCH] Synchronization required before release the lock: sem_post/8-1.c

[Rishikesh K Rajak <risrajak@linux.vnet.ibm.com>]

On Tue, Mar 23, 2010 at 12:20:33AM +0530, naresh kamboju wrote:
> On Mon, Mar 22, 2010 at 1:55 PM, Rishikesh K Rajak
> Hi Rishi,
> > can you send your patch against today's git ?
> please find the patch below and attached to this e-mail.

Hi Naresh,

Still i am not able to apply it cleanly.

In our git repo we are not finding this : 
"
-        /* Step 3 Implementation */
"

Can you pull latest next git branch and then create a patch and send it to me?
-Rishi

> Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
> 
> ---
>  testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c
> |   11 	6 +	5 -	0 !
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> Index: b/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c
> ===================================================================
> --- a/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c
> @@ -175,13 +175,13 @@ int main()
>  	}
>  	fprintf(stderr, "P: child_2: %d forked\n", c_2);
> 
> -        /* Step 3 Implementation */
>  	/* Make sure the two children has been waiting */	
> -	do {
> +	/*do {
> +		sleep();
>  		sem_getvalue(sem_1, &val);
>  		//printf("val = %d\n", val);
>  	} while (val != 1);
> -
> +	*/
>  	c_3 = fork();
>  	if (c_3 == 0)
>  	{
> @@ -190,12 +190,13 @@ int main()
>  	}
>  	fprintf(stderr, "P: child_3: %d forked\n", c_3);
>  	
> -        /* Step 3 Implementation */
>  	/* Make sure child 3 has been waiting for the lock */	
> -	do {
> +	/*do {
> +		sleep();
>  		sem_getvalue(sem_1, &val);
>  		//printf("val = %d\n", val);
>  	} while (val != 0);
> +	*/
> 
>  	/* Synchronization required before release the lock */
>  	sleep(1);
> 
> 
> Best regards
> Naresh Kamboju
> >
> > -Rishi
> >>
> >> Best regards
> >> Naresh Kamboju
> >> >
> >> > Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
> >> > ---
> >> >  testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c
> >> > |    2  1 +     1 -     0 !
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > Index: b/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c
> >> > ===================================================================
> >> > --- a/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c
> >> > +++ b/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c
> >> > @@ -161,7 +161,6 @@ int main()
> >> >        }
> >> >        fprintf(stderr, "P: child_1:%d forked\n", c_1);
> >> >
> >> > -       sleep(1);
> >> >        c_2 = fork();
> >> >        if (c_2 == 0)
> >> >        {
> >> > @@ -198,6 +197,7 @@ int main()
> >> >                //printf("val = %d\n", val);
> >> >        } while (val != 0);
> >> >        */
> >> > +       sleep(1);
> >> >        /* Ok, let's release the lock */
> >> >        fprintf(stderr, "P: release lock\n");
> >> >        sem_post(sem);
> >> >
> >> >
> >> > please let me know if you have any issues.
> >> >
> >> > Best regards,
> >> > Naresh Kamboju
> >> >> Thanks,
> >> >> -Garrett
> >> >>
> >> >
> >
> >
> >
> > --
> > Thanks & Regards
> > Rishi
> > LTP Maintainer
> > IBM, LTC, Bangalore
> > Please join IRC #ltp @ irc.freenode.net
> >



-- 
Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list