Re: [LTP] [BUG] cgroup_fj tests fail to run due to missing cgroup_fj_testcases

[Rishikesh K Rajak <risrajak@linux.vnet.ibm.com>]

On Tue, Mar 23, 2010 at 07:53:14PM +0530, Srinivasa R Chamarthy wrote:
> Sorry, i meant that the script run_cgroup_test_fj.sh executes another function
> called cgroup_fj_stress.sh with a parameter which is got from parsing the file
> cgroup_fj_testcases which will have test execution methods. The file
> cgroup_fj_testcases is parsed as follows:
> 
> nlines=`cat cgroup_fj_testcases | wc -l`
> for i in `seq 1 $nlines`
> do
>         CASETYPE=`sed -n "$i""p" cgroup_fj_testcases | cut -f1`
>         CASECMD=`sed -n "$i""p" cgroup_fj_testcases | cut -f2`
> 
> Which thus by CASECMD becomes parameter for cgroup_fj_stress.sh. I do not
> think that cgroup_fj_testcases should have any prefix as .sh as it is not
> meant to be a executable. May be instead of suffixing the file with .sh it
> could be left alone as a bare file without any suffix.

Yes you are absolutely correct i feel.

-Rishi
> 
> On Tue, Mar 23, 2010 at 07:40:40PM +0530, Srinivasa R Chamarthy wrote:
> > Hi Rishi,
> > 
> > There seems to be another issue here. There are two files with name as
> > cgroup_fj_testcases. one is the script which already has the suffix as .sh
> > (cgroup_fj_testcases.sh) which is executed by cgroup_fj tests. But there has
> > to be one more file which is bare cgroup_fj_testcases which is having the test
> > configurations that are run by the cgroup_fj_testcases.sh script.
> > 
> > The bare configuration file cgroup_fj_testcases should have the test's to be
> > run configurations (i suppose). The testcase run_cgroup_test_fj.sh is
> > referencing cgroup_fj_testcases file as follows.
> > 
> > nlines=`cat cgroup_fj_testcases | wc -l`
> > 
> > I think this configuration file cgroup_fj_testcases is totally missing out in
> > the head. Let me know if i am correct.
> > 
> > On Tue, Mar 23, 2010 at 07:02:24PM +0530, Srinivasa R Chamarthy wrote:
> > > Hi Rishi,
> > > 
> > > Thanks for the info.
> > > 
> > > On Tue, Mar 23, 2010 at 06:44:38PM +0530, Rishikesh K Rajak wrote:
> > > > On Tue, Mar 23, 2010 at 05:55:27PM +0530, Srinivasa R Chamarthy wrote:
> > > > > Hi LTP,
> > > > > 
> > > > > cgroup_fj tests of controllers is currently failing due to missing file
> > > > > cgroup_fj_testcases after compilation. I see that the file cgroup_fj_testcases
> > > > > is existing in the source but it is not available in /opt/ltp after
> > > > > compilation.
> > > > 
> > > > 
> > > > Hi Srini,
> > > > 
> > > > Thanks for reporting failure.
> > > > 
> > > > Yes, looks like this commit is doing the changes from cgroup_fj_testcases to
> > > > cgroup_fj_testcases.sh .
> > > > 
> > > > commit 223e12ee3f7fdb525746462747954552f0e07538
> > > > Author: Garrett Cooper <yanegomi@gmail.com>
> > > > Date:   Mon Mar 8 07:46:02 2010 -0800
> > > > 
> > > >     Fix install for cgroup_fj_testcases.
> > > >     
> > > >     Turns out this script wasn't being installed properly, and thus its
> > > > testcases were failing; fix by suffixing with .sh
> > > >     
> > > >     Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
> > > > 
> > > > 
> > > > 
> > > > Let me have a look tomorrow where went wrong.
> > > > -Rishi
> > > > > 
> > > > > FAILED COMMAND File: /opt/ltp/output/LTP_RUN_ON-2010_Mar_23-13h_22m_15s.failed
> > > > > Running tests.......
> > > > > <<<test_start>>>
> > > > > tag=cgroup_fj stime=1269346936
> > > > > cmdline="      run_cgroup_test_fj.sh"
> > > > > contacts=""
> > > > > analysis=exit
> > > > > <<<test_output>>>
> > > > > incrementing stop
> > > > > Now, we start the test for cgroup...
> > > > > cat: cgroup_fj_testcases: No such file or directory
> > > > > <<<execution_status>>>
> > > > > initiation_status="ok"
> > > > > duration=0 termination_type=exited termination_id=0 corefile=no
> > > > > cutime=6 cstime=2
> > > > > <<<test_end>>>
> > > > > INFO: ltp-pan reported all tests PASS
> > > > > LTP Version: LTP-20100228
> > > > > 
> > > > > Eventhough the tests did not run, the results say all tests PASS. :)
> > > > > 
> > > > > -- 
> > > > > Srinivasa R Chamarthy (schamart@linux.vnet.ibm.com)
> > > > > Linux on System z (RedHat & Novell SuSE) CSVT,
> > > > > IBM India Systems & Technology Group/LTC - ISL,
> > > > > Bangalore - 560071, KA, INDIA. Off: +91-80-41776451 
> > > > > [ http://www.ibm.com/in/isl | http://www.ibm.com/linux/ltc ]
> > > > > 
> > > > > ------------------------------------------------------------------------------
> > > > > Download Intel&#174; Parallel Studio Eval
> > > > > Try the new software tools for yourself. Speed compiling, find bugs
> > > > > proactively, and fine-tune applications for parallel performance.
> > > > > See why Intel Parallel Studio got high marks during beta.
> > > > > http://p.sf.net/sfu/intel-sw-dev
> > > > > _______________________________________________
> > > > > Ltp-list mailing list
> > > > > Ltp-list@lists.sourceforge.net
> > > > > https://lists.sourceforge.net/lists/listinfo/ltp-list
> > > > 
> > > > -- 
> > > > Thanks & Regards
> > > > Rishi
> > > > LTP Maintainer
> > > > IBM, LTC, Bangalore
> > > > Please join IRC #ltp @ irc.freenode.net
> > > 
> > > -- 
> > > Srinivasa R Chamarthy (schamart@linux.vnet.ibm.com)
> > > Linux on System z (RedHat & Novell SuSE) CSVT,
> > > IBM India Systems & Technology Group/LTC - ISL,
> > > Bangalore - 560071, KA, INDIA. Off: +91-80-41776451 
> > > [ http://www.ibm.com/in/isl | http://www.ibm.com/linux/ltc ]
> > > 
> > > ------------------------------------------------------------------------------
> > > Download Intel&#174; Parallel Studio Eval
> > > Try the new software tools for yourself. Speed compiling, find bugs
> > > proactively, and fine-tune applications for parallel performance.
> > > See why Intel Parallel Studio got high marks during beta.
> > > http://p.sf.net/sfu/intel-sw-dev
> > > _______________________________________________
> > > Ltp-list mailing list
> > > Ltp-list@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/ltp-list
> > 
> > -- 
> > Srinivasa R Chamarthy (schamart@linux.vnet.ibm.com)
> > Linux on System z (RedHat & Novell SuSE) CSVT,
> > IBM India Systems & Technology Group/LTC - ISL,
> > Bangalore - 560071, KA, INDIA. Off: +91-80-41776451 
> > [ http://www.ibm.com/in/isl | http://www.ibm.com/linux/ltc ]
> 
> -- 
> Srinivasa R Chamarthy (schamart@linux.vnet.ibm.com)
> Linux on System z (RedHat & Novell SuSE) CSVT,
> IBM India Systems & Technology Group/LTC - ISL,
> Bangalore - 560071, KA, INDIA. Off: +91-80-41776451 
> [ http://www.ibm.com/in/isl | http://www.ibm.com/linux/ltc ]
> 
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list

-- 
Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list