From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.124] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1O2IyP-0003VC-Fg for ltp-list@lists.sourceforge.net; Thu, 15 Apr 2010 06:54:49 +0000 Received: from e9.ny.us.ibm.com ([32.97.182.139]) by sfi-mx-4.v28.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1O2IyO-0002gt-Gj for ltp-list@lists.sourceforge.net; Thu, 15 Apr 2010 06:54:49 +0000 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e9.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o3F6gheL031668 for ; Thu, 15 Apr 2010 02:42:43 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o3F6sgPi065388 for ; Thu, 15 Apr 2010 02:54:43 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o3F6sgYE028600 for ; Thu, 15 Apr 2010 03:54:42 -0300 Date: Thu, 15 Apr 2010 12:24:41 +0530 From: Rishikesh K Rajak Message-ID: <20100415065440.GA6261@linux.vnet.ibm.com> References: <000001cadad6$c061c590$412550b0$@co.jp> <4BC487C9.9080300@xenotime.net> <000901cadb78$a2d05080$e870f180$@co.jp> <000601cadbb0$9fb8b5d0$df2a2170$@co.jp> <001301cadc36$77e08cf0$67a1a6d0$@co.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <001301cadc36$77e08cf0$67a1a6d0$@co.jp> Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ltp-list-bounces@lists.sourceforge.net To: Mitani Cc: ltp-list@lists.sourceforge.net, kamimura@ryobi.co.jp On Thu, Apr 15, 2010 at 09:56:22AM +0900, Mitani wrote: > = > > -----Original Message----- > > From: Garrett Cooper [mailto:yanegomi@gmail.com] > > Sent: Wednesday, April 14, 2010 6:31 PM > > To: Mitani > > Cc: ltp-list@lists.sourceforge.net > > Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests > > = > > On Wed, Apr 14, 2010 at 1:58 AM, Mitani wrote: > > >> -----Original Message----- > > >> From: Garrett Cooper [mailto:yanegomi@gmail.com] > > >> Sent: Wednesday, April 14, 2010 3:18 PM > > >> To: Mitani > > >> Cc: Randy Dunlap; ltp-list@lists.sourceforge.net > > >> Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests > > >> > > >> On Tue, Apr 13, 2010 at 7:17 PM, Mitani wrote: > > >> > Hi Randy, > > >> > > > >> > I couldn't notice a misspelling. Sorry. > > >> > I decided to use "due to" according to your advice. > > >> > > > >> > May I suggest revised patch? > > >> > > > > [...] > > >> > > > >> > Thank you-- > > >> > > > >> > -Tomonori Mitani > > >> > > > >> > > > >> >> -----Original Message----- > > >> >> From: Randy Dunlap [mailto:rdunlap@xenotime.net] > > >> >> Sent: Wednesday, April 14, 2010 12:04 AM > > >> >> To: Mitani > > >> >> Cc: ltp-list@lists.sourceforge.net > > >> >> Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests > > >> >> > > >> >> On 04/12/10 23:58, Mitani wrote: > > >> >> > ------------ > > >> >> > =A0a) All tests: > > >> >> > "TBROK =A0: =A0Test cannot be continued owning to sufficient > > >> >> availability of > > >> >> > Hugepages on the system" > > >> >> > > > >> >> > =A0b) 2), 3), 5), 6), 8), 10), 11) tests: > > >> >> > "TWARN =A0: =A0tst_rmdir(): TESTDIR was NULL; no removal > > attempted" > > >> >> > ------------ > > >> >> > > > >> >> > Both case a) and case b) are caused by the same reason. > > >> >> > > > >> >> > All of case a) failures occured at the following points (for > > >> example > > >> >> > hugemmap04): > > >> >> > ------------ > > >> >> > =A0 =A0 =A0 =A0 /* Check number of hugepages */ > > >> >> > =A0 =A0 =A0 =A0 if (get_no_of_hugepages() <=3D 0 || hugepages_s= ize() > > <=3D > > >> 0) > > >> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 tst_brkm(TBROK, cleanup, "Test = cannot be > > >> continued > > >> >> owning to > > >> >> > \ > > >> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= sufficient availability > > of > > >> >> Hugepages on the > > >> >> > system"); > > >> >> > ------------ > > >> >> > > > >> >> > I found out that "HugePages_Total" parameter of "/proc/meminfo" > > >> file > > >> >> > is set to "0". This caused above TBROK failure. It is environme= nt > > >> >> problem. > > >> >> > > > >> >> > But, in this case, tests must not return with TBROK, but with > > TCONF, > > >> >> > I think. > > >> >> > > >> >> That makes sense to me. > > >> >> > > >> >> > And, in case b), these tests try to delete "TESTDIR" directory > > >> by > > >> >> > calling "tst_rmdir()" function in "cleanup()" function. > > >> >> > But, "TESTDIR" never set if "tst_tmpdir()" function isn't > > called. > > >> >> > I think that case b)'s tests must not call cleanup() function. > > >> >> > > > >> >> > > > >> >> > I want to suggest following patch. > > >> >> > > > >> >> > Signed-off-by: Tomonori Mitani > > = > > Sorry to ask again, but Gmail always mangles patches. Could you > > please attach it as a file? > > Thanks, > > -Garrett > = > = > Sorry. > I attach a patch file. Applied to next branch. Will wait for someone to Acked/test it before mergi= ng to = master. Thanks -Rishi > = > = > Signed-off-by: Tomonori Mitani > = > = > Regards-- > = > -Tomonori Mitani > -------------------------------------------------------------------------= ----- > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list -- = Thanks & Regards Rishi LTP Maintainer IBM, LTC, Bangalore Please join IRC #ltp @ irc.freenode.net ---------------------------------------------------------------------------= --- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list