Re: [LTP] [PATCH] fix "hugetlb" several tests

Randy Dunlap
2010-04-13T15:03:55Z

On 04/12/10 23:58, Mitani wrote:
> ------------
> a) All tests:
> "TBROK : Test cannot be continued owning to sufficient availability of
> Hugepages on the system"
>
> b) 2), 3), 5), 6), 8), 10), 11) tests:
> "TWARN : tst_rmdir(): TESTDIR was NULL; no removal attempted"
> ------------
>
> Both case a) and case b) are caused by the same reason.
>
> All of case a) failures occured at the following points (for example
> hugemmap04):
> ------------<hugemmap04.c - main()>
> /* Check number of hugepages */
> if (get_no_of_hugepages() <= 0 || hugepages_size() <= 0)
> tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
> \
> sufficient availability of Hugepages on the
> system");
> ------------
>
> I found out that "HugePages_Total" parameter of "/proc/meminfo" file
> is set to "0". This caused above TBROK failure. It is environment problem.
>
> But, in this case, tests must not return with TBROK, but with TCONF,
> I think.

That makes sense to me.

> And, in case b), these tests try to delete "TESTDIR" directory by
> calling "tst_rmdir()" function in "cleanup()" function.
> But, "TESTDIR" never set if "tst_tmpdir()" function isn't called.
> I think that case b)'s tests must not call cleanup() function.
>
>
> I want to suggest following patch.
>
> Signed-off-by: Tomonori Mitani <mitani@ryobi.co.jp>
>
> ============
> --- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap04.c 2010-04-01
> 15:23:09.000000000 +0900
> +++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap04.c 2010-04-13
> 11:23:33.000000000 +0900
> @@ -127,7 +127,7 @@
>
> /* Check number of hugepages */
> if (get_no_of_hugepages() <= 0 || hugepages_size() <= 0)
> - tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
> \
> + tst_brkm(TCONF, cleanup, "Test cannot be continued owning to
> \
> sufficient availability of Hugepages on the
> system");
>
> /* Perform global setup for test */

Not caused by your patch, but all of those "owning to" should be "owing to"
or even better, "due to".

--
~Randy