* [LTP] [PATCH] linkat01: use . instead of /tmp
@ 2010-04-22 21:40 Bryan Freed
2010-04-22 23:38 ` Henry Yei
0 siblings, 1 reply; 3+ messages in thread
From: Bryan Freed @ 2010-04-22 21:40 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1.1: Type: text/plain, Size: 1607 bytes --]
I have a fix for a failing LTP testcase. Section 6 of the online LTP doc
http://ltp.sourceforge.net/documentation/how-to/ltp.php#_7 says I can
request a test be added by sending to this list, and it looks from the
archive like the subject line for patches should contain "[LTP][PATCH]", so
here goes. There appears to be no standard diff format, so I will use what
is convenient...
Running the ltp suite on ChromeOS (x86 with a 2.6.32 kernel) fails linkat01
testcase 21:
linkat01 21 TFAIL : linkat() failed: TEST_ERRNO=EXDEV(18): Invalid
cross-device link
This is probably because my /tmp is mounted from someplace other than the
filesystem that contains newdirfd.
The goal of testcase 21 is to demonstrate that linking a directory will fail
EPERM. The fix is to use olddir/. instead of /tmp.
diff -urN
ltp-full-20091231_vanilla/testcases/kernel/syscalls/linkat/linkat01.c
ltp-full-20091231/testcases/kernel/syscalls/linkat/linkat01.c
--- ltp-full-20091231_vanilla/testcases/kernel/syscalls/linkat/linkat01.c
2009-11-26 23:43:12.000000000 -0800
+++ ltp-full-20091231/testcases/kernel/syscalls/linkat/linkat01.c
2010-04-12 16:28:59.000000000 -0700
@@ -158,7 +158,7 @@
{ &cwd_fd, "/proc/cpuinfo", &newdirfd, TEST_FILE1, 0,
0, 0, EXDEV },
/* 21. directory link */
- { &cwd_fd, "/tmp", &newdirfd, TEST_FILE1, 0,
+ { &olddirfd, ".", &newdirfd, TEST_FILE1, 0,
0, 0, EPERM },
/* 22. invalid flag */
{ &olddirfd, TEST_FILE1, &newdirfd, TEST_FILE1, 1,
Let me know if this is the incorrect process for upstreaming LTP patches.
bryan.
[-- Attachment #1.2: Type: text/html, Size: 2109 bytes --]
[-- Attachment #2: Type: text/plain, Size: 79 bytes --]
------------------------------------------------------------------------------
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] linkat01: use . instead of /tmp
2010-04-22 21:40 [LTP] [PATCH] linkat01: use . instead of /tmp Bryan Freed
@ 2010-04-22 23:38 ` Henry Yei
2010-04-23 7:08 ` Rishikesh K Rajak
0 siblings, 1 reply; 3+ messages in thread
From: Henry Yei @ 2010-04-22 23:38 UTC (permalink / raw)
To: Bryan Freed; +Cc: ltp-list
Bryan, I've confirmed that the linkat01 test passes with this fix on
x86 with 2.6.21 kernel and arm on 2.6.33 kernel. Thanks!
Henry Yei <hyei@mvista.com>
On Thu, Apr 22, 2010 at 2:40 PM, Bryan Freed <bfreed@google.com> wrote:
> I have a fix for a failing LTP testcase. Section 6 of the online LTP doc
> http://ltp.sourceforge.net/documentation/how-to/ltp.php#_7 says I can
> request a test be added by sending to this list, and it looks from the
> archive like the subject line for patches should contain "[LTP][PATCH]", so
> here goes. There appears to be no standard diff format, so I will use what
> is convenient...
> Running the ltp suite on ChromeOS (x86 with a 2.6.32 kernel) fails linkat01
> testcase 21:
>
> linkat01 21 TFAIL : linkat() failed: TEST_ERRNO=EXDEV(18): Invalid
> cross-device link
> This is probably because my /tmp is mounted from someplace other than the
> filesystem that contains newdirfd.
> The goal of testcase 21 is to demonstrate that linking a directory will fail
> EPERM. The fix is to use olddir/. instead of /tmp.
> diff -urN
> ltp-full-20091231_vanilla/testcases/kernel/syscalls/linkat/linkat01.c
> ltp-full-20091231/testcases/kernel/syscalls/linkat/linkat01.c
> --- ltp-full-20091231_vanilla/testcases/kernel/syscalls/linkat/linkat01.c
> 2009-11-26 23:43:12.000000000 -0800
> +++ ltp-full-20091231/testcases/kernel/syscalls/linkat/linkat01.c
> 2010-04-12 16:28:59.000000000 -0700
> @@ -158,7 +158,7 @@
> { &cwd_fd, "/proc/cpuinfo", &newdirfd, TEST_FILE1, 0,
> 0, 0, EXDEV },
> /* 21. directory link */
> - { &cwd_fd, "/tmp", &newdirfd, TEST_FILE1, 0,
> + { &olddirfd, ".", &newdirfd, TEST_FILE1, 0,
> 0, 0, EPERM },
> /* 22. invalid flag */
> { &olddirfd, TEST_FILE1, &newdirfd, TEST_FILE1, 1,
>
> Let me know if this is the incorrect process for upstreaming LTP patches.
> bryan.
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] linkat01: use . instead of /tmp
2010-04-22 23:38 ` Henry Yei
@ 2010-04-23 7:08 ` Rishikesh K Rajak
0 siblings, 0 replies; 3+ messages in thread
From: Rishikesh K Rajak @ 2010-04-23 7:08 UTC (permalink / raw)
To: Henry Yei, Bryan Freed; +Cc: ltp-list
On Thu, Apr 22, 2010 at 04:38:12PM -0700, Henry Yei wrote:
> Bryan, I've confirmed that the linkat01 test passes with this fix on
> x86 with 2.6.21 kernel and arm on 2.6.33 kernel. Thanks!
>
> Henry Yei <hyei@mvista.com>
Thanks Bryan & Henry.
Merged into tree.
23e7806fec4c6be42fdf577559df5498cce45118
-Rishi
>
> On Thu, Apr 22, 2010 at 2:40 PM, Bryan Freed <bfreed@google.com> wrote:
> > I have a fix for a failing LTP testcase. Section 6 of the online LTP doc
> > http://ltp.sourceforge.net/documentation/how-to/ltp.php#_7 says I can
> > request a test be added by sending to this list, and it looks from the
> > archive like the subject line for patches should contain "[LTP][PATCH]", so
> > here goes. There appears to be no standard diff format, so I will use what
> > is convenient...
> > Running the ltp suite on ChromeOS (x86 with a 2.6.32 kernel) fails linkat01
> > testcase 21:
> >
> > linkat01 21 TFAIL : linkat() failed: TEST_ERRNO=EXDEV(18): Invalid
> > cross-device link
> > This is probably because my /tmp is mounted from someplace other than the
> > filesystem that contains newdirfd.
> > The goal of testcase 21 is to demonstrate that linking a directory will fail
> > EPERM. The fix is to use olddir/. instead of /tmp.
> > diff -urN
> > ltp-full-20091231_vanilla/testcases/kernel/syscalls/linkat/linkat01.c
> > ltp-full-20091231/testcases/kernel/syscalls/linkat/linkat01.c
> > --- ltp-full-20091231_vanilla/testcases/kernel/syscalls/linkat/linkat01.c
> > 2009-11-26 23:43:12.000000000 -0800
> > +++ ltp-full-20091231/testcases/kernel/syscalls/linkat/linkat01.c
> > 2010-04-12 16:28:59.000000000 -0700
> > @@ -158,7 +158,7 @@
> > { &cwd_fd, "/proc/cpuinfo", &newdirfd, TEST_FILE1, 0,
> > 0, 0, EXDEV },
> > /* 21. directory link */
> > - { &cwd_fd, "/tmp", &newdirfd, TEST_FILE1, 0,
> > + { &olddirfd, ".", &newdirfd, TEST_FILE1, 0,
> > 0, 0, EPERM },
> > /* 22. invalid flag */
> > { &olddirfd, TEST_FILE1, &newdirfd, TEST_FILE1, 1,
> >
> > Let me know if this is the incorrect process for upstreaming LTP patches.
> > bryan.
> > ------------------------------------------------------------------------------
> >
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp-list@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
> >
> >
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
--
Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-23 7:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-22 21:40 [LTP] [PATCH] linkat01: use . instead of /tmp Bryan Freed
2010-04-22 23:38 ` Henry Yei
2010-04-23 7:08 ` Rishikesh K Rajak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox