From: Hannu Heikkinen <hannuxx@iki.fi>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ext Mitani <mitani@ryobi.co.jp>,
"ltp-list@lists.sourceforge.net" <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] POSIX "sched_yield/1-1.c" build failed
Date: Wed, 15 Sep 2010 21:20:52 +0300 [thread overview]
Message-ID: <20100915182052.GA2750@hannu-ubuntu> (raw)
In-Reply-To: <AANLkTikYz9ppRN1FZBSnpyePoMV79GDWNA4umS7NLUn_@mail.gmail.com>
On 15/09/10 09:18 -0700, Garrett Cooper wrote:
> That seems like a reasonable thing to do, but here's an alternative
> way to do this (less variables):
>
> --- a/testcases/open_posix_testsuite/include/posixtest.h
> +++ b/testcases/open_posix_testsuite/include/posixtest.h
> @@ -10,10 +10,24 @@
> * return codes
> */
>
> +/*
> + * Define PTS_DEVELOPER_MODE if you want to compile for developer scenarios,
> + * including reporting errors (as opposed to warnings), when compiling some
> + * test programs.
> + */
> +
> #if defined(_GNU_SOURCE)
> +#if defined(PTS_DEVELOPER_MODE)
> #error "Contains GNU-isms that need fixing."
> +#else
> +#warning "Contains GNU-isms that need fixing."
> +#endif
> #elif defined(_BSD_SOURCE)
> +#if defined(PTS_DEVELOPER_MODE)
> #error "Contains BSD-isms that need fixing."
> +#else
> +#warning "Contains BSD-isms that need fixing."
> +#endif
> #endif
>
> #define PTS_PASS 0
>
> Thanks for the idea Hannu :),
> -Garrett
>
Ok, even better, less is always good! Developer mode sounds good.
Should this posixtest.h be kind of a must include for all test cases?
Currently not all cases include this.
br,
Hannu
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2010-09-15 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 4:39 [LTP] POSIX "sched_yield/1-1.c" build failed Mitani
2010-09-15 13:43 ` Hannu Heikkinen
2010-09-15 16:18 ` Garrett Cooper
2010-09-15 18:20 ` Hannu Heikkinen [this message]
2010-09-15 19:01 ` Garrett Cooper
2010-09-16 19:00 ` Hannu Heikkinen
2010-09-16 19:12 ` Garrett Cooper
2010-09-17 16:47 ` Hannu Heikkinen
2010-09-21 4:39 ` Mitani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915182052.GA2750@hannu-ubuntu \
--to=hannuxx@iki.fi \
--cc=ltp-list@lists.sourceforge.net \
--cc=mitani@ryobi.co.jp \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox