Re: [LTP] [PATCH v5] mmap/munmap /dev/zero

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 890 bytes --]

On Wednesday, October 13, 2010 08:51:27 CAI Qian wrote:
> mmap/munmap /dev/zero: a common way of malloc()/free() anonymous memory
> on Solaris.

what Garrett meant is that this is the subject, not the second line of the 
changelog.  are you actually using git here, or just fudging the details and 
hoping people wont notice ?  your e-mails are not directly usable by git which 
means if we want to apply your patch, we need to screw around with it first.  
please fix your git flow.

> +option_t options[] = {

needs at least static, and be nice if it were const too

> +	while (waitpid(-1, NULL, WNOHANG) > 0);

shouldnt you be checking the exit status of the children ?  otherwise, a 
tst_brkm() call by them wont be noticed.  and why are you using WNOHANG ?  if 
the parent happens to hit this point before some children exit, you basically 
ignore them too.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 369 bytes --]

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list