Re: [LTP] smack testcase

["Serge E. Hallyn" <serge.hallyn@canonical.com>]

Quoting ARJIT SHARMA (joyarjit@gmail.com):
> Hi,
> 
>      Inside the smack testcase, the sript "smack_common.sh" has a function
> named "check_onlycap()" , please tell me its functionality  as every time
> this function is reporting that   onlycap is "" not the expected "".
> 
> the log of the testcase is as follows---

Yeah the check seems backward.  Does this patch help?

From efe6116a6b284bb409b7fe9946cf990092183650 Mon Sep 17 00:00:00 2001
From: Serge Hallyn <serge.hallyn@canonical.com>
Date: Wed, 20 Oct 2010 07:54:21 -0500
Subject: [PATCH 1/1] Fix inverted logic testing for string which is NOT empty

Signed-off-by: Serge Hallyn <serge.hallyn@canonical.com>
---
 testcases/kernel/security/smack/smack_common.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/security/smack/smack_common.sh b/testcases/kernel/security/smack/smack_common.sh
index eb339f3..25405fe 100755
--- a/testcases/kernel/security/smack/smack_common.sh
+++ b/testcases/kernel/security/smack/smack_common.sh
@@ -36,7 +36,7 @@ check_mounted() {
 
 check_onlycap() {
 	onlycap=`cat "$smackfsdir/onlycap" 2>/dev/null`
-	if [ -z "$onlycap" ]; then
+	if [ ! -z "$onlycap" ]; then
 		cat <<EOM
 The smack label reported for $smackfsdir/onlycap is "$onlycap", not the expected "".
 EOM
-- 
1.7.1


------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly 
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list