From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1PBKom-0003xv-Ly for ltp-list@lists.sourceforge.net; Thu, 28 Oct 2010 05:14:28 +0000 Received: from e1.ny.us.ibm.com ([32.97.182.141]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1PBKok-0006os-EH for ltp-list@lists.sourceforge.net; Thu, 28 Oct 2010 05:14:28 +0000 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e1.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o9S56wQr024977 for ; Thu, 28 Oct 2010 01:06:58 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o9S5EKNl369868 for ; Thu, 28 Oct 2010 01:14:20 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o9S5EKm5007424 for ; Thu, 28 Oct 2010 01:14:20 -0400 Date: Wed, 27 Oct 2010 22:22:03 -0700 From: Sukadev Bhattiprolu Message-ID: <20101028052203.GA28332@us.ibm.com> References: <20100804235206.GA1388@us.ibm.com> <20100805014358.GA14122@us.ibm.com> <1281970341.5120.18.camel@subratamodak.linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [LTP] pidns31: fix EACCESS error in mq_open() List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ltp-list-bounces@lists.sourceforge.net To: Garrett Cooper Cc: ltp-list@lists.sourceforge.net Garrett Cooper [yanegomi@gmail.com] wrote: | On Mon, Aug 16, 2010 at 7:52 AM, Subrata Modak | wrote: | > | > On Wed, 2010-08-04 at 18:43 -0700, Sukadev Bhattiprolu wrote: | >> Garrett Cooper [yanegomi@gmail.com] wrote: | >> | On Wed, Aug 4, 2010 at 4:52 PM, Sukadev Bhattiprolu | >> | wrote: | >> | > | >> | > pidns31: mq_open() fails with EACCESS. | >> | > | >> | > pidns31 test case fails with EACCESS - due to the leading '/' in | >> | > mqname. See comments in the patch below for details. | >> | > | >> | > Signed-off-by: Sukadev Bhattiprolu | >> | > --- | >> | > Index: testcases/kernel/containers/pidns/pidns31.c | >> | > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D | >> | > RCS file: /cvsroot/ltp/ltp/testcases/kernel/containers/pidns/pidns= 31.c,v | >> | > retrieving revision 1.6 | >> | > diff -u -p -r1.6 pidns31.c | >> | > --- testcases/kernel/containers/pidns/pidns31.c 14 Nov 2009 23:58:= 26 -0000 =A0 =A0 =A01.6 | >> | > +++ testcases/kernel/containers/pidns/pidns31.c 4 Aug 2010 23:24:5= 4 -0000 | >> | > @@ -61,7 +61,14 @@ | >> | > =A0char *TCID =3D "pidns31"; | >> | > =A0int TST_TOTAL =3D 1; | >> | > | >> | > -char *mqname =3D "/mq1"; | >> | > + | >> | > +/* | >> | > + * NOTE: The mq_open() interface in glibc requires mqname to star= t with a '/' | >> | > + * =A0 =A0 =A0and the glibc call skips the leading '/' when invok= ing the system | >> | > + * =A0 =A0 =A0call. Since we bypass the glibc mq_open() (and use = syscall()) we | >> | > + * =A0 =A0 =A0define mqname without the leading '/'. | >> | > + */ | >> | > +char *mqname =3D "mq1"; | >> | > =A0int result =3D TFAIL; | >> | > | >> | > =A0int errno; | >> | > @@ -264,6 +271,7 @@ int main(int argc, char *argv[]) | >> | > =A0 =A0 =A0 =A0} | >> | > | >> | > =A0 =A0 =A0 =A0syscall(__NR_mq_unlink, mqname); | >> | > + | >> | > =A0 =A0 =A0 =A0mqd =3D syscall(__NR_mq_open, mqname, O_RDWR|O_CREA= T|O_EXCL, 0777, NULL); | >> | > =A0 =A0 =A0 =A0if (mqd =3D=3D (mqd_t)-1) { | >> | > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0tst_resm(TBROK, "parent: mq_open() = failed (%s)", | >> | | >> | Did Linux become non-POSIX compliant :) (from | >> | )? | >> | >> Heh. Good question but I think the mq_open() from glibc is compliant | >> with this. I am just not sure if the call via syscall() needs to be | >> compliant. | >> | >> But if that is a concern, we need a separate a test case for that - | >> pidns31 is using mq_* to test an unrelated feature. I think would | >> make sense to apply this fix, allowing LTP to test the feature even | >> on older distros. | >> | >> Or pidns31 can go back to using the library interface and we could | >> skip the test on old distros. | > | > I would prefer this. | = | Do I hear someone volunteering to add the required autoconf tests and | tests for this :)? Well, I thought we could add a simple autoconf test for the pidns - but then realized that mq_open() calls were changed for many other test cases too. The test cases include mqueue.h, which would not be present in old distros anyway. So, I don't see the point in fixing this just for pidns tests. If we want = to use the syscall() interface, why don't we just design the test to work = with the syscall behavior - i.e just remove the '/' from the name ? Sukadev ---------------------------------------------------------------------------= --- Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store = http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list