[LTP] enable pwrite for 64 bits test

[LTP] enable pwrite for 64 bits test

[Vivi]

[-- Attachment #1.1: Type: text/plain, Size: 590 bytes --]

Enable ltp test of pwrite for 64 bit test.

Bellow is the patch:
--
Index: testcases/kernel/syscalls/pwrite/Makefile
===================================================================
--- testcases/kernel/syscalls/pwrite/Makefile   (revision 161)
+++ testcases/kernel/syscalls/pwrite/Makefile   (revision 183)
@@ -19,5 +19,8 @@
 top_srcdir             ?= ../../../..

 include $(top_srcdir)/include/mk/testcases.mk
+include $(abs_srcdir)/../utils/newer_64.mk

+%_64: CPPFLAGS += -D_FILE_OFFSET_BITS=64
+
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
--



Best regards,
Vivi Li

[-- Attachment #1.2: Type: text/html, Size: 824 bytes --]

[-- Attachment #2: Type: text/plain, Size: 371 bytes --]

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] enable pwrite for 64 bits test

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 244 bytes --]

On Wednesday, December 29, 2010 04:35:45 Vivi wrote:
> Enable ltp test of pwrite for 64 bit test.

this patch is fine ... but i had to merge it by hand since your e-mailer is 
sending both html and plain text.  please disable that.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 371 bytes --]

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] enable pwrite for 64 bits test

[Garrett Cooper]

[-- Attachment #1.1: Type: text/plain, Size: 1353 bytes --]

This didn't add the runtest entire though.

Sent from my iPhone

On Dec 29, 2010, at 1:35 AM, Vivi <violetleigh@gmail.com> wrote:

> Enable ltp test of pwrite for 64 bit test.
> 
> Bellow is the patch:
> --
> Index: testcases/kernel/syscalls/pwrite/Makefile
> ===================================================================
> --- testcases/kernel/syscalls/pwrite/Makefile   (revision 161)
> +++ testcases/kernel/syscalls/pwrite/Makefile   (revision 183)
> @@ -19,5 +19,8 @@
>  top_srcdir             ?= ../../../..
> 
>  include $(top_srcdir)/include/mk/testcases.mk
> +include $(abs_srcdir)/../utils/newer_64.mk
> 
> +%_64: CPPFLAGS += -D_FILE_OFFSET_BITS=64
> +
>  include $(top_srcdir)/include/mk/generic_leaf_target.mk
> --
> 
> 
> 
> Best regards,
> Vivi Li
> ------------------------------------------------------------------------------
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment, and, 
> should the need arise, upgrade to a full multi-node Oracle RAC database 
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list

[-- Attachment #1.2: Type: text/html, Size: 2181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 371 bytes --]

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] enable pwrite for 64 bits test

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 257 bytes --]

On Wednesday, December 29, 2010 17:10:42 Garrett Cooper wrote:
> This didn't add the runtest entire though.

what are you referring to exactly ?  the changes to pwrite's Makefile look 
like all that's needed as compared to say pselect/Makefile.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 371 bytes --]

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] enable pwrite for 64 bits test

[Garrett Cooper]

Grep for pwrite under the runtest dir in the got repo.

Sent from my iPhone

On Dec 29, 2010, at 2:47 PM, Mike Frysinger <vapier@gentoo.org> wrote:

> On Wednesday, December 29, 2010 17:10:42 Garrett Cooper wrote:
>> This didn't add the runtest entire though.
> 
> what are you referring to exactly ?  the changes to pwrite's Makefile look 
> like all that's needed as compared to say pselect/Makefile.
> -mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] enable pwrite for 64 bits test

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 533 bytes --]

On Wednesday, December 29, 2010 18:26:53 Garrett Cooper wrote:
> Grep for pwrite under the runtest dir in the got repo.

personally, i never use runtest.  i dont believe our testers do either.  i'm 
not sure what the current position is wrt to, but i dont think we should 
require people working in the syscalls tree to update random runtest lists 
whenever they add new tests.

if there is a runtest that says "run all syscall tests", then that sounds like 
a list that should be autogenerated by the build system.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 371 bytes --]

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] enable pwrite for 64 bits test

[Garrett Cooper]

In general I agree (and fwiw I think that the .gitignore files should be treated the same way), but the scenario files sometimes include some kind of setup preamble and a series of arguments fed into an app or script via pan.

I'm positive that folks in my old group at cisco don't execute the test apps manually unless they're trying to repro issues, and even then I questioned the competence of some devs executing ltp apps standalone.

Sent from my iPhone

On Dec 29, 2010, at 3:44 PM, Mike Frysinger <vapier@gentoo.org> wrote:

> On Wednesday, December 29, 2010 18:26:53 Garrett Cooper wrote:
>> Grep for pwrite under the runtest dir in the got repo.
> 
> personally, i never use runtest.  i dont believe our testers do either.  i'm 
> not sure what the current position is wrt to, but i dont think we should 
> require people working in the syscalls tree to update random runtest lists 
> whenever they add new tests.
> 
> if there is a runtest that says "run all syscall tests", then that sounds like 
> a list that should be autogenerated by the build system.
> -mike

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] enable pwrite for 64 bits test

[Cyril Hrubis]

Hi!
> personally, i never use runtest.  i dont believe our testers do either.  i'm 
> not sure what the current position is wrt to, but i dont think we should 
> require people working in the syscalls tree to update random runtest lists 
> whenever they add new tests.

The runtest files are used to generate automatic test runs at least here
in suse.

> if there is a runtest that says "run all syscall tests", then that sounds like 
> a list that should be autogenerated by the build system.

Tried that, the problem is that quite number of the tests are same
binary just with different parameters. So just now there is a need for
runtest files.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] enable pwrite for 64 bits test

[Garrett Cooper]

On Wed, Dec 29, 2010 at 1:35 AM, Vivi <violetleigh@gmail.com> wrote:
> Enable ltp test of pwrite for 64 bit test.
>
> Bellow is the patch:
> --
> Index: testcases/kernel/syscalls/pwrite/Makefile
> ===================================================================
> --- testcases/kernel/syscalls/pwrite/Makefile   (revision 161)
> +++ testcases/kernel/syscalls/pwrite/Makefile   (revision 183)
> @@ -19,5 +19,8 @@
>  top_srcdir             ?= ../../../..
>
>  include $(top_srcdir)/include/mk/testcases.mk
> +include $(abs_srcdir)/../utils/newer_64.mk
>
> +%_64: CPPFLAGS += -D_FILE_OFFSET_BITS=64
> +
>  include $(top_srcdir)/include/mk/generic_leaf_target.mk

I applied your patch, but there are a lot of warnings w.r.t. 64-bit
compilation that need fixing now. Please provide another patch to fix
that.
Thanks,
-Garrett

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list