From: Mike Frysinger <vapier@gentoo.org>
To: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] Fix a building error.
Date: Fri, 14 Jan 2011 16:24:58 -0500 [thread overview]
Message-ID: <201101141624.59736.vapier@gentoo.org> (raw)
In-Reply-To: <4D301BF1.8070101@cn.fujitsu.com>
[-- Attachment #1.1: Type: Text/Plain, Size: 564 bytes --]
On Friday, January 14, 2011 04:48:33 Peng Haitao wrote:
> testcases/kernel/syscalls/mallopt/mallopt01.c | 1 +
please use descriptive subjects in your patches. this really should be
something like:
mallopt01: fix build error due to xxxx
> --- a/testcases/kernel/syscalls/mallopt/mallopt01.c
> +++ b/testcases/kernel/syscalls/mallopt/mallopt01.c
> @@ -37,6 +37,7 @@
> #ifdef CONFIG_COLDFIRE
> #define __MALLOC_STANDARD__
> #endif
> +#include <malloc.h>
umm, no. malloc.h is a dead header file and nothing should be including it.
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 372 bytes --]
------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2011-01-14 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 9:48 [LTP] [PATCH] Fix a building error Peng Haitao
2011-01-14 12:58 ` Cyril Hrubis
2011-01-14 21:24 ` Mike Frysinger [this message]
2011-01-14 21:33 ` Garrett Cooper
2011-01-14 21:46 ` Mike Frysinger
2011-01-14 21:52 ` Garrett Cooper
2011-01-14 22:12 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2011-01-14 9:31 Peng Haitao
2011-01-28 8:24 ` Peng Haitao
2011-02-14 9:45 ` Peng Haitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101141624.59736.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox