Re: [LTP] [PATCH] Fix a building error.

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 2124 bytes --]

On Friday, January 14, 2011 16:52:15 Garrett Cooper wrote:
> On Fri, Jan 14, 2011 at 1:46 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Friday, January 14, 2011 16:33:38 Garrett Cooper wrote:
> >> On Fri, Jan 14, 2011 at 1:24 PM, Mike Frysinger wrote:
> >> > On Friday, January 14, 2011 04:48:33 Peng Haitao wrote:
> >> >>  testcases/kernel/syscalls/mallopt/mallopt01.c |    1 +
> >> > 
> >> > please use descriptive subjects in your patches.  this really should
> >> > be something like:
> >> >        mallopt01: fix build error due to xxxx
> >> > 
> >> >> --- a/testcases/kernel/syscalls/mallopt/mallopt01.c
> >> >> +++ b/testcases/kernel/syscalls/mallopt/mallopt01.c
> >> >> @@ -37,6 +37,7 @@
> >> >>  #ifdef CONFIG_COLDFIRE
> >> >>  #define __MALLOC_STANDARD__
> >> >>  #endif
> >> >> +#include <malloc.h>
> >> > 
> >> > umm, no.  malloc.h is a dead header file and nothing should be
> >> > including it.
> >> 
> >>     It is exposing extra junk in this case that isn't available from
> >> stdlib.h, which unfortunately the test uses. I fixed the build error
> >> for now, but maybe someone upstream should be informed that this
> >> header needs to die a painful death, because all contemporary
> >> documentation says that you need to include stdlib.h, not malloc.h
> >> when working with malloc(3). I was reminded of this recently because I
> >> built some stuff on FreeBSD and FreeBSD has a nice #warning about this
> >> deprecation.
> > 
> > err, right.  we're using mallopt() here and not malloc().  the former is
> > not part of POSIX which means it should not be in stdlib.h.  i dont
> > believe it is being deprecated on the GNU side, so we dont want to go
> > killing off the tests.
> 
> Should these tests live with glibc then and not ltp?

not really.  you might be able to get glibc to accept these, but you'll most 
likely need to rewrite them considerably.  plus, other C library 
implementations also support mallopt, not just glibc.  while it isnt part of 
POSIX, i do believe it is part of older standards.  glibc seems to quote 
SVID/XPG/ANSI.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 372 bytes --]

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list