From: Mike Frysinger <vapier@gentoo.org>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [Bug Fix] Skip first case in adjtimex02 test by a safer method
Date: Sat, 15 Jan 2011 20:21:28 -0500 [thread overview]
Message-ID: <201101152021.29499.vapier@gentoo.org> (raw)
In-Reply-To: <AANLkTi=sSsbYn4HKxNLegDqY49POL1Qt287uDK_=MMOT@mail.gmail.com>
[-- Attachment #1.1: Type: Text/Plain, Size: 1977 bytes --]
On Saturday, January 15, 2011 00:34:23 Garrett Cooper wrote:
> On Wed, Dec 29, 2010 at 8:35 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Wednesday, December 29, 2010 04:35:29 Vivi wrote:
> >> --- testcases/kernel/syscalls/adjtimex/adjtimex02.c
> >> +++ testcases/kernel/syscalls/adjtimex/adjtimex02.c
> >> @@ -122,12 +122,7 @@
> >> void (*cleanup) ();
> >> int exp_errno;
> >> } test_cases[] = {
> >> -#ifndef UCLINUX
> >> - /* Skip since uClinux does not implement memory protection */
> >> - {
> >> - (struct timex *)-1, NULL, NULL, EFAULT},
> >> -#endif
> >> - {
> >> + { (struct timex *)-1, NULL, NULL, EFAULT},{
> >> &buff, setup2, NULL, EINVAL}, {
> >> &buff, setup3, NULL, EINVAL}, {
> >> &buff, setup4, NULL, EINVAL}, {
> >> @@ -159,7 +154,18 @@
> >> Tst_count = 0;
> >>
> >> for (i = 0; i < TST_TOTAL; ++i) {
> >> +#ifdef UCLINUX
> >> /*
> >> + * Skip first case since uClinux does not
> >> implement + * memory protection.
> >> + */
> >> + if (i == 0) {
> >> + tst_resm(TCONF, "uClinux does not
> >> implement" + " memory
> >> protection."); + continue;
> >> + }
> >> +#endif
> >
> > we should be able to handle bad pointers like -1 and NULL. the kernel's
> > check access func should force EFAULT. so why do we need this new if
> > code ?
>
> If so, then there's a lot of code in LTP that needs to be fixed.
NOMMU can handle a few "magic" bad pointers like -1 and NULL, but only in so
much where the kernel is given the pointer via a syscall. in the past, this
wasnt the case, so i imagine a lot of checks have slipped in that can be
backed out.
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 372 bytes --]
------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2011-01-16 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 9:35 [LTP] [Bug Fix] Skip first case in adjtimex02 test by a safer method Vivi
2010-12-29 16:35 ` Mike Frysinger
2011-01-15 5:34 ` Garrett Cooper
2011-01-16 1:21 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101152021.29499.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox