From: Han Pingtian <phan@redhat.com>
To: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results
Date: Mon, 14 Feb 2011 14:14:10 +0800 [thread overview]
Message-ID: <20110214061409.GA7983@hpt.nay.redhat.com> (raw)
The KSM developer tell us that we should wait 3~5 increments of the
/sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results.
Otherwise, there may be some stuck pages that cause the testing failed.
Signed-off-by: Han Pingtian <phan@redhat.com>
---
testcases/kernel/mem/lib/mem.c | 27 +++++++++++++++++++++++++--
1 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c
index 1a53359..98cca12 100644
--- a/testcases/kernel/mem/lib/mem.c
+++ b/testcases/kernel/mem/lib/mem.c
@@ -298,8 +298,31 @@ void group_check(int run, int pages_shared, int pages_sharing,
int pages_volatile, int pages_unshared,
int sleep_millisecs, int pages_to_scan)
{
- /* 5 seconds for ksm to scan pages. */
- sleep(5);
+ int fd;
+ char buf[BUFSIZ];
+ int old_num, new_num;
+
+ fd = open("/sys/kernel/mm/ksm/full_scans", O_RDONLY);
+ if (fd < 0)
+ tst_brkm(TBROK|TERRNO, cleanup, "open");
+
+ /* 1 seconds for ksm to scan pages. */
+ sleep(1);
+
+ /* wait 3 increments of full_scans */
+ if (read(fd, buf, BUFSIZ) < 0)
+ tst_brkm(TBROK|TERRNO, cleanup, "read");
+ old_num = new_num = atoi(buf);
+ lseek(fd, 0, SEEK_SET);
+ while (new_num < old_num * 3) {
+ sleep(1);
+ if (read(fd, buf, BUFSIZ) < 0)
+ tst_brkm(TBROK|TERRNO, cleanup, "read");
+ new_num = atoi(buf);
+ lseek(fd, 0, SEEK_SET);
+ }
+ close(fd);
+
tst_resm(TINFO, "check!");
check("run", run);
check("pages_shared", pages_shared);
--
1.7.1
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2011-02-14 6:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 6:14 Han Pingtian [this message]
2011-02-14 6:25 ` [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results Garrett Cooper
2011-02-15 3:13 ` Han Pingtian
2011-02-15 14:37 ` Garrett Cooper
2011-02-16 2:59 ` Han Pingtian
2011-02-21 5:43 ` Han Pingtian
2011-02-23 8:46 ` Garrett Cooper
2011-02-23 10:12 ` Han Pingtian
2011-02-24 5:33 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214061409.GA7983@hpt.nay.redhat.com \
--to=phan@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox