From: Han Pingtian <phan@redhat.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results
Date: Tue, 15 Feb 2011 11:13:34 +0800 [thread overview]
Message-ID: <20110215031334.GA2884@hpt.nay.redhat.com> (raw)
In-Reply-To: <AANLkTimzLhCfwAgHuB4S3Fo=gHkHEKbjs6ObficnqKXU@mail.gmail.com>
On Sun, Feb 13, 2011 at 10:25:54PM -0800, Garrett Cooper wrote:
> On Sun, Feb 13, 2011 at 10:14 PM, Han Pingtian <phan@redhat.com> wrote:
> > The KSM developer tell us that we should wait 3~5 increments of the
> > /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results.
> > Otherwise, there may be some stuck pages that cause the testing failed.
>
> A common mistake is thinking that sleep(3) is non-interruptable.
> This proposed patch also has style-violations and is missing error
> checking around lseek, et all. Please fix these items according to the
> style guide.
> Thanks,
> -Garrett
Thanks reviewing. The patched function will be called by
testcases/kernel/mem/ksm/ksm* , which all call tst_sig() in setup().
So I think we have processed the interruptable problem of sleep().
I'll submit new patch.
>
> ------------------------------------------------------------------------------
> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
> Pinpoint memory and threading errors before they happen.
> Find and fix more than 250 security defects in the development cycle.
> Locate bottlenecks in serial and parallel code that limit performance.
> http://p.sf.net/sfu/intel-dev2devfeb
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
--
Han Pingtian
Quality Engineer
hpt @ #kernel-qe
Red Hat, Inc
Freedom ... courage ... Commitment ... ACCOUNTABILITY
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2011-02-15 3:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 6:14 [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results Han Pingtian
2011-02-14 6:25 ` Garrett Cooper
2011-02-15 3:13 ` Han Pingtian [this message]
2011-02-15 14:37 ` Garrett Cooper
2011-02-16 2:59 ` Han Pingtian
2011-02-21 5:43 ` Han Pingtian
2011-02-23 8:46 ` Garrett Cooper
2011-02-23 10:12 ` Han Pingtian
2011-02-24 5:33 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110215031334.GA2884@hpt.nay.redhat.com \
--to=phan@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox