* [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results @ 2011-02-14 6:14 Han Pingtian 2011-02-14 6:25 ` Garrett Cooper 0 siblings, 1 reply; 9+ messages in thread From: Han Pingtian @ 2011-02-14 6:14 UTC (permalink / raw) To: ltp-list The KSM developer tell us that we should wait 3~5 increments of the /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results. Otherwise, there may be some stuck pages that cause the testing failed. Signed-off-by: Han Pingtian <phan@redhat.com> --- testcases/kernel/mem/lib/mem.c | 27 +++++++++++++++++++++++++-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c index 1a53359..98cca12 100644 --- a/testcases/kernel/mem/lib/mem.c +++ b/testcases/kernel/mem/lib/mem.c @@ -298,8 +298,31 @@ void group_check(int run, int pages_shared, int pages_sharing, int pages_volatile, int pages_unshared, int sleep_millisecs, int pages_to_scan) { - /* 5 seconds for ksm to scan pages. */ - sleep(5); + int fd; + char buf[BUFSIZ]; + int old_num, new_num; + + fd = open("/sys/kernel/mm/ksm/full_scans", O_RDONLY); + if (fd < 0) + tst_brkm(TBROK|TERRNO, cleanup, "open"); + + /* 1 seconds for ksm to scan pages. */ + sleep(1); + + /* wait 3 increments of full_scans */ + if (read(fd, buf, BUFSIZ) < 0) + tst_brkm(TBROK|TERRNO, cleanup, "read"); + old_num = new_num = atoi(buf); + lseek(fd, 0, SEEK_SET); + while (new_num < old_num * 3) { + sleep(1); + if (read(fd, buf, BUFSIZ) < 0) + tst_brkm(TBROK|TERRNO, cleanup, "read"); + new_num = atoi(buf); + lseek(fd, 0, SEEK_SET); + } + close(fd); + tst_resm(TINFO, "check!"); check("run", run); check("pages_shared", pages_shared); -- 1.7.1 ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results 2011-02-14 6:14 [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results Han Pingtian @ 2011-02-14 6:25 ` Garrett Cooper 2011-02-15 3:13 ` Han Pingtian 0 siblings, 1 reply; 9+ messages in thread From: Garrett Cooper @ 2011-02-14 6:25 UTC (permalink / raw) To: ltp-list, caiqian On Sun, Feb 13, 2011 at 10:14 PM, Han Pingtian <phan@redhat.com> wrote: > The KSM developer tell us that we should wait 3~5 increments of the > /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results. > Otherwise, there may be some stuck pages that cause the testing failed. A common mistake is thinking that sleep(3) is non-interruptable. This proposed patch also has style-violations and is missing error checking around lseek, et all. Please fix these items according to the style guide. Thanks, -Garrett ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results 2011-02-14 6:25 ` Garrett Cooper @ 2011-02-15 3:13 ` Han Pingtian 2011-02-15 14:37 ` Garrett Cooper 0 siblings, 1 reply; 9+ messages in thread From: Han Pingtian @ 2011-02-15 3:13 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list On Sun, Feb 13, 2011 at 10:25:54PM -0800, Garrett Cooper wrote: > On Sun, Feb 13, 2011 at 10:14 PM, Han Pingtian <phan@redhat.com> wrote: > > The KSM developer tell us that we should wait 3~5 increments of the > > /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results. > > Otherwise, there may be some stuck pages that cause the testing failed. > > A common mistake is thinking that sleep(3) is non-interruptable. > This proposed patch also has style-violations and is missing error > checking around lseek, et all. Please fix these items according to the > style guide. > Thanks, > -Garrett Thanks reviewing. The patched function will be called by testcases/kernel/mem/ksm/ksm* , which all call tst_sig() in setup(). So I think we have processed the interruptable problem of sleep(). I'll submit new patch. > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list -- Han Pingtian Quality Engineer hpt @ #kernel-qe Red Hat, Inc Freedom ... courage ... Commitment ... ACCOUNTABILITY ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results 2011-02-15 3:13 ` Han Pingtian @ 2011-02-15 14:37 ` Garrett Cooper 2011-02-16 2:59 ` Han Pingtian 0 siblings, 1 reply; 9+ messages in thread From: Garrett Cooper @ 2011-02-15 14:37 UTC (permalink / raw) To: Garrett Cooper, ltp-list, caiqian On Mon, Feb 14, 2011 at 7:13 PM, Han Pingtian <phan@redhat.com> wrote: > On Sun, Feb 13, 2011 at 10:25:54PM -0800, Garrett Cooper wrote: >> On Sun, Feb 13, 2011 at 10:14 PM, Han Pingtian <phan@redhat.com> wrote: >> > The KSM developer tell us that we should wait 3~5 increments of the >> > /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results. >> > Otherwise, there may be some stuck pages that cause the testing failed. >> >> A common mistake is thinking that sleep(3) is non-interruptable. >> This proposed patch also has style-violations and is missing error >> checking around lseek, et all. Please fix these items according to the >> style guide. >> Thanks, >> -Garrett > Thanks reviewing. The patched function will be called by > testcases/kernel/mem/ksm/ksm* , which all call tst_sig() in setup(). > So I think we have processed the interruptable problem of sleep(). Are you sure? I suggest reading the RETURN VALUES section of sleep(3), along with the notes about SA_RESTART in signal(7), and compare that with what's implemented in the signal(3) equivalent in tst_sig. HTH, -Garrett ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results 2011-02-15 14:37 ` Garrett Cooper @ 2011-02-16 2:59 ` Han Pingtian 2011-02-21 5:43 ` Han Pingtian 0 siblings, 1 reply; 9+ messages in thread From: Han Pingtian @ 2011-02-16 2:59 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list [-- Attachment #1: Type: text/plain, Size: 2188 bytes --] On Tue, Feb 15, 2011 at 06:37:47AM -0800, Garrett Cooper wrote: > On Mon, Feb 14, 2011 at 7:13 PM, Han Pingtian <phan@redhat.com> wrote: > > On Sun, Feb 13, 2011 at 10:25:54PM -0800, Garrett Cooper wrote: > >> On Sun, Feb 13, 2011 at 10:14 PM, Han Pingtian <phan@redhat.com> wrote: > >> > The KSM developer tell us that we should wait 3~5 increments of the > >> > /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results. > >> > Otherwise, there may be some stuck pages that cause the testing failed. > >> > >> A common mistake is thinking that sleep(3) is non-interruptable. > >> This proposed patch also has style-violations and is missing error > >> checking around lseek, et all. Please fix these items according to the > >> style guide. > >> Thanks, > >> -Garrett > > Thanks reviewing. The patched function will be called by > > testcases/kernel/mem/ksm/ksm* , which all call tst_sig() in setup(). > > So I think we have processed the interruptable problem of sleep(). > > Are you sure? I suggest reading the RETURN VALUES section of > sleep(3), along with the notes about SA_RESTART in signal(7), and > compare that with what's implemented in the signal(3) equivalent in > tst_sig. Thanks. I'll try to make sure the first sleep(1) gets executed to let KSM to scan pages. The second sleep(1) is in a while loop, so I think we needn't do the same thing to it. I'll attach the v3 patch, please review. Thanks. > HTH, > -Garrett > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list -- Han Pingtian Quality Engineer hpt @ #kernel-qe Red Hat, Inc Freedom ... courage ... Commitment ... ACCOUNTABILITY [-- Attachment #2: 0001-ksm-wait-3-increments-of-full_scans-before-checking-.patch --] [-- Type: text/plain, Size: 1871 bytes --] From d88cc9ab633b757d4a878754cae1063246a516e3 Mon Sep 17 00:00:00 2001 From: Han Pingtian <phan@redhat.com> Date: Mon, 14 Feb 2011 11:47:59 +0800 Subject: [PATCH] ksm: wait 3 increments of full_scans before checking the results The KSM developer tells us that we should wait 3~5 increments of the /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results. Otherwise, there may be some stuck pages that cause the testing failed. Signed-off-by: Han Pingtian <phan@redhat.com> --- testcases/kernel/mem/lib/mem.c | 30 ++++++++++++++++++++++++++++-- 1 files changed, 28 insertions(+), 2 deletions(-) diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c index 1a53359..435620f 100644 --- a/testcases/kernel/mem/lib/mem.c +++ b/testcases/kernel/mem/lib/mem.c @@ -298,8 +298,34 @@ void group_check(int run, int pages_shared, int pages_sharing, int pages_volatile, int pages_unshared, int sleep_millisecs, int pages_to_scan) { - /* 5 seconds for ksm to scan pages. */ - sleep(5); + int fd; + char buf[BUFSIZ]; + int old_num, new_num; + + /* 1 seconds for ksm to scan pages. */ + while (sleep(1) == 1) + continue; + + fd = open("/sys/kernel/mm/ksm/full_scans", O_RDONLY); + if (fd == -1) + tst_brkm(TBROK|TERRNO, cleanup, "open"); + + /* wait 3 increments of full_scans */ + if (read(fd, buf, BUFSIZ) == -1) + tst_brkm(TBROK|TERRNO, cleanup, "read"); + old_num = new_num = atoi(buf); + if (lseek(fd, 0, SEEK_SET) == -1) + tst_brkm(TBROK|TERRNO, cleanup, "lseek"); + while (new_num < old_num * 3) { + sleep(1); + if (read(fd, buf, BUFSIZ) < 0) + tst_brkm(TBROK|TERRNO, cleanup, "read"); + new_num = atoi(buf); + if (lseek(fd, 0, SEEK_SET) == -1) + tst_brkm(TBROK|TERRNO, cleanup, "lseek"); + } + close(fd); + tst_resm(TINFO, "check!"); check("run", run); check("pages_shared", pages_shared); -- 1.7.1 [-- Attachment #3: Type: text/plain, Size: 387 bytes --] ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb [-- Attachment #4: Type: text/plain, Size: 155 bytes --] _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results 2011-02-16 2:59 ` Han Pingtian @ 2011-02-21 5:43 ` Han Pingtian 2011-02-23 8:46 ` Garrett Cooper 0 siblings, 1 reply; 9+ messages in thread From: Han Pingtian @ 2011-02-21 5:43 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list Hello Garrett, Any objection to merge this patch? Thanks. On Wed, Feb 16, 2011 at 10:59:58AM +0800, Han Pingtian wrote: > On Tue, Feb 15, 2011 at 06:37:47AM -0800, Garrett Cooper wrote: > > On Mon, Feb 14, 2011 at 7:13 PM, Han Pingtian <phan@redhat.com> wrote: > > > On Sun, Feb 13, 2011 at 10:25:54PM -0800, Garrett Cooper wrote: > > >> On Sun, Feb 13, 2011 at 10:14 PM, Han Pingtian <phan@redhat.com> wrote: > > >> > The KSM developer tell us that we should wait 3~5 increments of the > > >> > /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results. > > >> > Otherwise, there may be some stuck pages that cause the testing failed. > > >> > > >> A common mistake is thinking that sleep(3) is non-interruptable. > > >> This proposed patch also has style-violations and is missing error > > >> checking around lseek, et all. Please fix these items according to the > > >> style guide. > > >> Thanks, > > >> -Garrett > > > Thanks reviewing. The patched function will be called by > > > testcases/kernel/mem/ksm/ksm* , which all call tst_sig() in setup(). > > > So I think we have processed the interruptable problem of sleep(). > > > > Are you sure? I suggest reading the RETURN VALUES section of > > sleep(3), along with the notes about SA_RESTART in signal(7), and > > compare that with what's implemented in the signal(3) equivalent in > > tst_sig. > Thanks. I'll try to make sure the first sleep(1) gets executed to let > KSM to scan pages. The second sleep(1) is in a while loop, so I think we > needn't do the same thing to it. I'll attach the v3 patch, please > review. Thanks. > > > HTH, > > -Garrett > > > > ------------------------------------------------------------------------------ > > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > > Pinpoint memory and threading errors before they happen. > > Find and fix more than 250 security defects in the development cycle. > > Locate bottlenecks in serial and parallel code that limit performance. > > http://p.sf.net/sfu/intel-dev2devfeb > > _______________________________________________ > > Ltp-list mailing list > > Ltp-list@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/ltp-list > > -- > Han Pingtian > Quality Engineer > hpt @ #kernel-qe > Red Hat, Inc > Freedom ... courage ... Commitment ... ACCOUNTABILITY > >From d88cc9ab633b757d4a878754cae1063246a516e3 Mon Sep 17 00:00:00 2001 > From: Han Pingtian <phan@redhat.com> > Date: Mon, 14 Feb 2011 11:47:59 +0800 > Subject: [PATCH] ksm: wait 3 increments of full_scans before checking the results > > The KSM developer tells us that we should wait 3~5 increments of the > /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results. > Otherwise, there may be some stuck pages that cause the testing failed. > > Signed-off-by: Han Pingtian <phan@redhat.com> > --- > testcases/kernel/mem/lib/mem.c | 30 ++++++++++++++++++++++++++++-- > 1 files changed, 28 insertions(+), 2 deletions(-) > > diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c > index 1a53359..435620f 100644 > --- a/testcases/kernel/mem/lib/mem.c > +++ b/testcases/kernel/mem/lib/mem.c > @@ -298,8 +298,34 @@ void group_check(int run, int pages_shared, int pages_sharing, > int pages_volatile, int pages_unshared, > int sleep_millisecs, int pages_to_scan) > { > - /* 5 seconds for ksm to scan pages. */ > - sleep(5); > + int fd; > + char buf[BUFSIZ]; > + int old_num, new_num; > + > + /* 1 seconds for ksm to scan pages. */ > + while (sleep(1) == 1) > + continue; > + > + fd = open("/sys/kernel/mm/ksm/full_scans", O_RDONLY); > + if (fd == -1) > + tst_brkm(TBROK|TERRNO, cleanup, "open"); > + > + /* wait 3 increments of full_scans */ > + if (read(fd, buf, BUFSIZ) == -1) > + tst_brkm(TBROK|TERRNO, cleanup, "read"); > + old_num = new_num = atoi(buf); > + if (lseek(fd, 0, SEEK_SET) == -1) > + tst_brkm(TBROK|TERRNO, cleanup, "lseek"); > + while (new_num < old_num * 3) { > + sleep(1); > + if (read(fd, buf, BUFSIZ) < 0) > + tst_brkm(TBROK|TERRNO, cleanup, "read"); > + new_num = atoi(buf); > + if (lseek(fd, 0, SEEK_SET) == -1) > + tst_brkm(TBROK|TERRNO, cleanup, "lseek"); > + } > + close(fd); > + > tst_resm(TINFO, "check!"); > check("run", run); > check("pages_shared", pages_shared); > -- > 1.7.1 > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list -- Han Pingtian Quality Engineer hpt @ #kernel-qe Red Hat, Inc Freedom ... courage ... Commitment ... ACCOUNTABILITY ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results 2011-02-21 5:43 ` Han Pingtian @ 2011-02-23 8:46 ` Garrett Cooper 2011-02-23 10:12 ` Han Pingtian 0 siblings, 1 reply; 9+ messages in thread From: Garrett Cooper @ 2011-02-23 8:46 UTC (permalink / raw) To: Garrett Cooper, ltp-list On Sun, Feb 20, 2011 at 9:43 PM, Han Pingtian <phan@redhat.com> wrote: > Hello Garrett, > > Any objection to merge this patch? Please resubmit a git-formatted email with the patch attached. Thanks, -Garrett ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results 2011-02-23 8:46 ` Garrett Cooper @ 2011-02-23 10:12 ` Han Pingtian 2011-02-24 5:33 ` Garrett Cooper 0 siblings, 1 reply; 9+ messages in thread From: Han Pingtian @ 2011-02-23 10:12 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list [-- Attachment #1: Type: text/plain, Size: 465 bytes --] On Wed, Feb 23, 2011 at 12:46:00AM -0800, Garrett Cooper wrote: > On Sun, Feb 20, 2011 at 9:43 PM, Han Pingtian <phan@redhat.com> wrote: > > Hello Garrett, > > > > Any objection to merge this patch? > > Please resubmit a git-formatted email with the patch attached. > Thanks, > -Garrett This is the rebuilded patch, sorry for the inconvenience. -- Han Pingtian Quality Engineer hpt @ #kernel-qe Red Hat, Inc Freedom ... courage ... Commitment ... ACCOUNTABILITY [-- Attachment #2: 0001-ksm-wait-3-increments-of-full_scans-before-checking-.patch --] [-- Type: text/plain, Size: 1871 bytes --] From 1345942c75c55a9702df1cd66a2402c64c430d52 Mon Sep 17 00:00:00 2001 From: Han Pingtian <phan@redhat.com> Date: Mon, 14 Feb 2011 11:47:59 +0800 Subject: [PATCH] ksm: wait 3 increments of full_scans before checking the results The KSM developer tells us that we should wait 3~5 increments of the /sys/kernel/mm/ksm/full_scans before checking ksm* testcases's results. Otherwise, there may be some stuck pages that cause the testing failed. Signed-off-by: Han Pingtian <phan@redhat.com> --- testcases/kernel/mem/lib/mem.c | 30 ++++++++++++++++++++++++++++-- 1 files changed, 28 insertions(+), 2 deletions(-) diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c index 1a53359..435620f 100644 --- a/testcases/kernel/mem/lib/mem.c +++ b/testcases/kernel/mem/lib/mem.c @@ -298,8 +298,34 @@ void group_check(int run, int pages_shared, int pages_sharing, int pages_volatile, int pages_unshared, int sleep_millisecs, int pages_to_scan) { - /* 5 seconds for ksm to scan pages. */ - sleep(5); + int fd; + char buf[BUFSIZ]; + int old_num, new_num; + + /* 1 seconds for ksm to scan pages. */ + while (sleep(1) == 1) + continue; + + fd = open("/sys/kernel/mm/ksm/full_scans", O_RDONLY); + if (fd == -1) + tst_brkm(TBROK|TERRNO, cleanup, "open"); + + /* wait 3 increments of full_scans */ + if (read(fd, buf, BUFSIZ) == -1) + tst_brkm(TBROK|TERRNO, cleanup, "read"); + old_num = new_num = atoi(buf); + if (lseek(fd, 0, SEEK_SET) == -1) + tst_brkm(TBROK|TERRNO, cleanup, "lseek"); + while (new_num < old_num * 3) { + sleep(1); + if (read(fd, buf, BUFSIZ) < 0) + tst_brkm(TBROK|TERRNO, cleanup, "read"); + new_num = atoi(buf); + if (lseek(fd, 0, SEEK_SET) == -1) + tst_brkm(TBROK|TERRNO, cleanup, "lseek"); + } + close(fd); + tst_resm(TINFO, "check!"); check("run", run); check("pages_shared", pages_shared); -- 1.7.1 [-- Attachment #3: Type: text/plain, Size: 429 bytes --] ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev [-- Attachment #4: Type: text/plain, Size: 155 bytes --] _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results 2011-02-23 10:12 ` Han Pingtian @ 2011-02-24 5:33 ` Garrett Cooper 0 siblings, 0 replies; 9+ messages in thread From: Garrett Cooper @ 2011-02-24 5:33 UTC (permalink / raw) To: Garrett Cooper, ltp-list On Wed, Feb 23, 2011 at 2:12 AM, Han Pingtian <phan@redhat.com> wrote: > On Wed, Feb 23, 2011 at 12:46:00AM -0800, Garrett Cooper wrote: >> On Sun, Feb 20, 2011 at 9:43 PM, Han Pingtian <phan@redhat.com> wrote: >> > Hello Garrett, >> > >> > Any objection to merge this patch? >> >> Please resubmit a git-formatted email with the patch attached. > > This is the rebuilded patch, sorry for the inconvenience. Committed -- thanks! -Garrett ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-02-24 5:33 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-14 6:14 [LTP] [PATCH] ksm: wait 3 increments of full_scans before checking the results Han Pingtian 2011-02-14 6:25 ` Garrett Cooper 2011-02-15 3:13 ` Han Pingtian 2011-02-15 14:37 ` Garrett Cooper 2011-02-16 2:59 ` Han Pingtian 2011-02-21 5:43 ` Han Pingtian 2011-02-23 8:46 ` Garrett Cooper 2011-02-23 10:12 ` Han Pingtian 2011-02-24 5:33 ` Garrett Cooper
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox