Re: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()

[Cristian Greco <cristian@regolo.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1273 bytes --]

On Fri, 04 Mar 2011 01:51:20 +0800
Caspar Zhang <czhang@redhat.com> wrote:

> Similar to getdents0[34] and getdents0[234]_64, so I updated the patch
> to v2.
> 
> These tests contain x86 asm so that they wouldn't be run on x86_64
> machine, but run into a simple main() functions instead. However all of
> them are missing tst_exit() which could result in a exit_code=10
> failure.
> 
> Signed-off-by: Caspar Zhang <czhang@redhat.com>
> ---
>  testcases/kernel/syscalls/getdents/getdents02.c |    4 ++--
>  testcases/kernel/syscalls/getdents/getdents03.c |    4 ++--
>  testcases/kernel/syscalls/getdents/getdents04.c |    4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/getdents/getdents02.c
> b/testcases/kernel/syscalls/getdents/getdents02.c
> index 4daae05..2503712 100644
> --- a/testcases/kernel/syscalls/getdents/getdents02.c
> +++ b/testcases/kernel/syscalls/getdents/getdents02.c
> @@ -74,7 +74,7 @@ int main()
>  {
>  	tst_resm(TINFO, "This test includes x86 asm and will not work on "
>  		 "this machine");

Hi Caspar,

wouldn't it be better to call tst_resm() with TCONF instead of TINFO,
for the sake of consistency?

Thanks,
--
Cristian Greco
GPG key ID: 0xCF4D32E4

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 309 bytes --]

------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list