Re: [LTP] [PATCH] fs: fsstress: make test more POSIX compliant

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> >> -	if (no_xfs) {
> >> -		diob.d_miniosz = stb.st_blksize;
> >> -		diob.d_maxiosz = stb.st_blksize * 256;  /* good number ? */
> >> -		diob.d_mem = stb.st_blksize;
> >> -	}
> >> +	diob.d_miniosz = stb.st_blksize;
> >> +	diob.d_maxiosz = stb.st_blksize * 256;  /* good number ? */
> >> +	diob.d_mem = stb.st_blksize;
> > 
> > Hmm, why you are removing the if (no_xfs) here (I don't say it's wrong,
> > I only want to know why)?
> 
> The compiler gave warning that diob.d_* may not initialized. I don't
> know what the values diob.d_* should be if XFS exists (no_xfs == 0), but
> I guess they should be the same as when XFS not available.

Actually it's a little more complicated. This change breaks compilation
without -DNO_XFS (that is defined as default in Makefile).

The whole point of NO_XFS and no_xfs is that the test may be compiled
with and without xfs specialities as well as executed with and without
xfs specialities.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list