Re: [LTP] [Patch v5 3/4] KSM test case fixes - mmap10

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> --- ltp.orig/testcases/kernel/syscalls/mmap/mmap10.c	2011-09-08 11:32:12.000000000 +0200
> +++ ltp/testcases/kernel/syscalls/mmap/mmap10.c	2011-09-09 07:22:35.000000000 +0200
> @@ -62,6 +62,7 @@
>  #include "test.h"
>  #include "usctest.h"
>  #include "config.h"
> +#include "../../mem/include/mem.h"
>  
>  #define SIZE (5*1024*1024)
>  
> @@ -94,6 +95,8 @@ int main(int argc, char *argv[])
>  
>  	if (opt_ksm)
>  	{
> +		if (access(PATH_KSM, F_OK) == -1)
> +			tst_brkm(TCONF, NULL, "KSM configuration is not enabled");
>  #ifdef HAVE_MADV_MERGEABLE
>  		tst_resm(TINFO, "add to KSM regions.");
>  #else

I don't have a good feeling about including header files across several
directories, which could break things miraculously in the future. The
best solution would be creating one header file to store constants to in
ltp/include/. Or even duplicating the constant in the mmap10.c source
seems as better solution to me.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Why Cloud-Based Security and Archiving Make Sense
Osterman Research conducted this study that outlines how and why cloud
computing security and archiving is rapidly being adopted across the IT 
space for its ease of implementation, lower cost, and increased 
reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list