Re: [LTP] [PATCH] testcases: syscalls: use tst_tmpdir() interface

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
First of all, please use more recent LTP source (ideally git checkout).
The '/* End setup() */' and '/* End cleanup() */' comments were removed
about an year ago.

> index 5f81dac..0851cbc 100644
> --- a/ltp-full-20101031/testcases/kernel/syscalls/fstatat/fstatat01.c
> +++ b/ltp-full-20101031/testcases/kernel/syscalls/fstatat/fstatat01.c
> @@ -247,6 +247,8 @@ void setup()
>  	/* capture signals */
>  	tst_sig(NOFORK, DEF_HANDLER, cleanup);
>  
> +	tst_tmpdir();
> +
>  	/* Pause if that option was specified */
>  	TEST_PAUSE;
>  }				/* End setup() */
> @@ -269,6 +271,8 @@ void cleanup()
>  	 */
>  	TEST_CLEANUP;
>  
> +	tst_rmdir();
> +
>  	/* exit with return code appropriate for results */
>  	tst_exit();
>  }				/* End cleanup() */

You missed the testfile3 that uses absolute path to /tmp/ which should
rather be absoulute path to tst_tmpdir. Something like this should work:

snprintf(testfile3, sizeof(testfile3),
         "%s/fstatattestfile.txt", tst_get_tmpdir())

Note that we no longer need the pid in the filenames as the create test
directory is unique.

And the same goes for the rest of the testcases.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list