Re: [LTP] [PATCH] aio_fsync:4-2: wait until the io is in no INPROGRESS

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> If the aio is in INPROGRESS, the aio_return is undefined, and
> may cause Segment Faul.
> So, wait for it.
> 
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> Signed-off-by: lidan <li.dan@cn.fujitsu.com>
> ---
>  .../conformance/interfaces/aio_fsync/4-2.c         |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_fsync/4-2.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_fsync/4-2.c
> index bf76109..2be8d4b 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_fsync/4-2.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_fsync/4-2.c
> @@ -68,6 +68,7 @@ int main()
>  		exit(PTS_FAIL);
>  	}
>  
> +	while(aio_error(&aiocb_fsync) == EINPROGRESS);
>  	errno = 0;
>  	aio_return(&aiocb_fsync);
>  	if (errno != 0)
> @@ -78,4 +79,4 @@ int main()
>  	close(fd);
>  	printf ("Test PASSED\n");
>  	return PTS_PASS;
> -}
> \ No newline at end of file
> +}

Yes that is one of the problems with that testcase, however I would like
to see some usleep() in the while body, because otherwise this is
basically bussy loop which would unnecesarilly eat cputime.

The other problem is that most of the aio functions are not modifying
the errno, which is common misconception (the aio_read and aio_write may
return -1 and set the errno if the error happend while the aio operation
was being initalized). So correct test would check the return value from
aio_error() and then check that return value from aio_return() match the
buffer size. Mind that you could call them it exactly once after the
operation is finished.

And seeing the difference between 4-1.c and 4-2.c these two should be
merged into one testcase.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list