From: Cyril Hrubis <chrubis@suse.cz>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function
Date: Thu, 29 Dec 2011 20:41:32 +0100 [thread overview]
Message-ID: <20111229194132.GC330@saboteur.suse.cz> (raw)
In-Reply-To: <4EFA8B41.1040802@casparzhang.com>
Hi!
> > + tname = tc[i].fname;
> > + tkey = tc[i].key;
> > + tvalue = tc[i].value;
> > + tsize = tc[i].size;
> > + tflags = tc[i].flags;
> > + texp_err = tc[i].exp_err;
> > +
> > + TEST(setxattr(tname, tkey, tvalue, tsize, tflags));
>
> I wonder whether it's necessary. all of the variables be used once only.
I slightly for removing that too.
So if you wan't to change that, resend new patch, otherwise let me know,
I'll commit this as it is.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2011-12-29 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 4:04 [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) basic function Eryu Guan
2011-12-26 4:04 ` [LTP] [PATCH 2/2 V2] syscalls/getxattr01: new testcase to test getxattr(2) " Eryu Guan
2011-12-28 3:21 ` [LTP] [PATCH 1/2 V2] syscalls/setxattr01: new testcase to test setxattr(2) " Caspar Zhang
2011-12-29 19:41 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111229194132.GC330@saboteur.suse.cz \
--to=chrubis@suse.cz \
--cc=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox