public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: ltp-list@lists.sourceforge.net
Cc: Markos Chandras <Markos.Chandras@imgtec.com>
Subject: Re: [LTP] [PATCH 08/21] syscalls/remap_file_pages: unsigned int is always greater to zero
Date: Tue, 3 Jan 2012 15:38:47 -0500	[thread overview]
Message-ID: <201201031538.47749.vapier@gentoo.org> (raw)
In-Reply-To: <4F02E0C6.3090308@imgtec.com>


[-- Attachment #1.1: Type: Text/Plain, Size: 267 bytes --]

On Tuesday 03 January 2012 06:04:38 Markos Chandras wrote:
> Hi, please review the attached patch

you should add a local int variable, store getpagesize() into that, and then 
use that to initialize page_sz rather than call getpagesize() multiple times.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2012-01-03 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-03 11:04 [LTP] [PATCH 08/21] syscalls/remap_file_pages: unsigned int is always greater to zero Markos Chandras
2012-01-03 19:37 ` Garrett Cooper
2012-01-03 20:38 ` Mike Frysinger [this message]
2012-01-04 14:34   ` Cyril Hrubis
     [not found]     ` <201201041358.21225.vapier@gentoo.org>
2012-01-05 10:45       ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201031538.47749.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=Markos.Chandras@imgtec.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox