From: Cyril Hrubis <chrubis@suse.cz>
To: Markos Chandras <Markos.Chandras@imgtec.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 02/21] lib/self_exec: Remove extra argument from tst_resm function call
Date: Wed, 4 Jan 2012 15:20:10 +0100 [thread overview]
Message-ID: <20120104142010.GA15845@saboteur.suse.cz> (raw)
In-Reply-To: <4F02DB32.1050503@imgtec.com>
Hi!
> On 01/03/2012 09:57 AM, Markos Chandras wrote:
> >On 01/03/2012 09:50 AM, Garrett Cooper wrote:
> >>On Tue, Jan 3, 2012 at 1:35 AM, Markos Chandras
> >><Markos.Chandras@imgtec.com> wrote:
> >>>Hi, please review the attached patch
> >>
> >> Converting the function to tst_brkm and removing the tst_exit call
> >>below it would be better.
> >>Thanks!
> >>-Garrett
> >Agreed, but to make this consistent, all the tst_resm&& tst_exit pairs
> >should be replaced with tst_brkm. I will prepare a patch
> >
> Here is a patch that converts all tst_resm && tst_exit calls to
> tst_brkm. Please review it.
Commited, thanks.
And please add better patch description next time.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-01-04 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 9:35 [LTP] [PATCH 02/21] lib/self_exec: Remove extra argument from tst_resm function call Markos Chandras
2012-01-03 9:50 ` Garrett Cooper
2012-01-03 9:57 ` Markos Chandras
2012-01-03 10:40 ` Markos Chandras
2012-01-03 18:01 ` Garrett Cooper
2012-01-04 14:20 ` Cyril Hrubis [this message]
[not found] ` <4F045E94.3060004@imgtec.com>
2012-01-04 15:35 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104142010.GA15845@saboteur.suse.cz \
--to=chrubis@suse.cz \
--cc=Markos.Chandras@imgtec.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox