From: Cyril Hrubis <chrubis@suse.cz>
To: Mike Frysinger <vapier@gentoo.org>
Cc: ltp-list@lists.sourceforge.net,
Markos Chandras <Markos.Chandras@imgtec.com>
Subject: Re: [LTP] [PATCH 08/21] syscalls/remap_file_pages: unsigned int is always greater to zero
Date: Wed, 4 Jan 2012 15:34:26 +0100 [thread overview]
Message-ID: <20120104143426.GD15845@saboteur.suse.cz> (raw)
In-Reply-To: <201201031538.47749.vapier@gentoo.org>
Hi!
> you should add a local int variable, store getpagesize() into that, and then
> use that to initialize page_sz rather than call getpagesize() multiple times.
That would be better.
And moreover isn't sizeof(char) == 1 by definition?
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-01-04 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 11:04 [LTP] [PATCH 08/21] syscalls/remap_file_pages: unsigned int is always greater to zero Markos Chandras
2012-01-03 19:37 ` Garrett Cooper
2012-01-03 20:38 ` Mike Frysinger
2012-01-04 14:34 ` Cyril Hrubis [this message]
[not found] ` <201201041358.21225.vapier@gentoo.org>
2012-01-05 10:45 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104143426.GD15845@saboteur.suse.cz \
--to=chrubis@suse.cz \
--cc=Markos.Chandras@imgtec.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox