Re: [LTP] [PATCH] fix getxattr02 case with errno EPERM

Re: [LTP] [PATCH] fix getxattr02 case with errno EPERM

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 571 bytes --]

On Monday 09 January 2012 02:29:05 Eryu Guan wrote:
> On Mon, Jan 09, 2012 at 02:50:21PM +0800, Peng Haitao wrote:
> > +	if ((tst_kvercmp(3, 0, 0)) >= 0)
> > +		exp_eno = ENODATA;
> > +	else
> > +		exp_eno = EPERM;
> 
> I think some comments describing why the comparison is needed will be
> better, the commit message will be fine here.
> 
> Or you can put the reason at the beginning of the test case along with
> the test descriptions.

a comment right above this section of code would be best.  less likely to 
bitrot or get loss in the future.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 430 bytes --]

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] fix getxattr02 case with errno EPERM

[Wanlong Gao]

On 01/10/2012 11:25 AM, Caspar Zhang wrote:

> On 2012年01月10日 09:45, Peng Haitao wrote:
>> + 95» » /*·Before·kernel·3.0.0,·getxattr(2)·will·set·errno·with·'EPERM'
>> + 96» » ·*·when·the·file·is·not·a·regular·file·and·directory,·refer·to
>> + 97» » ·*·commitid·55b23bd
>> + 98» » ·*/
> 
> For multiple-line comments, would it be better to be:
> 
> /*
>  * xxx
>  * xxx
>  */


Sure, you are right.

> 
> Caspar
> 



------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list