public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] ioctl: check if tty device nodes are usable
Date: Wed, 15 Aug 2012 12:27:47 -0400	[thread overview]
Message-ID: <201208151227.48778.vapier@gentoo.org> (raw)
In-Reply-To: <4505db854dcfba3131523a89e158cae4f9c27d01.1345025497.git.jstancek@redhat.com>


[-- Attachment #1.1: Type: Text/Plain, Size: 402 bytes --]

On Wednesday 15 August 2012 06:14:34 Jan Stancek wrote:
> +has_tty()
> +{
> +    if command -v stty >/dev/null 2>&1; then
> +        stty --file=$1 > /dev/null
> +        if [ $? -ne 0 ]; then
> +            return 0;
> +        fi
> +    fi
> +    return 1;

no need for the trailing semi colons on either of those return statements

> +        continue;

or here

> +        continue;

or here
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 395 bytes --]

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      reply	other threads:[~2012-08-15 16:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-15 10:14 [LTP] [PATCH] ioctl: check if tty device nodes are usable Jan Stancek
2012-08-15 16:27 ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208151227.48778.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox