* [LTP] Test case send01 fails in kernel version 3.6-rc1, rc2 and rc3 @ 2012-08-27 10:30 shyju pv 2012-08-27 11:16 ` Jan Stancek 0 siblings, 1 reply; 6+ messages in thread From: shyju pv @ 2012-08-27 10:30 UTC (permalink / raw) To: ltp-list@lists.sourceforge.net; +Cc: shyju pv Hi, sendt01 test cases fails from 3.6-rc1,rc2 and rc3 Bug descreption: ------------------------- LTP_Version: 2012-06-14 LTP Test case: send01 Description : Verifies the send syscall errorno for various failure cases Failure Analysis : when the invalid flag set , The system gives error no EOPNOTSUPP (95) whereas LTP expects EFAULT(14) Fix : Modify the LTP code with respect the the system return values of the latest kernel(3.6-rc1) Test case passed in Kernel 3.5 Failed from 3.6-rc1,rc2and rc3 Execution Log --------------------- <<<test_output>>> incrementing stop send01 1 TPASS : bad file descriptor successful send01 2 TPASS : invalid socket successful send01 3 TPASS : invalid send buffer successful send01 4 TPASS : UDP message too big successful send01 5 TPASS : local endpoint shutdown successful send01 6 TFAIL : invalid flags set ; returned -1 (expected -1), errno 95 (expected 14) <<<execution_status>>> initiation_status="ok" duration=0 termination_type=exited termination_id=1 corefile=no cutime=0 cstime=0 <<<test_end>>> INFO: ltp-pan reported some tests FAIL Shyju ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] Test case send01 fails in kernel version 3.6-rc1, rc2 and rc3 2012-08-27 10:30 [LTP] Test case send01 fails in kernel version 3.6-rc1, rc2 and rc3 shyju pv @ 2012-08-27 11:16 ` Jan Stancek 2012-10-03 11:40 ` chrubis 0 siblings, 1 reply; 6+ messages in thread From: Jan Stancek @ 2012-08-27 11:16 UTC (permalink / raw) To: shyju pv; +Cc: ltp-list ----- Original Message ----- > From: "shyju pv" <shyju.pv@huawei.com> > To: ltp-list@lists.sourceforge.net > Cc: "shyju pv" <shyju.pv@huawei.com> > Sent: Monday, 27 August, 2012 12:30:34 PM > Subject: [LTP] Test case send01 fails in kernel version 3.6-rc1, rc2 and rc3 > > Hi, > > sendt01 test cases fails from 3.6-rc1,rc2 and rc3 > > Bug descreption: > ------------------------- > LTP_Version: 2012-06-14 > LTP Test case: send01 > Description : Verifies the send syscall errorno for various failure > cases > Failure Analysis : when the invalid flag set , The system gives > error no > EOPNOTSUPP (95) whereas LTP expects EFAULT(14) > Fix : Modify the LTP code with respect the the system return values > of the > latest kernel(3.6-rc1) > Test case passed in Kernel 3.5 > Failed from 3.6-rc1,rc2and rc3 Looks to be the same reason as sendto(). I'm thinking we can either remove that test or change it to UDP: diff --git a/testcases/kernel/syscalls/sendto/sendto01.c b/testcases/kernel/syscalls/sendto/sendto01.c index ad64c70..c8dd9bd 100644 --- a/testcases/kernel/syscalls/sendto/sendto01.c +++ b/testcases/kernel/syscalls/sendto/sendto01.c @@ -126,8 +126,8 @@ struct test_case_t { /* test case structure */ sizeof(sin1), -1, EPIPE, setup2, cleanup1, "local endpoint shutdown"} , { - PF_INET, SOCK_STREAM, 0, buf, sizeof(buf), -1, &sin1, - sizeof(sin1), 0, EPIPE, setup1, cleanup1, + PF_INET, SOCK_DGRAM, 0, buf, sizeof(buf), -1, &sin1, + sizeof(sin1), -1, EOPNOTSUPP, setup1, cleanup1, "invalid flags set"} }; this way it should hit: if (msg->msg_flags&MSG_OOB) /* Mirror BSD error message compatibility */ return -EOPNOTSUPP; I see the check is there at least since 2.6.11. Any thoughts? Regards, Jan > > Execution Log > --------------------- > <<<test_output>>> > incrementing stop > send01 1 TPASS : bad file descriptor successful > send01 2 TPASS : invalid socket successful > send01 3 TPASS : invalid send buffer successful > send01 4 TPASS : UDP message too big successful > send01 5 TPASS : local endpoint shutdown successful > send01 6 TFAIL : invalid flags set ; returned -1 (expected > -1), > errno > 95 (expected 14) > <<<execution_status>>> > initiation_status="ok" > duration=0 termination_type=exited termination_id=1 corefile=no > cutime=0 cstime=0 > <<<test_end>>> > INFO: ltp-pan reported some tests FAIL > > Shyju > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the latest in > malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [LTP] Test case send01 fails in kernel version 3.6-rc1, rc2 and rc3 2012-08-27 11:16 ` Jan Stancek @ 2012-10-03 11:40 ` chrubis [not found] ` <564795434.6124572.1349265888804.JavaMail.root@redhat.com> 0 siblings, 1 reply; 6+ messages in thread From: chrubis @ 2012-10-03 11:40 UTC (permalink / raw) To: Jan Stancek; +Cc: shyju pv, ltp-list Hi! > Looks to be the same reason as sendto(). > I'm thinking we can either remove that test or change it to UDP: > > diff --git a/testcases/kernel/syscalls/sendto/sendto01.c b/testcases/kernel/syscalls/sendto/sendto01.c > index ad64c70..c8dd9bd 100644 > --- a/testcases/kernel/syscalls/sendto/sendto01.c > +++ b/testcases/kernel/syscalls/sendto/sendto01.c > @@ -126,8 +126,8 @@ struct test_case_t { /* test case structure */ > sizeof(sin1), -1, EPIPE, setup2, cleanup1, > "local endpoint shutdown"} > , { > - PF_INET, SOCK_STREAM, 0, buf, sizeof(buf), -1, &sin1, > - sizeof(sin1), 0, EPIPE, setup1, cleanup1, > + PF_INET, SOCK_DGRAM, 0, buf, sizeof(buf), -1, &sin1, > + sizeof(sin1), -1, EOPNOTSUPP, setup1, cleanup1, > "invalid flags set"} > }; The usuall concensus for such case is to change expected return values depending on the kernel version (see for example tst_kvercmp() in testcases/kernel/syscalls/sysctl/sysctl03.c). Which is the best solution I can come up with. On the other hand we don't bother to work with rc kernels they change far to often. Does this behave same on released linux 3.6? -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <564795434.6124572.1349265888804.JavaMail.root@redhat.com>]
* Re: [LTP] Test case send01 fails in kernel version 3.6-rc1, rc2 and rc3 [not found] ` <564795434.6124572.1349265888804.JavaMail.root@redhat.com> @ 2012-10-03 12:32 ` chrubis 2012-10-10 13:09 ` chrubis 0 siblings, 1 reply; 6+ messages in thread From: chrubis @ 2012-10-03 12:32 UTC (permalink / raw) To: Jan Stancek; +Cc: shyju pv, ltp-list Hi! > > The usuall concensus for such case is to change expected return > > values > > depending on the kernel version (see for example tst_kvercmp() in > > testcases/kernel/syscalls/sysctl/sysctl03.c). Which is the best > > solution > > I can come up with. > > > > On the other hand we don't bother to work with rc kernels they change > > far to often. > > > > Does this behave same on released linux 3.6? > > I believe it does. I just tested with RHEL7 kernel based on 3.6, which is at this point > very close to vanilla (+- few changes in build scripts and config). > > # ./send01 > send01 1 TPASS : bad file descriptor successful > send01 2 TPASS : invalid socket successful > send01 3 TPASS : invalid send buffer successful > send01 4 TPASS : UDP message too big successful > send01 5 TPASS : local endpoint shutdown successful > send01 6 TFAIL : invalid flags set ; returned -1 (expected -1), errno 95 (expected 14) > # cd ../sendto/ > # ./sendto01 > sendto01 1 TPASS : bad file descriptor successful > sendto01 2 TPASS : invalid socket successful > sendto01 3 TPASS : invalid send buffer successful > sendto01 4 TPASS : connected TCP successful > sendto01 5 TPASS : not connected TCP successful > sendto01 6 TPASS : invalid to buffer length successful > sendto01 7 TPASS : invalid to buffer successful > sendto01 8 TPASS : UDP message too big successful > sendto01 9 TPASS : local endpoint shutdown successful > sendto01 10 TFAIL : invalid flags set ; returned -1 (expected 0), errno 95 (expected 32) > # cd ../sendmsg/ > # ./sendmsg01 > sendmsg01 1 TPASS : bad file descriptor successful > sendmsg01 2 TPASS : invalid socket successful > sendmsg01 3 TPASS : invalid send buffer successful > sendmsg01 4 TPASS : connected TCP successful > sendmsg01 5 TPASS : not connected TCP successful > sendmsg01 6 TPASS : invalid to buffer length successful > sendmsg01 7 TPASS : invalid to buffer successful > sendmsg01 8 TPASS : UDP message too big successful > sendmsg01 9 TPASS : local endpoint shutdown successful > sendmsg01 10 TPASS : invalid iovec pointer successful > sendmsg01 11 TPASS : invalid msghdr pointer successful > sendmsg01 12 TPASS : rights passing successful > sendmsg01 13 TPASS : invalid flags set w/ control successful > sendmsg01 14 TFAIL : invalid flags set ; returned -1 (expected 0), errno 95 (expected 95) > sendmsg01 15 TPASS : invalid cmsg length successful > sendmsg01 16 TPASS : invalid cmsg pointer successful Okay then I will prepare patch. Stay tuned. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] Test case send01 fails in kernel version 3.6-rc1, rc2 and rc3 2012-10-03 12:32 ` chrubis @ 2012-10-10 13:09 ` chrubis 2012-10-10 13:32 ` chrubis 0 siblings, 1 reply; 6+ messages in thread From: chrubis @ 2012-10-10 13:09 UTC (permalink / raw) To: Jan Stancek; +Cc: shyju pv, ltp-list Hi! > Okay then I will prepare patch. Stay tuned. I've just pushed patch to fix this (tested on 3.6.1). -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] Test case send01 fails in kernel version 3.6-rc1, rc2 and rc3 2012-10-10 13:09 ` chrubis @ 2012-10-10 13:32 ` chrubis 0 siblings, 0 replies; 6+ messages in thread From: chrubis @ 2012-10-10 13:32 UTC (permalink / raw) To: Jan Stancek; +Cc: shyju pv, ltp-list Hi! > > Okay then I will prepare patch. Stay tuned. > > I've just pushed patch to fix this (tested on 3.6.1). I've used the tst_kvercmp() wrong at first, shame on me. (fixed in git) -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-10 13:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-27 10:30 [LTP] Test case send01 fails in kernel version 3.6-rc1, rc2 and rc3 shyju pv
2012-08-27 11:16 ` Jan Stancek
2012-10-03 11:40 ` chrubis
[not found] ` <564795434.6124572.1349265888804.JavaMail.root@redhat.com>
2012-10-03 12:32 ` chrubis
2012-10-10 13:09 ` chrubis
2012-10-10 13:32 ` chrubis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox