From: chrubis@suse.cz
To: Mike Frysinger <vapier@gentoo.org>
Cc: Zhou Guojian <Guojian.Zhou@windriver.com>,
ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] There was no "processor" key word in the "cpuinfo" on the non-SMP ARM Platforms. So the tracing "ftrace_buffer_size.sh" script would report "division by 0" error, then it would exit soon. The tracing test would check failed when it could not find this script running.
Date: Mon, 15 Oct 2012 20:18:09 +0200 [thread overview]
Message-ID: <20121015181808.GA6380@rei.suse.cz> (raw)
In-Reply-To: <201210151332.57424.vapier@gentoo.org>
Hi!
> really we should be using `getconf _NPROCESSORS_ONLN` instead and centralizing
> this parsing logic. /proc/cpuinfo is directly accessed by many scripts. the
> -i suggestion i provided came from its usage in those other files which,
> according to your findings, are also broken.
>
> i'd suggest updating tools/apicmds/ to add a new helper program like
> `tst_ncpus` which will call sysconf() and we convert all of our .sh scripts
> from reading /proc/cpuinfo to calling that program.
That is coincidentally soultion I would about to propose.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next parent reply other threads:[~2012-10-15 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1349679654-16708-1-git-send-email-GuoJian.Zhou@windriver.com>
[not found] ` <201210150014.47389.vapier@gentoo.org>
[not found] ` <507B9964.8070905@windriver.com>
[not found] ` <201210151332.57424.vapier@gentoo.org>
2012-10-15 18:18 ` chrubis [this message]
2012-10-15 18:21 ` [LTP] [PATCH] There was no "processor" key word in the "cpuinfo" on the non-SMP ARM Platforms. So the tracing "ftrace_buffer_size.sh" script would report "division by 0" error, then it would exit soon. The tracing test would check failed when it could not find this script running chrubis
[not found] ` <1350443616-20186-1-git-send-email-gaowanlong@cn.fujitsu.com>
2012-10-17 4:31 ` [LTP] [PATCH] tools: add tst_ncpus/_max api to get number of CPUS Mike Frysinger
2012-10-17 7:13 ` Wanlong Gao
2012-10-17 14:09 ` chrubis
2012-10-17 13:00 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015181808.GA6380@rei.suse.cz \
--to=chrubis@suse.cz \
--cc=Guojian.Zhou@windriver.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox