From: chrubis@suse.cz
To: cxie@redhat.com
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] thp/thp03: new testcase
Date: Mon, 29 Oct 2012 14:57:32 +0100 [thread overview]
Message-ID: <20121029135732.GA12578@rei.suse.cz> (raw)
In-Reply-To: <1351502940-20415-1-git-send-email-cxie@redhat.com>
Hi!
> Modified form a reproducer for
> https://patchwork.kernel.org/patch/1358441/
I would add this link as well as kernel commit hash to the
comment with testcase description too. Just in case.
> +char *TCID = "thp03";
It's missing:
int TST_TOTAL = 1;
So that test framework knows the number of executed tests.
(I'm not sure if it's currently used, but all the other
tests defined this)
> +static void thp_test(void);
> +
> +static long hugepage_size;
> +static long unaligned_size;
> +static long page_size;
The rests seems okay.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
The Windows 8 Center - In partnership with Sourceforge
Your idea - your app - 30 days.
Get started!
http://windows8center.sourceforge.net/
what-html-developers-need-to-know-about-coding-windows-8-metro-style-apps/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2012-10-29 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 9:29 [LTP] [PATCH] thp/thp03: new testcase cxie
2012-10-29 10:28 ` Caspar Zhang
2012-10-29 13:57 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029135732.GA12578@rei.suse.cz \
--to=chrubis@suse.cz \
--cc=cxie@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox