public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] realtime/lib: Fix includes in Makefile
@ 2013-01-16 20:34 Sedat Dilek
  2013-01-17 15:14 ` chrubis
  0 siblings, 1 reply; 3+ messages in thread
From: Sedat Dilek @ 2013-01-16 20:34 UTC (permalink / raw)
  To: ltp-list

On a freshly cloned ltp-git source-dir and with ltp-full-20130109, executing
'make distclean' fails with these errors:

testcases/realtime/lib/Makefile:25: ../../../../config.mk: No such file or directory
make[2]: *** No rule to make target `../../../../config.mk'.  Stop.

The patch fixes the issue by using env_pre.mk to include config.mk from
the correct location.

Tested with ltp-full-20130109 and ltp-git (20130109-5-g385d792).

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 testcases/realtime/lib/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testcases/realtime/lib/Makefile b/testcases/realtime/lib/Makefile
index 8860549..fbbb873 100644
--- a/testcases/realtime/lib/Makefile
+++ b/testcases/realtime/lib/Makefile
@@ -22,7 +22,8 @@
 
 top_srcdir		?= ../../..
 
-include $(top_srcdir)/../config.mk
+include $(top_srcdir)/include/mk/env_pre.mk
+include $(abs_srcdir)/../config.mk
 
 CFLAGS			+= -D_GNU_SOURCE
 
-- 
1.8.1.1


------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [LTP] [PATCH] realtime/lib: Fix includes in Makefile
  2013-01-16 20:34 [LTP] [PATCH] realtime/lib: Fix includes in Makefile Sedat Dilek
@ 2013-01-17 15:14 ` chrubis
  2013-01-21 14:04   ` chrubis
  0 siblings, 1 reply; 3+ messages in thread
From: chrubis @ 2013-01-17 15:14 UTC (permalink / raw)
  To: Sedat Dilek; +Cc: ltp-list

Hi!
> testcases/realtime/lib/Makefile:25: ../../../../config.mk: No such file or directory
> make[2]: *** No rule to make target `../../../../config.mk'.  Stop.
> 
> The patch fixes the issue by using env_pre.mk to include config.mk from
> the correct location.
> 
> Tested with ltp-full-20130109 and ltp-git (20130109-5-g385d792).
> 
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
> ---
>  testcases/realtime/lib/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/realtime/lib/Makefile b/testcases/realtime/lib/Makefile
> index 8860549..fbbb873 100644
> --- a/testcases/realtime/lib/Makefile
> +++ b/testcases/realtime/lib/Makefile
> @@ -22,7 +22,8 @@
>  
>  top_srcdir		?= ../../..
>  
> -include $(top_srcdir)/../config.mk
> +include $(top_srcdir)/include/mk/env_pre.mk
> +include $(abs_srcdir)/../config.mk
>  
>  CFLAGS			+= -D_GNU_SOURCE

I do have similar patch for this issue I've haven't commited yet (I've
asked for review and the issue faded away).

Thanks for reminding, I'll fix this.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [LTP] [PATCH] realtime/lib: Fix includes in Makefile
  2013-01-17 15:14 ` chrubis
@ 2013-01-21 14:04   ` chrubis
  0 siblings, 0 replies; 3+ messages in thread
From: chrubis @ 2013-01-21 14:04 UTC (permalink / raw)
  To: Sedat Dilek; +Cc: ltp-list

Hi!
> I do have similar patch for this issue I've haven't commited yet (I've
> asked for review and the issue faded away).
> 
> Thanks for reminding, I'll fix this.

Commited.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-21 14:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-16 20:34 [LTP] [PATCH] realtime/lib: Fix includes in Makefile Sedat Dilek
2013-01-17 15:14 ` chrubis
2013-01-21 14:04   ` chrubis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox