public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] syscalls/getdents: Add parameter to test getdents64 syscall
Date: Sat, 16 Mar 2013 11:48:24 -0400	[thread overview]
Message-ID: <201303161148.25654.vapier@gentoo.org> (raw)
In-Reply-To: <1363355370-7738-1-git-send-email-markos.chandras@gmail.com>


[-- Attachment #1.1: Type: Text/Plain, Size: 673 bytes --]

On Friday 15 March 2013 09:49:30 Markos Chandras wrote:
> Add new "-l" parameter to test the getdents64 syscall along with
> the getdents one. Use ltp_syscall() to call the system call to get
> proper return values when an architecture does not support any of the
> getdents{,64} syscalls. Modify runtest/syscalls to call getdentsXX tests
> with and without the "-l" parameter

your patch introduces a lot of warnings.  please verify it on a few arches 
first (like x86_64).

> --- a/testcases/kernel/syscalls/getdents/Makefile
> +++ b/testcases/kernel/syscalls/getdents/Makefile
> 
> +CFLAGS += -D_LARGEFILE64_SOURCE

these are CPPFLAGS, not CFLAGS
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 238 bytes --]

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2013-03-16 15:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 13:49 [LTP] [PATCH v2] syscalls/getdents: Add parameter to test getdents64 syscall Markos Chandras
2013-03-16 15:48 ` Mike Frysinger [this message]
2013-03-16 16:45   ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303161148.25654.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox