From: chrubis@suse.cz
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v4] syscalls/getdents: Add parameter to test getdents64 syscall
Date: Mon, 18 Mar 2013 15:06:35 +0100 [thread overview]
Message-ID: <20130318140635.GE3423@rei> (raw)
In-Reply-To: <1209119378.20265155.1363614409485.JavaMail.root@redhat.com>
Hi!
> > > > You don't need to bother to free the buffers when the next thing
> > > > the
> > > > test does is exit, the whole heap along with malloc data
> > > > structures
> > > > will
> > > > be freed (unmapped) by the kernel anyway.
> > >
> > > I think it's nice thing to cleanup. Say, if test corrupted heap,
> > > free could alert you. Also there are tools, which may complain,
> > > that there's a leak now. I think LTP supports at least valgrind.
> >
> > So what about compromise, defining them as variables instead of the
> > allocation?
>
> That would work. You really want that free() gone, don't you? :-).
I hate when there is unnecessary complexity in the tests that is not
really needed for the testing itself...
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-03-18 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 10:54 [LTP] [PATCH v4] syscalls/getdents: Add parameter to test getdents64 syscall Markos Chandras
2013-03-18 12:15 ` chrubis
[not found] ` <CAG2jQ8gAOvbKsoggS3o1a_9zDfVhUU9WUpxgY0g_Mp-ZcCC99w@mail.gmail.com>
2013-03-18 12:29 ` chrubis
2013-03-18 13:21 ` chrubis
[not found] ` <1004735862.20216185.1363612313920.JavaMail.root@redhat.com>
2013-03-18 13:26 ` chrubis
[not found] ` <1209119378.20265155.1363614409485.JavaMail.root@redhat.com>
2013-03-18 14:06 ` chrubis [this message]
[not found] ` <CAG2jQ8i1oovEVtF2hayXzeBzpWb78q=ntN_EJ3w0KJ3KpeXCzQ@mail.gmail.com>
2013-03-18 14:37 ` chrubis
2013-03-18 17:08 ` chrubis
2013-03-18 18:18 ` Mike Frysinger
2013-03-18 18:30 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130318140635.GE3423@rei \
--to=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox