From: chrubis@suse.cz
To: Zhouping Liu <zliu@redhat.com>
Cc: LTP List <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH v4 3/3] mm/thp: add new case thp05
Date: Mon, 15 Apr 2013 14:48:52 +0200 [thread overview]
Message-ID: <20130415124851.GD1091@rei> (raw)
In-Reply-To: <6ef835ef36aa173ec83872bddf13673a6aa47f18.1366016616.git.zliu@redhat.com>
Hi!
> + snprintf(path, BUFSIZ, PATH_KHPD "scan_sleep_millisecs");
> + SAFE_FILE_SCANF(NULL, path, "%d", &pre_thp_scan_sleep_millisecs);
> + SAFE_FILE_PRINTF(cleanup, path, "%d", 0);
> +
> + snprintf(path, BUFSIZ, PATH_KHPD "alloc_sleep_millisecs");
> + SAFE_FILE_SCANF(NULL, path, "%d", &pre_thp_alloc_sleep_millisecs);
> + SAFE_FILE_PRINTF(NULL, path, "%d", 0);
> +
> + snprintf(path, BUFSIZ, PATH_THP "enabled");
> + write_file(path, "always");
Same as the previous one. Remove the useless snprintf() and pass the
strings directly.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-04-15 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 9:29 [LTP] [PATCH v4 0/3] mm/thp: add two new case Zhouping Liu
2013-04-15 9:29 ` [LTP] [PATCH v4 1/3] mm/thp: new case thp04.c Zhouping Liu
2013-04-15 12:43 ` chrubis
[not found] ` <516C211C.1040105@redhat.com>
2013-04-15 16:26 ` chrubis
2013-04-15 9:29 ` [LTP] [PATCH v4 2/3] lib/mem: introduce a new function set_global_mempolicy() Zhouping Liu
2013-04-15 9:29 ` [LTP] [PATCH v4 3/3] mm/thp: add new case thp05 Zhouping Liu
2013-04-15 12:48 ` chrubis [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-04-16 14:30 [LTP] [PATCH v4 1/3] mm/thp: new case thp04.c Zhouping Liu
2013-04-16 14:30 ` [LTP] [PATCH v4 2/3] lib/mem: introduce a new function set_global_mempolicy() Zhouping Liu
2013-04-16 14:30 ` [LTP] [PATCH v5 0/3] mm/thp: add two new case Zhouping Liu
2013-04-16 14:30 ` [LTP] [PATCH v4 3/3] mm/thp: add new case thp05 Zhouping Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415124851.GD1091@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=zliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox