From: chrubis@suse.cz
To: shuang.qiu@oracle.com
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] Replace "-E" option for sed.
Date: Tue, 16 Apr 2013 13:20:56 +0200 [thread overview]
Message-ID: <20130416112055.GA17493@rei> (raw)
In-Reply-To: <1366099791-14020-1-git-send-email-shuang.qiu@oracle.com>
Hi!
> The '-E' option is obsoleted and is no longer supported by sed in most
> Linux distributions. Use '-r' instead.
> ---
> .../kernel/syscalls/utimensat/utimensat_tests.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> index 6776087..b8eba51 100755
> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> @@ -260,7 +260,7 @@ fi
> pattern="[[:space:]]*Defaults[[:space:]]*requiretty.*"
> if grep -q "^${pattern}" $sudoers; then
> tst_resm TINFO "Comment requiretty in $sudoers for automated testing systems"
> - if ! sed -E -i.$$ -e "s/^($pattern)/#\1/" $sudoers; then
> + if ! sed -r -i.$$ -e "s/^($pattern)/#\1/" $sudoers; then
> tst_resm TBROK "failed to mangle $sudoers properly"
> exit 1
> fi
Strangely enough both -E and -r were working on all my testing machines
but SLES9. Looking at bussybox documentation only -r is supported for
sed applet.
Commited, thanks.
(Please add Signed-off-by: line next time.)
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-04-16 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 8:09 [LTP] [PATCH] Replace "-E" option for sed shuang.qiu
2013-04-16 11:20 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416112055.GA17493@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=shuang.qiu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox