[LTP] [PATCH] Replace "-E" option for sed.

[LTP] [PATCH] Replace "-E" option for sed.

[shuang.qiu]

From: Shuang Qiu <shuang.qiu@oracle.com>

The '-E' option is obsoleted and is no longer supported by sed in most
Linux distributions.  Use '-r' instead.
---
 .../kernel/syscalls/utimensat/utimensat_tests.sh   |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
index 6776087..b8eba51 100755
--- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
+++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
@@ -260,7 +260,7 @@ fi
 pattern="[[:space:]]*Defaults[[:space:]]*requiretty.*"
 if grep -q "^${pattern}" $sudoers; then
 	tst_resm TINFO "Comment requiretty in $sudoers for automated testing systems"
-	if ! sed -E -i.$$ -e "s/^($pattern)/#\1/" $sudoers; then
+	if ! sed -r -i.$$ -e "s/^($pattern)/#\1/" $sudoers; then
 		tst_resm TBROK "failed to mangle $sudoers properly"
 		exit 1
 	fi
-- 
1.7.7


------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Replace "-E" option for sed.

[chrubis]

Hi!
> The '-E' option is obsoleted and is no longer supported by sed in most
> Linux distributions.  Use '-r' instead.
> ---
>  .../kernel/syscalls/utimensat/utimensat_tests.sh   |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> index 6776087..b8eba51 100755
> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> @@ -260,7 +260,7 @@ fi
>  pattern="[[:space:]]*Defaults[[:space:]]*requiretty.*"
>  if grep -q "^${pattern}" $sudoers; then
>  	tst_resm TINFO "Comment requiretty in $sudoers for automated testing systems"
> -	if ! sed -E -i.$$ -e "s/^($pattern)/#\1/" $sudoers; then
> +	if ! sed -r -i.$$ -e "s/^($pattern)/#\1/" $sudoers; then
>  		tst_resm TBROK "failed to mangle $sudoers properly"
>  		exit 1
>  	fi

Strangely enough both -E and -r were working on all my testing machines
but SLES9. Looking at bussybox documentation only -r is supported for
sed applet.

Commited, thanks.

(Please add Signed-off-by: line next time.)

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list